Change alignment for editable toolbar titles

This is a rather dirty but workable global change to the CSS that moves editable toolbar titles to be on the same
vertical alignment when compared to the rest of the page. However, when editing or hovering these titles, a box appears
around them (indicating an input field). Since the previous CSS assumed paddings farther up the HTML tree and the
scrolling to happen inside these paddings, we've had to move the paddings further down the HTML tree, slightly
complicating how they're applied. However, this makes the change possible with minimal changes.
pull/10473/head
Benjamin Bädorf 3 years ago
parent 265ee0147f
commit 21c8edb2b8
No known key found for this signature in database
GPG Key ID: 069CA2D117AB5CCF
  1. 4
      frontend/src/app/features/work-packages/routing/partitioned-query-space-page/partitioned-query-space-page.component.sass
  2. 2
      frontend/src/app/shared/components/editable-toolbar-title/editable-toolbar-title.component.ts
  3. 3
      frontend/src/global_styles/layout/_base.sass
  4. 3
      frontend/src/global_styles/layout/_breadcrumb.sass
  5. 3
      frontend/src/global_styles/layout/_toolbar.sass

@ -8,6 +8,10 @@
grid-template-columns: 1fr
grid-template-rows: auto auto minmax(200px, 1fr)
margin-left: -10px
padding-left: 10px
width: calc(100% + 10px)
&.-right-only
.work-packages-partitioned-page--content-left
display: none

@ -48,7 +48,7 @@ export const selectableTitleIdentifier = 'editable-toolbar-title';
selector: 'editable-toolbar-title',
templateUrl: './editable-toolbar-title.html',
styleUrls: ['./editable-toolbar-title.sass'],
host: { class: 'title-container' },
host: { class: 'title-container title-container_editable' },
})
export class EditableToolbarTitleComponent implements OnInit, OnChanges {
@Input('title') public inputTitle:string;

@ -48,7 +48,7 @@
@include default-transition
@include styled-scroll-bar
margin: 0 0 0 0
padding: 10px 20px
padding: 0px
// Needed for Safari
height: calc(100vh - var(--header-height))
overflow-y: auto
@ -65,6 +65,7 @@
#content
padding: 0
padding: 10px 20px
margin: 0
width: 100%
z-index: 10

@ -29,5 +29,8 @@
#breadcrumb
@include global-breadcrumb-styles
min-height: var(--breadcrumb-height)
padding: 10px 20px
padding-bottom: 0
li
white-space: nowrap

@ -212,6 +212,9 @@ $nm-color-success-background: #d8fdd1
&.-no-grow
flex-grow: 0
&_editable
margin-left: -7px
h2
@include text-shortener
padding: 0

Loading…
Cancel
Save