WIP: Cleanup and bug fixes

app/assets/javascripts/project/filters.js

@@ -44,6 +44,7 @@ jQuery(function($) {
   }
 
   function sendForm() {
+    $('#ajax-indicator').show();
     let $advancedFilters = $(".advanced-filters--filter", $filterForm);
     let filters = [];
     $advancedFilters.each(function(_i, filter){
@@ -73,8 +74,8 @@ jQuery(function($) {
     return false;
   }
 
+  // Register event listeners
   $filterForm.submit(sendForm)
   $button.click(toggleProjectFilterForm);
   $closeIcon.click(toggleProjectFilterForm);
-
 });

app/views/projects/index.html.erb

@@ -82,7 +82,7 @@ See doc/COPYRIGHT.rdoc for more details.
           </div>
           <div class="advanced-filters--filter-value">
             <% unless operators_without_values.include? selected_operator %>
-              <% if filter.type == :list_optional %>
+              <% if %i(list list_optional list_all ).include? filter.type %>
                 <div>
                   <span class="inline-label">
                     <%= select_tag :value,
@@ -90,7 +90,7 @@ See doc/COPYRIGHT.rdoc for more details.
                                      filter.allowed_values,
                                      :second,
                                      :first,
-                                     @query.find_active_filter(name)
+                                     @query.find_active_filter(filter.name)
                                            .try(:values)
                                            .try(:first)),
                                    class: 'form--select -small' %>