Refactor tests of API V3's anonymous user behavior

spec/requests/api/v3/activity_resource_spec.rb

@@ -76,32 +76,8 @@ describe 'API v3 Activity resource', :type => :request do
       end
     end
 
-    context 'anonymous user' do
-      let(:get_path) { "/api/v3/activities/#{activity.id}" }
-      let(:project) { FactoryGirl.create(:project, is_public: true) }
-
-      context 'when access for anonymous user is allowed' do
-        before { get get_path }
-
-        it 'should respond with 200' do
-          expect(subject.status).to eq(200)
-        end
-
-        it 'should respond with correct activity' do
-          expect(subject.body).to include_json('Activity'.to_json).at_path('_type')
-          expect(subject.body).to be_json_eql(activity.id.to_json).at_path('id')
-        end
-      end
-
-      context 'when access for anonymous user is not allowed' do
-        before do
-          Setting.login_required = 1
-          get get_path
-        end
-        after { Setting.login_required = 0 }
-
-        it_behaves_like 'unauthenticated access'
-      end
+    it_behaves_like 'handling anonymous user', 'Activity', '/api/v3/activities/%s' do
+      let(:id) { activity.id }
     end
   end
 end

spec/requests/api/v3/attachment_resource_spec.rb

@@ -75,31 +75,8 @@ describe 'API v3 Attachment resource', :type => :request do
       end
     end
 
-    context 'anonymous user' do
-      let(:get_path) { "/api/v3/attachments/#{attachment.id}" }
-      let(:project) { FactoryGirl.create(:project, is_public: true) }
-
-      context 'when access for anonymous user is allowed' do
-        before { get get_path }
-
-        it 'should respond with 200' do
-          expect(subject.status).to eq(200)
-        end
-
-        it 'should respond with correct activity' do
-          expect(subject.body).to be_json_eql(attachment.filename.to_json).at_path('fileName')
-        end
-      end
-
-      context 'when access for anonymous user is not allowed' do
-        before do
-          Setting.login_required = 1
-          get get_path
-        end
-        after { Setting.login_required = 0 }
-
-        it_behaves_like 'unauthenticated access'
-      end
+    it_behaves_like 'handling anonymous user', 'Attachment', '/api/v3/attachments/%s' do
+      let(:id) { attachment.id }
     end
   end
 end

spec/requests/api/v3/support/authorization.rb

@@ -0,0 +1,59 @@
+#-- copyright
+# OpenProject is a project management system.
+# Copyright (C) 2012-2014 the OpenProject Foundation (OPF)
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+require 'spec_helper'
+
+shared_examples_for 'handling anonymous user' do |type, path|
+  context 'anonymous user' do
+    let(:get_path) { path % [id] }
+    let(:project) { FactoryGirl.create(:project, is_public: true) }
+
+    context 'when access for anonymous user is allowed' do
+      before { get get_path }
+
+      it 'should respond with 200' do
+        expect(subject.status).to eq(200)
+      end
+
+      it 'should respond with correct type' do
+        expect(subject.body).to include_json(type.to_json).at_path('_type')
+        expect(subject.body).to be_json_eql(id.to_json).at_path('id')
+      end
+    end
+
+    context 'when access for anonymous user is not allowed' do
+      before do
+        Setting.login_required = 1
+        get get_path
+      end
+      after { Setting.login_required = 0 }
+
+      it_behaves_like 'unauthenticated access'
+    end
+  end
+end

spec/requests/api/v3/user_resource_spec.rb

@@ -62,30 +62,8 @@ describe 'API v3 User resource', :type => :request do
       end
     end
 
-    context 'anonymous user' do
-      let(:get_path) { "/api/v3/users/#{user.id}" }
-
-      context 'when access for anonymous user is allowed' do
-        before { get get_path }
-
-        it 'should respond with 200' do
-          expect(subject.status).to eq(200)
-        end
-
-        it 'should respond with correct activity' do
-          expect(subject.body).to be_json_eql(user.name.to_json).at_path('name')
-        end
-      end
-
-      context 'when access for anonymous user is not allowed' do
-        before do
-          Setting.login_required = 1
-          get get_path
-        end
-        after { Setting.login_required = 0 }
-
-        it_behaves_like 'unauthenticated access'
-      end
+    it_behaves_like 'handling anonymous user', 'User', '/api/v3/users/%s' do
+      let(:id) { user.id }
     end
   end
 end