Merge pull request #385 from opf/features/improve_cukes

use the 'already logged in' step in all cukes

features/groups/membership.feature

@@ -34,7 +34,7 @@ Feature: Group memberships
   Scenario: Adding a group with members to a project
     Given the group "group1" has the following members:
       | alice     |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
     When I go to the members tab of the settings page of the project "project1"
     And I add the principal "group1" as a member with the roles:
       | beta |
@@ -60,7 +60,7 @@ Feature: Group memberships
     Given the group "group1" has the following members:
       | alice     |
     And the group "group1" is a "beta" in the project "project1"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
     When I go to the members tab of the settings page of the project "project1"
     And I follow the delete link of the project member "group1"
     Then I should not see the principal "group1" as a member
@@ -72,7 +72,7 @@ Feature: Group memberships
       | alice     |
     And the user "alice" is a "alpha" in the project "project1"
     And the group "group1" is a "beta" in the project "project1"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
     When I go to the members tab of the settings page of the project "project1"
     And I follow the delete link of the project member "group1"
     Then I should not see the principal "group1" as a member

features/issues/copy_with_watchers.feature

@@ -48,7 +48,7 @@ Feature: Copying an issue should copy the watchers
       | ndnd |
 
   Scenario: Watchers shouldn't be copied when the user doesn't have the permission to
-    Given I am logged in as "ndnd"
+    Given I am already logged in as "ndnd"
     When I go to the copy page for the issue "Improve drive"
     Then I should not see "Watchers"
     When I fill in "issue_subject" with "Improve drive even more"
@@ -57,7 +57,7 @@ Feature: Copying an issue should copy the watchers
     And the issue "Improve drive even more" should have 0 watchers
 
   Scenario: Watchers should be copied when the user has the permission to
-    Given I am logged in as "lrrr"
+    Given I am already logged in as "lrrr"
     When I go to the copy page for the issue "Improve drive"
     Then I should see "Watchers" within "p#watchers_form"
     When I fill in "issue_subject" with "Improve drive even more"

features/issues/export.feature

@@ -26,7 +26,7 @@ Feature: Exporting issues
     And the user "bob" is a "member" in the project "project1"
     And the user "bob" has 1 issue with the following:
       | subject | Some Issue |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: No export links on project issues index if user has no "export_issues" permission
     When I go to the issues index page of the project called "project1"

features/issues/index_pagination.feature

@@ -28,7 +28,7 @@ Feature: Paginated issue index list
     And the user "bob" is a "member" in the project "project1"
     And the user "bob" has 101 issues with the following:
       | subject    | Issuesubject |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Pagination within a project
     When I go to the issues index page of the project "project1"

features/issues/issue_new.feature

@@ -36,7 +36,7 @@ Feature: Issue edit
     And there are the following issue status:
       | name        | is_closed  | is_default  |
       | New         | false      | true        |
-    And I am logged in as "lrrr"
+    And I am already logged in as "lrrr"
 
   Scenario: While creating an issue the user can change attributes which are overriden by children
     When I go to the new work_package page of the project called "omicronpersei8"

features/issues/issue_show.feature

@@ -32,7 +32,7 @@ Feature: Watch issues
     And the user "bob" is a "member" in the project "parent"
     Given the user "bob" has 1 issue with the following:
       | subject     | issue1              |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   @javascript
   Scenario: Watch an issue

features/menu_items.feature

@@ -22,7 +22,7 @@ Feature: Menu items
     And there is 1 user with the following:
       | login | bob |
     And the user "bob" is a "member" in the project "Awesome Project"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Calendar menu should be visible when calendar is activated
     When I go to the overview page of the project "Awesome Project"

features/messages/message.feature

@@ -28,7 +28,7 @@ Feature: Issue textile quickinfo links
     And there is 1 user with the following:
       | login | bob|
     And the user "bob" is a "member" in the project "parent"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Adding a message to a forum
     When I go to the boards page of the project called "parent"

features/project_associations/project_association_management.feature

@@ -78,7 +78,7 @@ Feature: Project Association Management
       And the user "Project-Admin" is a "Project Admin"
 
   Scenario: Reader does not render anything when there are no project associations
-    Given I am logged in as "Viewer"
+    Given I am already logged in as "Viewer"
      When I go to the   page of the project called "My Project"
       And I toggle the "Timelines" submenu
       And I follow "Dependencies"
@@ -88,7 +88,7 @@ Feature: Project Association Management
       And I should not see "No data to display"
 
   Scenario: Reader gets 'No data to display' when there are associations to unknown projects
-    Given I am logged in as "Viewer"
+    Given I am already logged in as "Viewer"
       And there are the following project associations:
           | Project A  | Project B |
           | My Project | Other     |
@@ -102,7 +102,7 @@ Feature: Project Association Management
       And I should not see "No data to display"
 
   Scenario: Reader sees associations to projects where s/he is member and to public ones
-    Given I am logged in as "Viewer"
+    Given I am already logged in as "Viewer"
       And there are the following project associations:
           | Project A  | Project B  |
           | My Project | Visible    |
@@ -118,14 +118,14 @@ Feature: Project Association Management
       And I should see "Scrum" below "Scrum Project"
 
   Scenario: Reader is not able to add associations
-    Given I am logged in as "Viewer"
+    Given I am already logged in as "Viewer"
      When I go to the   page of the project called "My Project"
       And I click on "Dependencies"
       And I should not be able to add new project associations
 
   @javascript
   Scenario: Editor is able to add associations
-    Given I am logged in as "Editor"
+    Given I am already logged in as "Editor"
      When I go to the   page of the project called "My Project"
       And I toggle the "Timelines" submenu
       And I click on "Dependencies"
@@ -139,7 +139,7 @@ Feature: Project Association Management
       And I should see "Visible" below "Waterfall Project"
 
   Scenario: Editor is able to edit associations
-    Given I am logged in as "Editor"
+    Given I am already logged in as "Editor"
       And there are the following project associations:
           | Project A  | Project B | Description   |
           | My Project | Visible   | A good reason |
@@ -155,7 +155,7 @@ Feature: Project Association Management
       And I should see "A better reason" below "Waterfall Project"
 
    Scenario: Editor cannot delete associations
-    Given I am logged in as "Editor"
+    Given I am already logged in as "Editor"
       And there are the following project associations:
           | Project A  | Project B | Description   |
           | My Project | Visible   | A good reason |
@@ -166,7 +166,7 @@ Feature: Project Association Management
      Then I should not see "Delete Visible"
 
    Scenario: Project-Admin may delete associations
-    Given I am logged in as "Project-Admin"
+    Given I am already logged in as "Project-Admin"
       And there are the following project associations:
           | Project A  | Project B | Description   |
           | My Project | Visible   | A good reason |

features/projects/show.feature

@@ -24,7 +24,7 @@ Feature: Showing Projects
     And there is 1 user with the following:
       | login | bob |
     And the user "bob" is a "CanViewCal" in the project "omicronpersei8"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Calendar link in the 'tickets box' should work when calendar is activated
     When I go to the overview page of the project "omicronpersei8"

features/reportings/reporting_permissions.feature

@@ -78,7 +78,7 @@ Feature: Reporting Permissions
 
   @javascript
   Scenario: Creating a reporting by a privileged user
-     When I am logged in as "privileged"
+     When I am already logged in as "privileged"
       And I go to the page of the project called "Santas Project"
       And I toggle the "Timelines" submenu
       And I click on "Status reportings"
@@ -90,7 +90,7 @@ Feature: Reporting Permissions
      Then I should see "Successful creation."
 
   Scenario: Editing a reporting as a privileged user
-    Given I am logged in as "privileged"
+    Given I am already logged in as "privileged"
       And there are the following reportings:
           | Project        | Reporting To Project | Reported Project Status Comment |
           | Santas Project | World Domination     | Hallo Junge                     |
@@ -107,7 +107,7 @@ Feature: Reporting Permissions
 
   Scenario: Cannot create a reporting as an unprivileged user
     Given the user "observer" is a "view reportings" in the project "Santas Project"
-      And I am logged in as "observer"
+      And I am already logged in as "observer"
      When I go to the page of the project called "Santas Project"
       And I toggle the "Timelines" submenu
       And I click on "Status reportings"
@@ -119,7 +119,7 @@ Feature: Reporting Permissions
       And there are the following reportings:
           | Project        | Reporting To Project | Reported Project Status Comment |
           | Santas Project | World Domination     | Hallo Junge                     |
-      And I am logged in as "editor"
+      And I am already logged in as "editor"
      When I go to the page of the project called "Santas Project"
       And I toggle the "Timelines" submenu
       And I click on "Status reportings"

features/timelines/timeline_view_with_reporters.feature

@@ -133,7 +133,7 @@ Feature: Timeline View Tests with reporters
           | ecookbook0 | ecookbook_q3 |
 
 
-      And I am logged in as "manager"
+      And I am already logged in as "manager"
 
   @javascript
   Scenario: Filter Empty Projects

features/wiki/wiki_index.feature

@@ -22,7 +22,7 @@ Feature: Viewing the wiki index page
       | name       | project1 |
       | identifier | project1 |
     And the user "bob" is a "member" in the project "project1"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Visiting the wiki index page without a related page should show the overall index page and select no menu item
     When I go to the wiki index page of the project called "project1"

features/wiki/wiki_links.feature

@@ -28,7 +28,7 @@ Feature: Check links to a wiki page
     And I am working in project "project1"
     And the project uses the following modules:
       | wiki |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Check activity link
     When I go to the activity page of the project "project1"

features/wiki/wiki_new_child.feature

@@ -23,7 +23,7 @@ Feature: Viewing the wiki new child page
       | name       | project1 |
       | identifier | project1 |
     And the user "bob" is a "member" in the project "project1"
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   Scenario: Visiting the wiki new child page with a parent page that has the new child page option enabled on it's menu item should show the page and select the toc menu entry within the wiki menu item
     Given the project "project1" has 1 wiki page with the following:

features/wiki/wiki_rename.feature

@@ -25,7 +25,7 @@ Feature: Renaming a wiki page
     And the user "bob" is a "member" in the project "project1"
     And the project "project1" has 1 wiki page with the following:
       | title | WikiPage |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
   @javascript
   Scenario: Renaming a wiki page
@@ -35,4 +35,4 @@ Feature: Renaming a wiki page
     And I fill in "New WikiPage" for "Title"
     And I press "Rename"
     Then I should be on the wiki page "New_WikiPage" of the project called "project1"
-    And I should see "Successful update." within ".notice"
+    And I should see "Successful update." within ".notice"

features/wiki_menu_items/wiki_menu_items.feature

@@ -26,7 +26,7 @@ Feature: Wiki menu items
       | Title | Wiki |
     And the project "Awesome Project" has 1 wiki page with the following:
       | Title | AwesomePage |
-    And I am logged in as "bob"
+    And I am already logged in as "bob"
 
     @javascript
   Scenario: Adding a main menu entry without index and toc links