From 267f95b365b54379d5ca6810b00cdad07bb93af9 Mon Sep 17 00:00:00 2001
From: HDinger <HDinger@users.noreply.github.com>
Date: Thu, 28 Apr 2016 15:34:28 +0200
Subject: [PATCH] Remove tabindex attribute (#4367)

---
 app/assets/stylesheets/content/_accounts.sass   |  1 +
 app/views/account/_password_login_form.html.erb | 11 ++++++-----
 app/views/hooks/login/_auth_provider.html.erb   |  2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/app/assets/stylesheets/content/_accounts.sass b/app/assets/stylesheets/content/_accounts.sass
index 73eed58983..ae8b5bd0f0 100644
--- a/app/assets/stylesheets/content/_accounts.sass
+++ b/app/assets/stylesheets/content/_accounts.sass
@@ -37,6 +37,7 @@
     .login-links
       float: right
       text-align: right
+      margin-top: -3rem
 
 #content .login-auth-providers.wide
   width: auto
diff --git a/app/views/account/_password_login_form.html.erb b/app/views/account/_password_login_form.html.erb
index 4a3349f7e9..67d7304653 100644
--- a/app/views/account/_password_login_form.html.erb
+++ b/app/views/account/_password_login_form.html.erb
@@ -33,14 +33,14 @@ See doc/COPYRIGHT.rdoc for more details.
   <div class="form--field">
     <%= styled_label_tag 'username', User.human_attribute_name(:login) %>
     <div class="form--field-container">
-      <%= styled_text_field_tag 'username', params[:username], tabindex: 1 %>
+      <%= styled_text_field_tag 'username', params[:username] %>
     </div>
   </div>
 
   <div class="form--field">
     <%= styled_label_tag 'password', User.human_attribute_name(:password) %>
     <div class="form--field-container">
-      <%= styled_password_field_tag 'password', nil, tabindex: 2, autofocus: params.include?(:username) %>
+      <%= styled_password_field_tag 'password', nil, autofocus: params.include?(:username) %>
     </div>
   </div>
 
@@ -55,17 +55,18 @@ See doc/COPYRIGHT.rdoc for more details.
     </div>
   <% end %>
 
+  <input type="submit" name="login" value="<%=l(:button_login)%>" class="button -highlight" />
+
   <div class="login-options-container">
     <div class="login-links">
       <% if Setting.lost_password? %>
-        <%= link_to l(:label_password_lost), { controller: '/account', action: 'lost_password' }, tabindex: "4" %>
+        <%= link_to l(:label_password_lost), { controller: '/account', action: 'lost_password' } %>
         <br>
       <% end %>
       <% if Setting.self_registration? %>
-        <%= link_to l(:label_register), { controller: '/account', action: 'register' }, tabindex: "5" %>
+        <%= link_to l(:label_register), { controller: '/account', action: 'register' } %>
       <% end %>
     </div>
   </div>
-  <input type="submit" name="login" value="<%=l(:button_login)%>" class="button -highlight" tabindex="3" />
   <%= javascript_tag "Form.Element.focus('username');" %>
 <% end %>
diff --git a/app/views/hooks/login/_auth_provider.html.erb b/app/views/hooks/login/_auth_provider.html.erb
index 5c46962e01..2414293659 100644
--- a/app/views/hooks/login/_auth_provider.html.erb
+++ b/app/views/hooks/login/_auth_provider.html.erb
@@ -28,7 +28,7 @@ See doc/COPYRIGHT.rdoc for more details.
 ++#%>
 
 <% unless Rails.env.production? %>
-  <a tabindex="6" href="<%= url_for controller: '/auth', action: 'developer' %>" class="auth-provider auth-provider-developer">
+  <a href="<%= url_for controller: '/auth', action: 'developer' %>" class="auth-provider auth-provider-developer">
     <span class="auth-provider-name">Omniauth Developer</span>
   </a>
 <% end %>