Remove invalid description spec

pull/4401/head
Oliver Günther 9 years ago
parent 3c31b67115
commit 2bdf6ac776
  1. 3
      frontend/app/components/wp-buttons/wp-inline-create-button/wp-inline-create-button.controller.ts
  2. 2
      frontend/app/components/wp-buttons/wp-view-button/wp-view-button.directive.ts
  3. 3
      frontend/app/components/wp-edit/wp-edit-field/wp-edit-field.directive.ts
  4. 18
      spec/features/work_packages/details/activity_comments_spec.rb

@ -28,6 +28,7 @@
import {wpButtonsModule} from '../../../angular-modules';
import WorkPackageCreateButtonController from '../wp-create-button/wp-create-button.controller';
import {HalResource} from "../../api/api-v3/hal-resources/hal-resource.service";
class WorkPackageInlineCreateButtonController extends WorkPackageCreateButtonController {
public query: op.Query;
@ -35,7 +36,7 @@ class WorkPackageInlineCreateButtonController extends WorkPackageCreateButtonCon
public hidden:boolean = false;
// Template create form
protected form: op.HalResource;
protected form: HalResource;
private _wp;

@ -53,7 +53,7 @@ export class WorkPackageViewButtonController extends WorkPackageNavigationButton
public openWorkPackageShowView() {
var args = ['work-packages.new', this.$state.params];
if (!this.$state.is('work-packages.list.new') {
if (!this.$state.is('work-packages.list.new')) {
var params = {
workPackageId: this.$state.params.workPackageId || this.workPackageId || this.nextWpFunc()
};

@ -141,8 +141,7 @@ export class WorkPackageEditFieldController {
}
public shouldFocus() {
return this._forceFocus || !this.workPackage.isNew ||
this.formCtrl.firstActiveField === this.fieldName;
return this._forceFocus || this.formCtrl.firstActiveField === this.fieldName;
}
public focusField() {

@ -33,24 +33,6 @@ describe 'activity comments', js: true, selenium: true do
wp_page.ensure_page_loaded
end
describe 'submitting with other fields' do
let(:description) { WorkPackageTextAreaField.new wp_page, 'description' }
before do
comment_field.activate!
comment_field.input_element.set 'comment with description'
description.activate!
description.input_element.set 'description goes here'
end
it 'saves both fields from comment submit' do
comment_field.input_element.set 'some ingenious comment.'
comment_field.submit_by_click
expect(page).to have_selector('.user-comment .message', text: 'some ingenious comment.')
expect(description.input_element.value).to eq('description goes here')
end
end
context 'in edit state' do
before do
comment_field.activate!

Loading…
Cancel
Save