ngClick and ngDblClick interfer with each other. That is why we need an additional directive to separate single and double click events reliably.pull/1746/head
parent
cacded3989
commit
38d991f113
@ -0,0 +1,63 @@ |
||||
//-- copyright
|
||||
// OpenProject is a project management system.
|
||||
// Copyright (C) 2012-2014 the OpenProject Foundation (OPF)
|
||||
//
|
||||
// This program is free software; you can redistribute it and/or
|
||||
// modify it under the terms of the GNU General Public License version 3.
|
||||
//
|
||||
// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
||||
// Copyright (C) 2006-2013 Jean-Philippe Lang
|
||||
// Copyright (C) 2010-2013 the ChiliProject Team
|
||||
//
|
||||
// This program is free software; you can redistribute it and/or
|
||||
// modify it under the terms of the GNU General Public License
|
||||
// as published by the Free Software Foundation; either version 2
|
||||
// of the License, or (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU General Public License
|
||||
// along with this program; if not, write to the Free Software
|
||||
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
||||
//
|
||||
// See doc/COPYRIGHT.rdoc for more details.
|
||||
//++
|
||||
|
||||
// TODO move to UI components
|
||||
angular.module('openproject.uiComponents') |
||||
|
||||
.constant('DOUBLE_CLICK_DELAY', 300) |
||||
|
||||
// Thanks to http://stackoverflow.com/a/20445344
|
||||
.directive('singleClick', [ |
||||
'DOUBLE_CLICK_DELAY', |
||||
'$parse', |
||||
'$timeout', |
||||
function(DOUBLE_CLICK_DELAY, $parse, $timeout) { |
||||
|
||||
return { |
||||
restrict: 'A', |
||||
link: function(scope, element, attrs) { |
||||
var fn = $parse(attrs.singleClick); |
||||
var clicks = 0, timer = null; |
||||
|
||||
if (fn) { |
||||
element.on('click', function (event) { |
||||
clicks++; //count clicks
|
||||
if(clicks === 1) { |
||||
timer = $timeout(function() { |
||||
fn(scope, { $event: event }); |
||||
clicks = 0; //after action performed, reset counter
|
||||
}, DOUBLE_CLICK_DELAY); |
||||
} else { |
||||
$timeout.cancel(timer); //prevent single-click action
|
||||
clicks = 0; //after action performed, reset counter
|
||||
} |
||||
}); |
||||
} |
||||
} |
||||
}; |
||||
}]); |
Loading…
Reference in new issue