From 4102cade8b17b925f7b507eb6d9dabb8d0ce87d5 Mon Sep 17 00:00:00 2001
From: Henriette Darge <h.darge@openproject.com>
Date: Fri, 13 May 2022 11:22:55 +0200
Subject: [PATCH] Write test cases for the new date picker logic

---
 .../datepicker/datepicker.modal.html          |  2 +
 .../work_packages/details/date_editor_spec.rb | 80 ++++++++++++++++++-
 spec/support/edit_fields/date_edit_field.rb   |  6 ++
 3 files changed, 86 insertions(+), 2 deletions(-)

diff --git a/frontend/src/app/shared/components/datepicker/datepicker.modal.html b/frontend/src/app/shared/components/datepicker/datepicker.modal.html
index a810e0d86b..9dc3a5d597 100644
--- a/frontend/src/app/shared/components/datepicker/datepicker.modal.html
+++ b/frontend/src/app/shared/components/datepicker/datepicker.modal.html
@@ -48,6 +48,7 @@
             <div class="form--text-field-container -xslim">
               <input type="text"
                      name="startDate"
+                     data-qa-selector="op-datepicker-modal--start-date-field"
                      class="form--date-field"
                      [ngClass]="{'-current' : datepickerHelper.isStateOfCurrentActivatedField('start')}"
                      [ngModel]="dates.start"
@@ -79,6 +80,7 @@
             <div class="form--text-field-container -xslim">
               <input type="text"
                      name="endDate"
+                     data-qa-selector="op-datepicker-modal--end-date-field"
                      class="form--date-field"
                      [ngClass]="{'-current' : datepickerHelper.isStateOfCurrentActivatedField('end')}"
                      [ngModel]="dates.end"
diff --git a/spec/features/work_packages/details/date_editor_spec.rb b/spec/features/work_packages/details/date_editor_spec.rb
index 4f35f49720..39d63d0968 100644
--- a/spec/features/work_packages/details/date_editor_spec.rb
+++ b/spec/features/work_packages/details/date_editor_spec.rb
@@ -37,7 +37,7 @@ describe 'date inplace editor',
          with_settings: { date_format: '%Y-%m-%d' },
          js: true, selenium: true do
   let(:project) { create :project_with_types, public: true }
-  let(:work_package) { create :work_package, project: project, start_date: '2016-01-01' }
+  let(:work_package) { create :work_package, project: project, start_date: '2016-01-02' }
   let(:user) { create :admin }
   let(:work_packages_page) { Pages::FullWorkPackage.new(work_package, project) }
   let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -61,7 +61,20 @@ describe 'date inplace editor',
 
     start_date.save!
     start_date.expect_inactive!
-    start_date.expect_state_text '2016-01-01 - 2016-01-25'
+    start_date.expect_state_text '2016-01-02 - 2016-01-25'
+  end
+
+  it 'reverses the dates if the selected date is before the current start date' do
+    start_date.activate!
+    start_date.expect_active!
+
+    start_date.datepicker.expect_year '2016'
+    start_date.datepicker.expect_month 'January', true
+    start_date.datepicker.select_day '1'
+
+    start_date.save!
+    start_date.expect_inactive!
+    start_date.expect_state_text '2016-01-01 - 2016-01-02'
   end
 
   it 'can set "today" as a date via the provided link' do
@@ -79,6 +92,69 @@ describe 'date inplace editor',
     start_date.expect_state_text "#{Time.zone.today.strftime('%Y-%m-%d')} - no finish date"
   end
 
+  context 'with start and end date set' do
+    let(:work_package) { create :work_package, project: project, start_date: '2016-01-02', due_date: '2016-01-25' }
+
+    it 'selecting a date before the current start date will change the start date' do
+      start_date.activate!
+      start_date.expect_active!
+
+      start_date.datepicker.expect_year '2016'
+      start_date.datepicker.expect_month 'January', true
+      start_date.datepicker.select_day '1'
+
+      start_date.save!
+      start_date.expect_inactive!
+      start_date.expect_state_text '2016-01-01 - 2016-01-25'
+    end
+
+    it 'selecting a date in between changes the date that is currently in focus' do
+      start_date.activate!
+      start_date.expect_active!
+
+      start_date.datepicker.expect_year '2016'
+      start_date.datepicker.expect_month 'January', true
+      start_date.datepicker.select_day '3'
+
+      # Since the focus shifts automatically, we can directly click again to modify the end date
+      start_date.datepicker.select_day '21'
+
+      start_date.save!
+      start_date.expect_inactive!
+      start_date.expect_state_text '2016-01-03 - 2016-01-21'
+    end
+
+    it 'selecting a date after the current finish date will change either start or finish depending on the focus' do
+      start_date.activate!
+      start_date.expect_active!
+
+      start_date.datepicker.expect_year '2016'
+      start_date.datepicker.expect_month 'January', true
+
+      # Focus the end date field
+      start_date.activate_due_date_within_modal
+      start_date.datepicker.set_date '2016-03-01', true
+
+      # Since the end date is focused, the date will become the new end date
+      start_date.save!
+      start_date.expect_inactive!
+      start_date.expect_state_text '2016-01-02 - 2016-03-01'
+
+      # Activating again and now changing the start date to something after the current end date
+      start_date.activate!
+      start_date.expect_active!
+
+      start_date.datepicker.expect_year '2016'
+      start_date.datepicker.expect_month 'January', true
+      start_date.datepicker.set_date '2016-04-01', true
+
+      # This will set the new start and unset the end date
+      start_date.save!
+      start_date.expect_inactive!
+      start_date.expect_state_text '2016-04-01 - no finish date'
+    end
+  end
+
   context 'with the start date empty' do
     let(:work_package) { create :work_package, project: project, start_date: nil }
 
diff --git a/spec/support/edit_fields/date_edit_field.rb b/spec/support/edit_fields/date_edit_field.rb
index 84ac037b1d..5b4f449009 100644
--- a/spec/support/edit_fields/date_edit_field.rb
+++ b/spec/support/edit_fields/date_edit_field.rb
@@ -56,6 +56,12 @@ class DateEditField < EditField
     end
   end
 
+  def activate_due_date_within_modal
+    within_modal do
+      find('[data-qa-selector="op-datepicker-modal--end-date-field"]').click
+    end
+  end
+
   def modal_element
     page.find(modal_selector)
   end