Fix event type retrieval in work packages activity provider (#3723)

app/models/activity/work_package_activity_provider.rb

@@ -68,7 +68,7 @@ class Activity::WorkPackageActivityProvider < Activity::BaseActivityProvider
     if journal.changed_data.empty? && !journal.initial?
       state = '-note'
     else
-      state = event['status_closed'] ? '-closed' : '-edit'
+      state = ActiveRecord::ConnectionAdapters::Column.value_to_boolean(event['status_closed']) ? '-closed' : '-edit'
     end
 
     "work_package#{state}"

lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb

@@ -115,7 +115,7 @@ module Redmine
 
             query = query.where(journals_table[:user_id].eq(options[:author].id)) if options[:author]
 
-            
+
             provider.extend_event_query(query, activity) if provider.respond_to?(:extend_event_query)
 
             query = join_with_projects_table(query, provider.projects_reference_table(activity))

spec/models/activity/work_package_activity_provider_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe Activity::WorkPackageActivityProvider do
+  let(:event_scope)               { 'work_packages' }
+  let(:work_package_edit_event)   { 'work_package-edit' }
+  let(:work_package_closed_event) { 'work_package-closed' }
+
+  let(:user)          { FactoryGirl.create :admin }
+  let(:status_closed) { FactoryGirl.create :closed_status }
+  let(:work_package)  { FactoryGirl.build  :work_package }
+
+  let(:subject) { Activity::WorkPackageActivityProvider.find_events(event_scope, user, Date.today, Date.tomorrow, {}).last.try :event_type }
+
+  describe 'latest event' do
+    context 'when a work package has been created' do
+      before { work_package.save }
+
+      it { should == work_package_edit_event }
+
+      context 'and has been closed' do
+        before { work_package.update_attributes status_id: status_closed.id }
+
+        it { should == work_package_closed_event }
+      end
+    end
+  end
+end