Added pending specs for activity resource

Gemfile

@@ -182,15 +182,18 @@ end
 
 group :development do
   gem 'letter_opener', '~> 1.0.0'
+  gem 'rails-dev-tweaks', '~> 0.6.1'
+  gem 'thin'
+  gem 'faker'
+  gem 'quiet_assets'
+end
+
+group :development, :test do
   gem 'pry-rails'
   gem 'pry-stack_explorer'
   gem 'pry-rescue'
   gem 'pry-byebug', :platforms => [:mri_20,:mri_21]
   gem 'pry-doc'
-  gem 'rails-dev-tweaks', '~> 0.6.1'
-  gem 'thin'
-  gem 'faker'
-  gem 'quiet_assets'
 end
 
 # API gems

spec/api/activity_resource_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+require 'rack/test'
+
+describe 'API v3 Activity resource' do
+  include Rack::Test::Methods
+
+  let(:current_user) { FactoryGirl.create(:user) }
+  let(:project) { FactoryGirl.create(:project, is_public: true) }
+  let(:work_package) { FactoryGirl.create(:work_package, author: current_user, project: project) }
+  let(:role) { FactoryGirl.create(:role, permissions: [:view_work_packages]) }
+  let(:activity) { FactoryGirl.create(:work_package_journal, journable: work_package, user: current_user) }
+  let(:model) { ::API::V3::Activities::ActivityModel.new(activity) }
+  let(:representer) { ::API::V3::Activities::ActivityRepresenter.new(model) }
+
+  describe '#get' do
+    subject(:response) { last_response }
+
+    context 'logged in user' do
+      let(:get_path) { "/api/v3/activities/#{activity.id}" }
+      before(:each) do
+        allow(User).to receive(:current).and_return current_user
+        member = FactoryGirl.build(:member, user: current_user, project: work_package.project)
+        member.role_ids = [role.id]
+        member.save!
+        get get_path
+      end
+
+      xit 'should respond with 200' do
+        expect(subject.status).to eq(200)
+      end
+
+      xit 'should respond with correct activity' do
+        expect(subject.body).to be_json_eql(representer.to_json)
+      end
+
+      context 'requesting nonexistent activity' do
+        let(:get_path) { "/api/v3/activities/9999" }
+        xit 'should respond with 404' do
+          expect(subject.status).to eq(404)
+        end
+
+        xit 'should respond with explanatory error message' do
+          expect(subject.body).to include_json('not_found'.to_json).at_path('title')
+        end
+      end
+
+      context 'requesting activity without sufficient permissions' do
+        let(:project) { FactoryGirl.create(:project, is_public: false) }
+        let(:work_package) { FactoryGirl.create(:work_package, project: project) }
+
+        xit 'should respond with 403' do
+        end
+
+        xit 'should respond with explanatory error message' do
+        end
+      end
+    end
+
+    context 'anonymous user' do
+      let(:get_path) { "/api/v3/activities/#{activity.id}" }
+
+      context 'when access for anonymous user is allowed' do
+        before do
+          Setting.login_required = 0
+          get get_path
+        end
+
+        xit 'should respond with 200' do
+          expect(subject.status).to eq(200)
+        end
+
+        xit 'should respond with correct activity' do
+          expect(subject.body).to be_json_eql(representer.to_json)
+        end
+      end
+
+      context 'when access for anonymous user is not allowed' do
+        before do
+          Setting.login_required = 1
+          get get_path
+        end
+
+        xit 'should respond with 401' do
+          expect(subject.status).to eq(401)
+        end
+
+        xit 'should respond with explanatory error message' do
+          expect(subject.body).to include_json('not_authenticated'.to_json).at_path('title')
+        end
+      end
+    end
+  end
+end

spec/factories/journal_factory.rb

@@ -30,7 +30,7 @@ FactoryGirl.define do
   factory :journal do
     user factory: :user
     created_at Time.now
-    sequence(:version) {|n| n}
+    sequence(:version) {|n| n+1 }
 
     factory :work_package_journal, class: Journal do
       journable_type "WorkPackage"