replace legacy spec

app/models/wiki.rb

@@ -44,7 +44,7 @@ class Wiki < ApplicationRecord
                                 allow_destroy: true,
                                 reject_if: proc { |attr| attr['name'].blank? && attr['title'].blank? }
 
-  validates_presence_of :start_page
+  validates :start_page, presence: true
 
   after_create :create_menu_item_for_start_page
 

spec/models/wiki_spec.rb

@@ -29,10 +29,11 @@
 require 'spec_helper'
 
 describe Wiki, type: :model do
-  describe 'creation' do
-    let(:project) { FactoryBot.create(:project, disable_modules: 'wiki') }
-    let(:start_page) { 'The wiki start page' }
+  let(:project) { FactoryBot.create(:project, disable_modules: 'wiki') }
+  let(:start_page) { 'The wiki start page' }
+  let(:wiki) { project.create_wiki start_page: start_page }
 
+  describe 'creation' do
     it_behaves_like 'acts_as_watchable included' do
       let(:model_instance) { FactoryBot.create(:wiki) }
       let(:watch_permission) { :view_wiki_pages }
@@ -40,8 +41,6 @@ describe Wiki, type: :model do
     end
 
     describe '#create' do
-      let(:wiki) { project.create_wiki start_page: start_page }
-
       it 'creates a wiki menu item on creation' do
         expect(wiki.wiki_menu_items).to be_one
       end
@@ -49,28 +48,86 @@ describe Wiki, type: :model do
       it 'sets the wiki menu item title to the name of the start page' do
         expect(wiki.wiki_menu_items.first.title).to eq(start_page)
       end
+
+      it 'requires a start_page' do
+        wiki = project.create_wiki start_page: nil
+        expect(wiki)
+          .to be_new_record
+      end
     end
+  end
 
-    describe '#find_page' do
-      let(:wiki) { project.create_wiki start_page: start_page }
-      let(:wiki_page) { FactoryBot.build(:wiki_page, wiki: wiki, title: 'Übersicht') }
+  describe '#start_page' do
+    it 'can be changed' do
+      wiki.start_page = 'Another start page'
+      wiki.save
 
-      subject { wiki.find_page('Übersicht') }
+      expect(Wiki)
+        .to exist(start_page: 'Another start page')
+    end
+  end
 
-      it 'will find the page using the title' do
-        wiki_page.save!
+  describe '#slug' do
+    context 'with an umlaut' do
+      let(:wiki_page) { FactoryBot.create(:wiki_page, wiki: wiki, title: 'Übersicht') }
+
+      it 'normalizes' do
         expect(wiki_page.slug).to eq 'ubersicht'
-        expect(subject).to eq wiki_page
       end
+    end
+  end
+
+  describe '#find_page' do
+    let(:title) { 'Übersicht' }
+    let!(:wiki_page) { FactoryBot.create(:wiki_page, wiki: wiki, title: title) }
+    let(:search_string) { 'Übersicht' }
 
-      context 'with german default_language', with_settings: { default_language: 'de' } do
-        it 'will find the page with the default_language slug title (Regression #38606)' do
-          wiki_page.save!
-          wiki_page.update_column(:slug, 'uebersicht')
+    subject { wiki.find_page(search_string) }
+
+    context 'when using the title' do
+      it 'finds the page' do
+        expect(subject)
+          .to eq wiki_page
+      end
+    end
+
+    context 'when using the title in a different case' do
+      let(:search_string) { 'ÜBERSICHT' }
+
+      it 'finds the page' do
+        expect(subject)
+          .to eq wiki_page
+      end
+    end
+
+    context 'for a date title' do
+      let(:search_string) { '2009\\02\\09' }
+      let(:title) { '2009\\02\\09' }
+
+      it 'finds the page' do
+        expect(subject)
+          .to eq wiki_page
+      end
+    end
+
+    context 'for non latin characters' do
+      let(:search_string) { 'Этика менеджмента' }
+      let(:title) { 'Этика менеджмента' }
+
+      it 'finds the page' do
+        expect(subject)
+          .to eq wiki_page
+      end
+    end
+
+    context 'with german default_language', with_settings: { default_language: 'de' } do
+      before do
+        wiki_page.update_column(:slug, 'uebersicht')
+      end
 
-          expect(wiki_page.reload.slug).to eq 'uebersicht'
-          expect(subject).to eq wiki_page
-        end
+      it 'finds the page with the default_language slug title (Regression #38606)' do
+        expect(subject)
+          .to eq wiki_page
       end
     end
   end

spec_legacy/unit/wiki_spec.rb

@@ -1,66 +0,0 @@
-#-- encoding: UTF-8
-
-#-- copyright
-# OpenProject is an open source project management software.
-# Copyright (C) 2012-2021 the OpenProject GmbH
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License version 3.
-#
-# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
-# Copyright (C) 2006-2013 Jean-Philippe Lang
-# Copyright (C) 2010-2013 the ChiliProject Team
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; either version 2
-# of the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-#
-# See COPYRIGHT and LICENSE files for more details.
-#++
-
-require_relative '../legacy_spec_helper'
-
-describe Wiki, type: :model do
-  fixtures :all
-
-  it 'should create' do
-    wiki = Wiki.new(project: Project.find(2))
-    assert !wiki.save
-    assert_equal 1, wiki.errors.count
-
-    wiki.start_page = 'Start page'
-    assert wiki.save
-  end
-
-  it 'should update' do
-    @wiki = Wiki.find(1)
-    @wiki.start_page = 'Another start page'
-    assert @wiki.save
-    @wiki.reload
-    assert_equal 'Another start page', @wiki.start_page
-  end
-
-  it 'should find page' do
-    wiki = Wiki.find(1)
-    page = WikiPage.find(2)
-
-    assert_equal page, wiki.find_page('Another page')
-    assert_equal page, wiki.find_page('ANOTHER page')
-
-    page = WikiPage.find(10)
-    assert_equal page, wiki.find_page('Этика менеджмента')
-
-    page = FactoryBot.create(:wiki_page, wiki: wiki, title: '2009\\02\\09')
-    assert_equal page, wiki.find_page('2009\\02\\09')
-  end
-end