From 72f65cdfd3523f0bc20659965b7d889fcbdba076 Mon Sep 17 00:00:00 2001 From: Martin Czuchra Date: Wed, 13 Nov 2013 10:49:53 +0100 Subject: [PATCH 1/2] These go to eleven... --- app/assets/javascripts/timelines.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/timelines.js b/app/assets/javascripts/timelines.js index bbac6ae6f9..0949e6ac8d 100644 --- a/app/assets/javascripts/timelines.js +++ b/app/assets/javascripts/timelines.js @@ -3656,7 +3656,7 @@ Timeline = { DAY_WIDTH: 16, MIN_CHART_WIDTH: 200, - RENDER_BUCKETS: 2, + RENDER_BUCKET_SIZE: 32, ORIGINAL_BORDER_WIDTH_CORRECTION: 3, BORDER_WIDTH_CORRECTION: 3, HOVER_THRESHOLD: 3, @@ -4870,19 +4870,19 @@ Timeline = { }); var render_next_bucket = function() { - if (jQuery.each(pre_render_bucket.splice(0, Timeline.RENDER_BUCKETS), function(i, e) { + if (jQuery.each(pre_render_bucket.splice(0, Timeline.RENDER_BUCKET_SIZE), function(i, e) { e.call(); }).length !== 0) { timeline.defer(render_next_bucket); - } else if (jQuery.each(render_bucket.splice(0, Timeline.RENDER_BUCKETS), function(i, e) { + } else if (jQuery.each(render_bucket.splice(0, Timeline.RENDER_BUCKET_SIZE), function(i, e) { e.call(); }).length !== 0) { timeline.defer(render_next_bucket); - } else if (jQuery.each(post_render_bucket.splice(0, Timeline.RENDER_BUCKETS), function(i, e) { + } else if (jQuery.each(post_render_bucket.splice(0, Timeline.RENDER_BUCKET_SIZE), function(i, e) { e.call(); }).length !== 0) { timeline.defer(render_next_bucket); - } else if (jQuery.each(text_render_bucket.splice(0, Timeline.RENDER_BUCKETS), function(i, e) { + } else if (jQuery.each(text_render_bucket.splice(0, Timeline.RENDER_BUCKET_SIZE), function(i, e) { e.call(); }).length !== 0) { timeline.defer(render_next_bucket); From 416e3af02bebd7e6ff60d961d7684513e3fb357e Mon Sep 17 00:00:00 2001 From: Martin Czuchra Date: Wed, 13 Nov 2013 10:59:44 +0100 Subject: [PATCH 2/2] Changelog --- doc/CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md index d2ccb2e07c..7321fe9f35 100644 --- a/doc/CHANGELOG.md +++ b/doc/CHANGELOG.md @@ -31,10 +31,11 @@ See doc/COPYRIGHT.rdoc for more details. * `#2653` Remove relative vertical offset corrections and custom border fixes for IE8. * `#2654` Remove custom font rendering/kerning as well as VML from timelines. +* `#2655` Find a sensible default for Timelines rendering bucket size. ## 3.0.0pre29 -* `#2473` [Timelines] Tooltip in timeline report shows star * instead of hash # in front of ID +* `#2473` [Timelines] Tooltip in timeline report shows star * instead of hash # in front of ID * `#2721` Fix: Fix: Fix: Missing journal entries for customizable_journals * `#2718` Newlines in workpackage descriptions aren't normalized for change tracking