patch user preference schema for backlogs

pull/9619/head
ulferts 3 years ago
parent 57cfa51d19
commit 51368c8a96
No known key found for this signature in database
GPG Key ID: A205708DE1284017
  1. 1
      app/models/user_preferences/schema.rb
  2. 1
      modules/backlogs/lib/open_project/backlogs/engine.rb
  3. 60
      modules/backlogs/lib/open_project/backlogs/patches/user_preferences/schema_patch.rb
  4. 17
      spec/contracts/user_preferences/update_contract_spec.rb

@ -33,6 +33,7 @@ class UserPreferences::Schema
PATH = Rails.root.join('config/schemas/api/user_preferences.schema.json')
# TODO: check if Time zones can be verified within the schema
# TODO: allow extension by plugins
def schema
@schema ||= JSON::parse(File.read(PATH))

@ -126,6 +126,7 @@ module OpenProject::Backlogs
patch_with_namespace :WorkPackages, :SetAttributesService
patch_with_namespace :WorkPackages, :BaseContract
patch_with_namespace :Versions, :RowCell
patch_with_namespace :UserPreferences, :Schema
config.to_prepare do
next if Versions::BaseContract.included_modules.include?(OpenProject::Backlogs::Patches::Versions::BaseContractPatch)

@ -0,0 +1,60 @@
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
module OpenProject::Backlogs
module Patches
module UserPreferences
module SchemaPatch
def self.included(base)
class << base
prepend(ClassMethods)
end
end
module ClassMethods
def schema
ret = super
properties = ret.dig('definitions', 'UserPreferences', 'properties')
properties['backlogs_task_color'] = {
'type' => 'string'
}
properties['backlogs_versions_default_fold_state'] = {
'type' => 'string',
"enum" => %w[open closed]
}
ret
end
end
end
end
end
end

@ -102,23 +102,6 @@ describe UserPreferences::UpdateContract do
it_behaves_like 'contract is invalid', settings: :exclusion
end
context 'without a hide_mail value' do
let(:settings) do
{
auto_hide_popups: true,
comments_sorting: 'desc',
daily_reminders: {
enabled: true,
times: %w[08:00:00+00:00 12:00:00+00:00]
},
time_zone: 'Brasilia',
warn_on_leaving_unsaved: true
}
end
it_behaves_like 'contract is invalid', hide_mail: :blank
end
context 'with a string for hide_mail' do
let(:settings) do
{

Loading…
Cancel
Save