From 56204887274cf8b8432d8834bd9b858965e09e1b Mon Sep 17 00:00:00 2001
From: Eric Davis <edavis@littlestreamsoftware.com>
Date: Sun, 6 Nov 2011 15:34:16 -0800
Subject: [PATCH] [#263] Removed and tweaks the design based on feedback

---
 app/views/context_menus/issues.html.erb |   5 -----
 app/views/issues/_list.rhtml            |   4 ++--
 app/views/issues/_relations.rhtml       |   3 ---
 app/views/issues/show.rhtml             |   9 +++++----
 app/views/projects/index.rhtml          |   6 ++++--
 app/views/versions/index.html.erb       |   5 +++++
 public/images/pencil.png.oxygen         | Bin 613 -> 0 bytes
 public/javascripts/DD_belatedPNG.min.js |  13 -------------
 public/stylesheets/application.css      |   2 +-
 9 files changed, 17 insertions(+), 30 deletions(-)
 delete mode 100644 public/images/pencil.png.oxygen
 delete mode 100755 public/javascripts/DD_belatedPNG.min.js

diff --git a/app/views/context_menus/issues.html.erb b/app/views/context_menus/issues.html.erb
index 1abfb2c39f..eebfbe8ec0 100644
--- a/app/views/context_menus/issues.html.erb
+++ b/app/views/context_menus/issues.html.erb
@@ -1,7 +1,3 @@
-<%# Added: classes to the li %>
-<%# Added: classes to the a %>
-<%# Added: div for submenu icons %>
-<%# Removed: icon-* on links %>
 <ul class="menu">
   <%= call_hook(:view_issues_context_menu_start, {:issues => @issues, :can => @can, :back => @back }) %>
 
@@ -126,7 +122,6 @@
 
   <li class="move"><%= context_menu_link l(:button_move), {:controller => 'issues', :action => 'move', :ids => @issues.collect(&:id)},
 	                        :class => 'context_item', :disabled => !@can[:move]  %></li>
-  <%# All users can copy because the copy acton will check their permissions on the target project %>
   <li class="copy"><%= context_menu_link l(:button_copy), {:controller => 'issues', :action => 'bulk_copy', :project_id => @project, :ids => @issues.collect(&:id)},
                                 :class => 'context_item' %></li>
   <li class="delete"><%= context_menu_link l(:button_delete), {:controller => 'issues', :action => 'destroy', :ids => @issues.collect(&:id)},
diff --git a/app/views/issues/_list.rhtml b/app/views/issues/_list.rhtml
index a392044b07..5f3c6138a8 100644
--- a/app/views/issues/_list.rhtml
+++ b/app/views/issues/_list.rhtml
@@ -2,7 +2,7 @@
 <%= hidden_field_tag 'back_url', url_for(params) %>
 <div class="autoscroll">
 <table class="list issues">
-    <thead><tr id="issue-header">
+    <thead><tr>
         <th class="checkbox hide-when-print"><%= link_to image_tag('toggle_check.png'), {}, :onclick => 'toggleIssuesSelection(Element.up(this, "form")); return false;',
                                                            :title => "#{l(:button_check_all)}/#{l(:button_uncheck_all)}" %>
         </th>
@@ -12,7 +12,7 @@
         <% end %>
 	</tr></thead>
 	<% previous_group = false %>
-	<tbody id="issue-list-body">
+	<tbody>
 	<% issue_list(issues) do |issue, level| -%>
   <% if @query.grouped? && (group = @query.group_by_column.value(issue)) != previous_group %>
     <% reset_cycle %>
diff --git a/app/views/issues/_relations.rhtml b/app/views/issues/_relations.rhtml
index 60ba577e32..362133dedf 100644
--- a/app/views/issues/_relations.rhtml
+++ b/app/views/issues/_relations.rhtml
@@ -1,6 +1,3 @@
-<div class="contextual">
-</div>
-
 <p>
   <strong><%=l(:label_related_issues)%></strong>
   <% if authorize_for('issue_relations', 'new') %>
diff --git a/app/views/issues/show.rhtml b/app/views/issues/show.rhtml
index d0c3d32144..16f6b68ab2 100644
--- a/app/views/issues/show.rhtml
+++ b/app/views/issues/show.rhtml
@@ -93,10 +93,11 @@
 <% if !@issue.leaf? || User.current.allowed_to?(:manage_subtasks, @project) %>
 <hr />
 <div id="issue_tree">
-<div class="contextual">
-  <%= link_to(l(:button_add), {:controller => 'issues', :action => 'new', :project_id => @project, :issue => {:parent_issue_id => @issue}}) if User.current.allowed_to?(:manage_subtasks, @project) %>
-</div>
-<p><strong><%=l(:label_subtask_plural)%></strong></p>
+<p>
+  <strong><%=l(:label_subtask_plural)%></strong>
+  (<%= link_to(l(:button_add), {:controller => 'issues', :action => 'new', :project_id => @project, :issue => {:parent_issue_id => @issue}}) if User.current.allowed_to?(:manage_subtasks, @project) %>)
+</p>
+
 <%= render_descendants_tree(@issue) unless @issue.leaf? %>
 </div>
 <% end %>
diff --git a/app/views/projects/index.rhtml b/app/views/projects/index.rhtml
index 8e5e1dd6ef..46ca74291c 100644
--- a/app/views/projects/index.rhtml
+++ b/app/views/projects/index.rhtml
@@ -2,7 +2,7 @@
     <%= auto_discovery_link_tag(:atom, {:action => 'index', :format => 'atom', :key => User.current.rss_key}) %>
 <% end %>
 
-<div id="project-links"class="contextual">
+<div id="project-links" class="contextual">
     <%= link_to(l(:label_project_new), {:controller => 'projects', :action => 'new'}, :class => 'icon icon-add') + ' |' if User.current.allowed_to?(:add_project, nil, :global => true) %>
     <%= link_to(l(:label_issue_view_all), { :controller => 'issues' }) + ' |' if User.current.allowed_to?(:view_issues, nil, :global => true) %>
     <%= link_to(l(:label_overall_spent_time), { :controller => 'time_entries' }) + ' |' if User.current.allowed_to?(:view_time_entries, nil, :global => true) %>
@@ -11,7 +11,9 @@
 
 <h2><%=l(:label_project_plural)%></h2>
 
-<%= textilizable Setting.welcome_text %>
+<div class="wiki">
+  <%= textilizable Setting.welcome_text %>
+</div>
 
 <%= render_project_hierarchy(@projects)%>
 
diff --git a/app/views/versions/index.html.erb b/app/views/versions/index.html.erb
index 8fdde7c450..09c44ce3f6 100644
--- a/app/views/versions/index.html.erb
+++ b/app/views/versions/index.html.erb
@@ -43,6 +43,11 @@
 <p><%= submit_tag l(:button_apply), :class => 'button-small', :name => nil %></p>
 <% end %>
 
+<h3><%= l(:label_version_plural) %></h3>
+<% @versions.each do |version| %>
+<%= link_to format_version_name(version), "##{version.name}" %><br />
+<% end %>
+
 <% end %>
 
 <% html_title(l(:label_roadmap)) %>
diff --git a/public/images/pencil.png.oxygen b/public/images/pencil.png.oxygen
deleted file mode 100644
index 42f442c2ff12dccf8f269b91ef648a5e1bec8d49..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 613
zcmV-r0-F7aP)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV00004b3#c}2nYxW
zd<bNS00009a7bBm0005I0005I0XppC;s5{u8FWQhbW?9;ba!ELWdL_~cP?peYja~^
zaAhuUa%Y?FJQ@H10pdwSK~y-6WBC97KLaT^&VxadiHYH{uCDGnM@L5yk~A-#6sz`p
zm&QFqRfY=;3=E%`n3%RRF%Su6mosw6%Bvhb_MuFMQ`Ab|*FpR`E6aa9#{d8S6Qh~Q
z$C_=`)n{UQPdQsuogD4{GTlk~a`4~*Hx^=Sx6)?l{q$4NAb%o<vYJBgb4}?t!YqIE
zd!icmpCah*S!E0bFLy{jG1OE3Wo4%J;njYt7q7PqrNZP1X%7B!Na>A@nbK!H9n~LC
zcN*M%w@0cKSq(nTR)0=vz4x?}eWk9h`tSB8-ODczxot;RhfA~C&*Q4EBE2N<tE#I0
zKe^24-0OX&CwBHSuo5(2RvClXmxHqR3L=GWsH&>|U)im3^2u(qdxvHV2w<}eg%jz*
z!1sQ)=;?`t+*egqRsXl;DV=+=UGwFEY2u2wyowTyvO1~FtB#(MpStCnsH5TU8xhV7
z%D3))@^H+0aUW+KBbzp7TIZwdr<VPX2{L|nbCuZVU6Z(c2t_kIDGLbj$+9qflzIQ`
zD1)BjSLXTKnX6oLziuIz%3vnxYAdhOP!|90>!g@QN(O`H1x7|j6$S=|uM7+f91IK$
ztPBhcj0_A6{}>n;{xUEy{D$IR$n^jJ|Nj91_aNs{9OG!000000NkvXXu0mjfu{s+5

diff --git a/public/javascripts/DD_belatedPNG.min.js b/public/javascripts/DD_belatedPNG.min.js
deleted file mode 100755
index f78bbee99a..0000000000
--- a/public/javascripts/DD_belatedPNG.min.js
+++ /dev/null
@@ -1,13 +0,0 @@
-/**
-* DD_belatedPNG: Adds IE6 support: PNG images for CSS background-image and HTML <IMG/>.
-* Author: Drew Diller
-* Email: drew.diller@gmail.com
-* URL: http://www.dillerdesign.com/experiment/DD_belatedPNG/
-* Version: 0.0.7a
-* Licensed under the MIT License: http://dillerdesign.com/experiment/DD_belatedPNG/#license
-*
-* Example usage:
-* DD_belatedPNG.fix('.png_bg'); // argument is a CSS selector
-* DD_belatedPNG.fixPng( someNode ); // argument is an HTMLDomElement
-**/
-var DD_belatedPNG={ns:"DD_belatedPNG",imgSize:{},createVmlNameSpace:function(){if(document.namespaces&&!document.namespaces[this.ns]){document.namespaces.add(this.ns,"urn:schemas-microsoft-com:vml")}if(window.attachEvent){window.attachEvent("onbeforeunload",function(){DD_belatedPNG=null})}},createVmlStyleSheet:function(){var style=document.createElement("style");document.documentElement.firstChild.insertBefore(style,document.documentElement.firstChild.firstChild);var styleSheet=style.styleSheet;styleSheet.addRule(this.ns+"\\:*","{behavior:url(#default#VML)}");styleSheet.addRule(this.ns+"\\:shape","position:absolute;");styleSheet.addRule("img."+this.ns+"_sizeFinder","behavior:none; border:none; position:absolute; z-index:-1; top:-10000px; visibility:hidden;");this.styleSheet=styleSheet},readPropertyChange:function(){var el=event.srcElement;if(event.propertyName.search("background")!=-1||event.propertyName.search("border")!=-1){DD_belatedPNG.applyVML(el)}if(event.propertyName=="style.display"){var display=(el.currentStyle.display=="none")?"none":"block";for(var v in el.vml){el.vml[v].shape.style.display=display}}if(event.propertyName.search("filter")!=-1){DD_belatedPNG.vmlOpacity(el)}},vmlOpacity:function(el){if(el.currentStyle.filter.search("lpha")!=-1){var trans=el.currentStyle.filter;trans=parseInt(trans.substring(trans.lastIndexOf("=")+1,trans.lastIndexOf(")")),10)/100;el.vml.color.shape.style.filter=el.currentStyle.filter;el.vml.image.fill.opacity=trans}},handlePseudoHover:function(el){setTimeout(function(){DD_belatedPNG.applyVML(el)},1)},fix:function(selector){var selectors=selector.split(",");for(var i=0;i<selectors.length;i++){this.styleSheet.addRule(selectors[i],"behavior:expression(DD_belatedPNG.fixPng(this))")}},applyVML:function(el){el.runtimeStyle.cssText="";this.vmlFill(el);this.vmlOffsets(el);this.vmlOpacity(el);if(el.isImg){this.copyImageBorders(el)}},attachHandlers:function(el){var self=this;var handlers={resize:"vmlOffsets",move:"vmlOffsets"};if(el.nodeName=="A"){var moreForAs={mouseleave:"handlePseudoHover",mouseenter:"handlePseudoHover",focus:"handlePseudoHover",blur:"handlePseudoHover"};for(var a in moreForAs){handlers[a]=moreForAs[a]}}for(var h in handlers){el.attachEvent("on"+h,function(){self[handlers[h]](el)})}el.attachEvent("onpropertychange",this.readPropertyChange)},giveLayout:function(el){el.style.zoom=1;if(el.currentStyle.position=="static"){el.style.position="relative"}},copyImageBorders:function(el){var styles={borderStyle:true,borderWidth:true,borderColor:true};for(var s in styles){el.vml.color.shape.style[s]=el.currentStyle[s]}},vmlFill:function(el){if(!el.currentStyle){return}else{var elStyle=el.currentStyle}for(var v in el.vml){el.vml[v].shape.style.zIndex=elStyle.zIndex}el.runtimeStyle.backgroundColor="";el.runtimeStyle.backgroundImage="";var noColor=(elStyle.backgroundColor=="transparent");var noImg=true;if(elStyle.backgroundImage!="none"||el.isImg){if(!el.isImg){el.vmlBg=elStyle.backgroundImage;el.vmlBg=el.vmlBg.substr(5,el.vmlBg.lastIndexOf('")')-5)}else{el.vmlBg=el.src}var lib=this;if(!lib.imgSize[el.vmlBg]){var img=document.createElement("img");lib.imgSize[el.vmlBg]=img;img.className=lib.ns+"_sizeFinder";img.runtimeStyle.cssText="behavior:none; position:absolute; left:-10000px; top:-10000px; border:none;";img.attachEvent("onload",function(){this.width=this.offsetWidth;this.height=this.offsetHeight;lib.vmlOffsets(el)});img.src=el.vmlBg;img.removeAttribute("width");img.removeAttribute("height");document.body.insertBefore(img,document.body.firstChild)}el.vml.image.fill.src=el.vmlBg;noImg=false}el.vml.image.fill.on=!noImg;el.vml.image.fill.color="none";el.vml.color.shape.style.backgroundColor=elStyle.backgroundColor;el.runtimeStyle.backgroundImage="none";el.runtimeStyle.backgroundColor="transparent"},vmlOffsets:function(el){var thisStyle=el.currentStyle;var size={W:el.clientWidth+1,H:el.clientHeight+1,w:this.imgSize[el.vmlBg].width,h:this.imgSize[el.vmlBg].height,L:el.offsetLeft,T:el.offsetTop,bLW:el.clientLeft,bTW:el.clientTop};var fudge=(size.L+size.bLW==1)?1:0;var makeVisible=function(vml,l,t,w,h,o){vml.coordsize=w+","+h;vml.coordorigin=o+","+o;vml.path="m0,0l"+w+",0l"+w+","+h+"l0,"+h+" xe";vml.style.width=w+"px";vml.style.height=h+"px";vml.style.left=l+"px";vml.style.top=t+"px"};makeVisible(el.vml.color.shape,(size.L+(el.isImg?0:size.bLW)),(size.T+(el.isImg?0:size.bTW)),(size.W-1),(size.H-1),0);makeVisible(el.vml.image.shape,(size.L+size.bLW),(size.T+size.bTW),(size.W),(size.H),1);var bg={X:0,Y:0};var figurePercentage=function(axis,position){var fraction=true;switch(position){case"left":case"top":bg[axis]=0;break;case"center":bg[axis]=0.5;break;case"right":case"bottom":bg[axis]=1;break;default:if(position.search("%")!=-1){bg[axis]=parseInt(position)*0.01}else{fraction=false}}var horz=(axis=="X");bg[axis]=Math.ceil(fraction?((size[horz?"W":"H"]*bg[axis])-(size[horz?"w":"h"]*bg[axis])):parseInt(position));if(bg[axis]==0){bg[axis]++}};for(var b in bg){figurePercentage(b,thisStyle["backgroundPosition"+b])}el.vml.image.fill.position=(bg.X/size.W)+","+(bg.Y/size.H);var bgR=thisStyle.backgroundRepeat;var dC={T:1,R:size.W+fudge,B:size.H,L:1+fudge};var altC={X:{b1:"L",b2:"R",d:"W"},Y:{b1:"T",b2:"B",d:"H"}};if(bgR!="repeat"){var c={T:(bg.Y),R:(bg.X+size.w),B:(bg.Y+size.h),L:(bg.X)};if(bgR.search("repeat-")!=-1){var v=bgR.split("repeat-")[1].toUpperCase();c[altC[v].b1]=1;c[altC[v].b2]=size[altC[v].d]}if(c.B>size.H){c.B=size.H}el.vml.image.shape.style.clip="rect("+c.T+"px "+(c.R+fudge)+"px "+c.B+"px "+(c.L+fudge)+"px)"}else{el.vml.image.shape.style.clip="rect("+dC.T+"px "+dC.R+"px "+dC.B+"px "+dC.L+"px)"}},fixPng:function(el){el.style.behavior="none";if(el.nodeName=="BODY"||el.nodeName=="TD"||el.nodeName=="TR"){return}el.isImg=false;if(el.nodeName=="IMG"){if(el.src.toLowerCase().search(/\.png$/)!=-1){el.isImg=true;el.style.visibility="hidden"}else{return}}else{if(el.currentStyle.backgroundImage.toLowerCase().search(".png")==-1){return}}var lib=DD_belatedPNG;el.vml={color:{},image:{}};var els={shape:{},fill:{}};for(var r in el.vml){for(var e in els){var nodeStr=lib.ns+":"+e;el.vml[r][e]=document.createElement(nodeStr)}el.vml[r].shape.stroked=false;el.vml[r].shape.appendChild(el.vml[r].fill);el.parentNode.insertBefore(el.vml[r].shape,el)}el.vml.image.shape.fillcolor="none";el.vml.image.fill.type="tile";el.vml.color.fill.on=false;lib.attachHandlers(el);lib.giveLayout(el);lib.giveLayout(el.offsetParent);lib.applyVML(el)}};try{document.execCommand("BackgroundImageCache",false,true)}catch(r){}DD_belatedPNG.createVmlNameSpace();DD_belatedPNG.createVmlStyleSheet();
\ No newline at end of file
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index a78173fa7b..a674a82e99 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -19,7 +19,7 @@ h4, .wiki h3 {font-size: 13px;padding: 2px 10px 1px 0px;margin-bottom: 5px; bord
   padding: 0px 0px 0px 0px;
   white-space:nowrap;
 }
-#top-menu a {color: #444;; margin-right: 0px; font-weight: bold;}
+#top-menu a {color: #444; margin-right: 0px; font-weight: bold;}
 #top-menu #loggedas { float: right; margin-right: 0.5em; color: #fff; }
 
 #account {float:none;}