TheDude
/
openproject
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add requests spec for deleting non working days

Browse Source
45001-component-to-show-the-list-of-non-working-days-of-year
Dombi Attila 2 years ago
parent bdd0c91ca0
commit 6157248974
1 changed files with 151 additions and 99 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 250
      spec/features/admin/working_days_spec.rb

250
spec/features/admin/working_days_spec.rb
Unescape View File

@ -28,11 +28,19 @@
require 'spec_helper'
describe 'Working Days', type: :feature, js: true do
describe 'Working Days', js: true do
create_shared_association_defaults_for_work_package_factory
shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend }
shared_let(:admin) { create :admin }
shared_let(:admin) { create(:admin) }
shared_let(:non_working_days) do
[
create(:non_working_day),
create(:non_working_day),
create(:non_working_day)
]
end
let_schedule(<<~CHART)
days | MTWTFSSmtwtfss |
earliest_work_package | XXXXX |
@ -40,7 +48,7 @@ describe 'Working Days', type: :feature, js: true do
follower | XXX | follows earliest_work_package, follows second_work_package
CHART
let(:dialog) { ::Components::ConfirmationDialog.new }
let(:dialog) { Components::ConfirmationDialog.new }
current_user { admin }
@ -48,128 +56,172 @@ describe 'Working Days', type: :feature, js: true do
visit admin_settings_working_days_path
end
# Using this way instead of Setting.working_days as that is cached.
def working_days_setting
Setting.find_by(name: :working_days).value
end
describe 'week days' do
# Using this way instead of Setting.working_days as that is cached.
def working_days_setting
Setting.find_by(name: :working_days).value
end
it 'contains all defined days from the settings' do
WeekDay.all.each do |day|
expect(page).to have_selector('label', text: day.name)
if day.working
expect(page).to have_checked_field day.name
it 'contains all defined days from the settings' do
WeekDay.all.each do |day|
expect(page).to have_selector('label', text: day.name)
if day.working
expect(page).to have_checked_field day.name
end
end
end
end
it 'rejects the updates when cancelling the dialog' do
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
it 'rejects the updates when cancelling the dialog' do
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
uncheck 'Monday'
uncheck 'Friday'
uncheck 'Monday'
uncheck 'Friday'
click_on 'Save'
perform_enqueued_jobs do
dialog.cancel
end
click_on 'Save'
expect(page).not_to have_selector('.flash.notice')
perform_enqueued_jobs do
dialog.cancel
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
expect_schedule(WorkPackage.all, <<~CHART)
days | MTWTFSSmtwtfss |
earliest_work_package | XXXXX |
second_work_package | XX..XX |
follower | XXX |
CHART
end
expect(page).to have_no_selector('.flash.notice')
it 'updates the values and saves the settings' do
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
uncheck 'Monday'
uncheck 'Friday'
expect_schedule(WorkPackage.all, <<~CHART)
days | MTWTFSSmtwtfss |
earliest_work_package | XXXXX |
second_work_package | XX..XX |
follower | XXX |
CHART
end
click_on 'Save'
it 'updates the values and saves the settings' do
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
perform_enqueued_jobs do
dialog.confirm
end
uncheck 'Monday'
uncheck 'Friday'
expect(page).to have_selector('.flash.notice', text: 'Successful update.')
expect(page).to have_unchecked_field 'Monday'
expect(page).to have_unchecked_field 'Friday'
expect(page).to have_unchecked_field 'Saturday'
expect(page).to have_unchecked_field 'Sunday'
expect(page).to have_checked_field 'Tuesday'
expect(page).to have_checked_field 'Wednesday'
expect(page).to have_checked_field 'Thursday'
expect(working_days_setting).to eq([2, 3, 4])
expect_schedule(WorkPackage.all, <<~CHART)
days | MTWTFSSmtwtfssmtwt |
earliest_work_package | XXX....XX |
second_work_package | X....XXX |
follower | XXX |
CHART
# The updated work packages will have a journal entry informing about the change
wp_page = Pages::FullWorkPackage.new(earliest_work_package)
wp_page.visit!
wp_page.expect_comment(text: "Working days changed (Monday is now non-working, Friday is now non-working).")
end
click_on 'Save'
it 'shows error when non working days are all unset' do
uncheck 'Monday'
uncheck 'Tuesday'
uncheck 'Wednesday'
uncheck 'Thursday'
uncheck 'Friday'
perform_enqueued_jobs do
dialog.confirm
click_on 'Save'
perform_enqueued_jobs do
dialog.confirm
end
expect(page).to have_selector('.flash.error', text: 'At least one day of the week must be defined as a working day.')
# Restore the checkboxes to their valid state
expect(page).to have_checked_field 'Monday'
expect(page).to have_checked_field 'Tuesday'
expect(page).to have_checked_field 'Wednesday'
expect(page).to have_checked_field 'Thursday'
expect(page).to have_checked_field 'Friday'
expect(page).to have_unchecked_field 'Saturday'
expect(page).to have_unchecked_field 'Sunday'
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
expect_schedule(WorkPackage.all, <<~CHART)
days | MTWTFSSmtwtfss |
earliest_work_package | XXXXX |
second_work_package | XX..XX |
follower | XXX |
CHART
end
expect(page).to have_selector('.flash.notice', text: 'Successful update.')
expect(page).to have_unchecked_field 'Monday'
expect(page).to have_unchecked_field 'Friday'
expect(page).to have_unchecked_field 'Saturday'
expect(page).to have_unchecked_field 'Sunday'
expect(page).to have_checked_field 'Tuesday'
expect(page).to have_checked_field 'Wednesday'
expect(page).to have_checked_field 'Thursday'
expect(working_days_setting).to eq([2, 3, 4])
expect_schedule(WorkPackage.all, <<~CHART)
days | MTWTFSSmtwtfssmtwt |
earliest_work_package | XXX....XX |
second_work_package | X....XXX |
follower | XXX |
CHART
# The updated work packages will have a journal entry informing about the change
wp_page = Pages::FullWorkPackage.new(earliest_work_package)
wp_page.visit!
wp_page.expect_comment(text: "Working days changed (Monday is now non-working, Friday is now non-working).")
it 'shows an error when a previous change to the working days configuration isn\'t processed yet' do
# Have a job already scheduled
# Attempting to set the job via simply using the UI would require to change the test setup of how
# delayed jobs are handled.
ActiveJob::QueueAdapters::DelayedJobAdapter
.new
.enqueue(WorkPackages::ApplyWorkingDaysChangeJob.new(user_id: 5, previous_working_days: []))
uncheck 'Tuesday'
click_on 'Save'
# Not executing the background jobs
dialog.confirm
expect(page).to have_selector('.flash.error',
text: 'The previous changes to the working days configuration have not been applied yet.')
end
end
it 'shows error when non working days are all unset' do
uncheck 'Monday'
uncheck 'Tuesday'
uncheck 'Wednesday'
uncheck 'Thursday'
uncheck 'Friday'
describe 'non-working days' do
it 'deletes a non-working day' do
non_working_days.each do |nwd|
expect(page).to have_selector('tr', text: nwd.date.strftime("%B %-d, %Y"))
end
delete_button = page.first('.op-non-working-days-list--delete-icon .icon-delete', visible: :all)
delete_button.hover
delete_button.click
click_on 'Save'
click_on 'Save'
perform_enqueued_jobs do
dialog.confirm
end
expect(page).to have_selector('.flash.error', text: 'At least one day of the week must be defined as a working day.')
# Restore the checkboxes to their valid state
expect(page).to have_checked_field 'Monday'
expect(page).to have_checked_field 'Tuesday'
expect(page).to have_checked_field 'Wednesday'
expect(page).to have_checked_field 'Thursday'
expect(page).to have_checked_field 'Friday'
expect(page).to have_unchecked_field 'Saturday'
expect(page).to have_unchecked_field 'Sunday'
expect(working_days_setting).to eq([1, 2, 3, 4, 5])
expect_schedule(WorkPackage.all, <<~CHART)
days | MTWTFSSmtwtfss |
earliest_work_package | XXXXX |
second_work_package | XX..XX |
follower | XXX |
CHART
end
# Remove the first date
expect(page).not_to have_selector('tr', text: non_working_days.first.date.strftime("%B %-d, %Y"))
expect(page).to have_selector('tr', text: non_working_days.last.date.strftime("%B %-d, %Y"))
# Show an error when the changes cannot be saved and preserves the modifications upon submit
errors = ActiveModel::Errors.new(NonWorkingDay.new)
errors.add(:id, :invalid)
it 'shows an error when a previous change to the working days configuration isn\'t processed yet' do
# Have a job already scheduled
# Attempting to set the job via simply using the UI would require to change the test setup of how
# delayed jobs are handled.
ActiveJob::QueueAdapters::DelayedJobAdapter
.new
.enqueue(WorkPackages::ApplyWorkingDaysChangeJob.new(user_id: 5, previous_working_days: []))
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(NonWorkingDay)
.to receive(:errors)
.and_return(errors)
# rubocop:enable RSpec/AnyInstance
uncheck 'Tuesday'
click_on 'Save'
delete_button = page.first('.op-non-working-days-list--delete-icon .icon-delete', visible: :all)
delete_button.hover
delete_button.click
# Not executing the background jobs
dialog.confirm
click_on 'Save'
expect(page).to have_selector('.flash.error',
text: 'The previous changes to the working days configuration have not been applied yet.')
dialog.confirm
# Keep the second date hidden
expect(page).not_to have_selector('tr', text: non_working_days.second.date.strftime("%B %-d, %Y"))
expect(page).to have_selector('tr', text: non_working_days.last.date.strftime("%B %-d, %Y"))
end
end
end

Write Preview
Loading…
Cancel
Save