Add service for WP details management

10 years ago · 61a2a4053a
parent 1a8ff4b721
commit 61a2a4053a
3 changed files with 197 additions and 0 deletions
--- a/app/assets/javascripts/angular/work_packages/services/index.js
+++ b/app/assets/javascripts/angular/work_packages/services/index.js
@ -33,3 +33,25 @@ angular.module('openproject.workPackages.services')
    'WorkPackagesTableHelper',
    require('./work-packages-table-service')
  ])
+  .constant('WORK_PACKAGE_ATTRIBUTES', [
+    {
+      groupName: 'details',
+      attributes: ['status', 'percentageDone', 'date', 'priority', 'versionName', 'category']
+    },
+    {
+      groupName: 'people',
+      attributes: ['assignee', 'responsible']
+    },
+    {
+      groupName: 'estimatesAndTime',
+      attributes: ['estimatedTime', 'spentTime']
+    },
+    {
+      groupName: 'other',
+      attributes: []
+    }
+  ])
+  .service('WorkPackagesOverviewService', [
+      'WORK_PACKAGE_ATTRIBUTES',
+      require('./work-packages-overview-service')
+  ]);
--- a/app/assets/javascripts/angular/work_packages/services/work-packages-overview-service.js
+++ b/app/assets/javascripts/angular/work_packages/services/work-packages-overview-service.js
@ -0,0 +1,79 @@
+//-- copyright
+// OpenProject is a project management system.
+// Copyright (C) 2012-2014 the OpenProject Foundation (OPF)
+//
+// This program is free software; you can redistribute it and/or
+// modify it under the terms of the GNU General Public License version 3.
+//
+// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+// Copyright (C) 2006-2013 Jean-Philippe Lang
+// Copyright (C) 2010-2013 the ChiliProject Team
+//
+// This program is free software; you can redistribute it and/or
+// modify it under the terms of the GNU General Public License
+// as published by the Free Software Foundation; either version 2
+// of the License, or (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+//
+// See doc/COPYRIGHT.rdoc for more details.
+//++
+
+module.exports = function(WORK_PACKAGE_ATTRIBUTES) {
+
+  var workPackageDetailsAttributes = angular.copy(WORK_PACKAGE_ATTRIBUTES);
+
+  var WorkPackagesOverviewService = {
+    getGroupedWorkPackageOverviewAttributes: function() {
+      return angular.copy(workPackageDetailsAttributes);
+    },
+    getGroupAttributesForGroupedAttributes: function(groupName, groupedAttributes) {
+      for (var x=0; x < groupedAttributes.length; x++) {
+        if (groupedAttributes[x].groupName === groupName) {
+          return groupedAttributes[x].attributes;
+        }
+      }
+
+      return null;
+    },
+    getGroupAttributes: function(groupName) {
+      return this.getGroupAttributesForGroupedAttributes(groupName, workPackageDetailsAttributes);
+    },
+    addAttributesToGroup: function(groupName, attributes) {
+      var groupAttributes = this.getGroupAttributes(groupName);
+
+      if (groupAttributes) {
+        angular.forEach(attributes, function(attribute) {
+          this.push(attribute);
+        }, groupAttributes);
+      }
+    },
+    addAttributeToGroup: function(groupName, attribute, position) {
+      var attributes = this.getGroupAttributes(groupName);
+
+      if (attributes) {
+        attributes.splice(position, 0, attribute);
+      }
+    },
+    removeAttributeFromGroup: function(groupName, attribute) {
+      var attributes = this.getGroupAttributes(groupName);
+
+      if (attributes) {
+        var index = attributes.indexOf(attribute);
+
+        if (index >= 0) {
+          attributes.splice(index, 1);
+        }
+      }
+    }
+  };
+
+  return WorkPackagesOverviewService;
+};
--- a/karma/tests/work_packages/services/work-packages-overview-service-test.js
+++ b/karma/tests/work_packages/services/work-packages-overview-service-test.js
@ -0,0 +1,96 @@
+//-- copyright
+// OpenProject is a project management system.
+// Copyright (C) 2012-2014 the OpenProject Foundation (OPF)
+//
+// This program is free software; you can redistribute it and/or
+// modify it under the terms of the GNU General Public License version 3.
+//
+// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+// Copyright (C) 2006-2013 Jean-Philippe Lang
+// Copyright (C) 2010-2013 the ChiliProject Team
+//
+// This program is free software; you can redistribute it and/or
+// modify it under the terms of the GNU General Public License
+// as published by the Free Software Foundation; either version 2
+// of the License, or (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+//
+// See doc/COPYRIGHT.rdoc for more details.
+//++
+
+/*jshint expr: true*/
+
+describe('WorkPackagesOverviewService', function() {
+
+  var Service;
+
+  beforeEach(module('openproject.services'));
+
+  beforeEach(inject(function(_WorkPackagesOverviewService_){
+    Service = _WorkPackagesOverviewService_;
+  }));
+
+  describe('getGroupAttributes', function() {
+    var groupName = 'details';
+    var attributes = ['status', 'percentageDone', 'date', 'priority', 'versionName', 'category'];
+
+    it('has details', function() {
+      var group = Service.getGroupAttributes(groupName);
+
+      expect(group).not.to.be.null;
+      expect(group).to.have.length(attributes.length);
+      expect(group).to.include.members(attributes);
+    });
+  });
+
+  describe('addAttributesToGroup', function() {
+    var groupName = 'other';
+    var attributes = ['me', 'myself', 'I'];
+
+    it('adds attributes to group', function() {
+      Service.addAttributesToGroup(groupName, attributes);
+      var group = Service.getGroupAttributes(groupName);
+
+      expect(group).not.to.be.null;
+      expect(group).to.include.members(attributes);
+    });
+  });
+
+  describe('addAttributeToGroup', function() {
+    var groupName = 'people';
+    var attribute = 'me';
+    var position = 1;
+
+    it('adds attribute to specific position in group', function() {
+      Service.addAttributeToGroup(groupName, attribute, position);
+      var group = Service.getGroupAttributes(groupName);
+
+      expect(group).not.to.be.null;
+      expect(group).to.have.length(3);
+      expect(group).to.include.members(['assignee', 'responsible', attribute]);
+      expect(group[1]).to.equal(attribute);
+    });
+  });
+
+  describe('removeAttributeFromGroup', function() {
+    var groupName = 'estimateAndTime';
+    var attribute = 'spentTime';
+
+    it('removes attribute from group', function() {
+      Service.removeAttributeFromGroup(groupName, attribute);
+      var group = Service.getGroupAttributes(groupName);
+
+      expect(group).not.to.be.null;
+      expect(group).to.have.length(1);
+      expect(group).to.include.members(['estimatedTime']);
+    });
+  });
+});