Fix comment accessibility

1. Make the title a label (we won't need a title for seeing users
anyway, the full text is there).

2. Remove invalid `|| undefined` in the ng-disabled check
pull/4605/head
Oliver Günther 8 years ago
parent 96ac99b1f0
commit 61b74b0b27
  1. 2
      frontend/app/components/work-packages/work-package-comment/work-package-comment.directive.html
  2. 2
      frontend/app/templates/components/accessible_by_keyboard.html

@ -25,7 +25,7 @@
class="inplace-editing--trigger-container"
span-class="inplace-editing--container"
link-class="inplace-editing--trigger-link"
link-title="{{ ::vm.text.editTitle }}"
aria-label="{{ ::vm.text.editTitle }}"
execute="vm.activate()">
<span class="inplace-edit--read-value"
ng-class="{'-default': fieldController.isEmpty()}">

@ -1,7 +1,7 @@
<a data-ng-click='isDisabled || execute()'
role="link"
class='{{ linkClass }}'
ng-disabled="isDisabled || undefined"
ng-disabled="isDisabled"
title='{{ linkTitle }}'
aria-label="{{ ariaLabel }}"
data-click-on-keypress="[13, 32]">

Loading…
Cancel
Save