From af47cbb5033cc3c83d2a89c6e0666c23139f877d Mon Sep 17 00:00:00 2001 From: Mihail Maxacov <0xf013@gmail.com> Date: Fri, 10 Apr 2015 12:46:05 +0300 Subject: [PATCH] fix focus traversal through all editables --- .../inplace-editor-display-pane-directive.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/frontend/app/work_packages/directives/inplace_editor/inplace-editor-display-pane-directive.js b/frontend/app/work_packages/directives/inplace_editor/inplace-editor-display-pane-directive.js index 4a5e9c0d8f..1896d44150 100644 --- a/frontend/app/work_packages/directives/inplace_editor/inplace-editor-display-pane-directive.js +++ b/frontend/app/work_packages/directives/inplace_editor/inplace-editor-display-pane-directive.js @@ -92,10 +92,13 @@ module.exports = function( scope.displayPaneController.placeholder = I18n.t('js.label_click_to_enter_description'); } - scope.$watch('fieldController.isEditing', function(isEditing) { + scope.$watch('fieldController.isEditing', function(isEditing, oldIsEditing) { if (!isEditing) { $timeout(function() { - element.find('.inplace-editing--trigger-link').focus(); + if (oldIsEditing) { + // check old value to not trigger focus on the first time + element.find('.inplace-editing--trigger-link').focus(); + } element.find('.inplace-edit--read-value a').off('click').on('click', function(e) { e.stopPropagation(); });