TheDude
/
openproject
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

replace legacy spec

Browse Source
pull/10931/head
ulferts 2 years ago
parent 0cc76a0455
commit 68859915bd
No known key found for this signature in database
GPG Key ID: A205708DE1284017
3 changed files with 114 additions and 91 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 76
      spec/models/comment_spec.rb
  2. 43
      spec/models/news_spec.rb
  3. 86
      spec_legacy/unit/comment_spec.rb

76
spec/models/comment_spec.rb
Unescape View File

@ -0,0 +1,76 @@
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2010-2022 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
require 'spec_helper'
describe Comment, type: :model do
shared_let(:user) { create(:user) }
shared_let(:news) { create(:news) }
let(:comment) { described_class.new(author: user, comments: 'some important words', commented: news) }
describe '#create' do
it 'creates the comment' do
expect(described_class.create(commented: news, author: user, comments: 'some important words'))
.to be_truthy
end
end
describe '#texts' do
it 'reads the comments' do
expect(described_class.new(comments: 'some important words').text)
.to eql 'some important words'
end
end
describe '#valid?' do
it 'is valid' do
expect(comment)
.to be_valid
end
it 'is invalid on an empty comments' do
comment.comments = ''
expect(comment)
.not_to be_valid
end
it 'is invalid without comments' do
comment.comments = nil
expect(comment)
.not_to be_valid
end
it 'is invalid without author' do
comment.author = nil
expect(comment)
.not_to be_valid
end
end
end

43
spec/models/news_spec.rb
Unescape View File

@ -50,27 +50,27 @@ describe News, type: :model do
end
describe '.latest' do
let(:project_news) { News.where(project:) }
let(:project_news) { described_class.where(project:) }
before do
Role.anonymous
end
it 'includes news elements from projects where news module is enabled' do
expect(News.latest).to match_array [news]
expect(described_class.latest).to match_array [news]
end
it "doesn't include news elements from projects where news module is not enabled" do
EnabledModule.where(project_id: project.id, name: 'news').delete_all
expect(News.latest).to be_empty
expect(described_class.latest).to be_empty
end
it 'only includes news elements from projects that are visible to the user' do
private_project = create(:project, public: false)
create(:news, project: private_project)
latest_news = News.latest(user: User.anonymous)
latest_news = described_class.latest(user: User.anonymous)
expect(latest_news).to match_array [news]
end
@ -123,8 +123,41 @@ describe News, type: :model do
end
it 'returns nil for unsaved news' do
news = News.new
news = described_class.new
expect(news.to_param).to be_nil
end
end
describe '#new_comment' do
subject(:comment) { news.new_comment(author: news.author, comments: 'some important words') }
it 'sets the comment`s news' do
expect(comment.commented)
.to eq news
end
it 'is saveable' do
expect(comment.save)
.to be_truthy
end
end
describe '#comments_count' do
it 'counts the comments on the news when adding' do
expect { news.comments.create(author: news.author, comments: 'some important words') }
.to change { news.reload.comments_count }
.from(0)
.to(1)
end
it 'counts the comments on the news when destroying a comment' do
comment = news.comments.build(author: news.author, comments: 'some important words')
comment.save
expect { comment.destroy }
.to change { news.reload.comments_count }
.from(1)
.to(0)
end
end
end

86
spec_legacy/unit/comment_spec.rb
Unescape View File

@ -1,86 +0,0 @@
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2022 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++
require_relative './../legacy_spec_helper'
describe Comment, type: :model do
include MiniTest::Assertions # refute
it 'validationses' do
# factory valid
assert build(:comment).valid?
# comment text required
refute build(:comment, comments: '').valid?
# object that is commented required
refute build(:comment, commented: nil).valid?
# author required
refute build(:comment, author: nil).valid?
end
it 'creates' do
user = create(:user)
news = create(:news)
comment = Comment.new(commented: news, author: user, comments: 'some important words')
assert comment.save
assert_equal 1, news.reload.comments_count
end
it 'creates through news' do
user = create(:user)
news = create(:news)
comment = news.new_comment(author: user, comments: 'some important words')
assert comment.save
assert_equal 1, news.reload.comments_count
end
it 'creates comment through news' do
user = create(:user)
news = create(:news)
news.post_comment!(author: user, comments: 'some important words')
assert_equal 1, news.reload.comments_count
end
it 'texts' do
comment = build(:comment, comments: 'something useful')
assert_equal 'something useful', comment.text
end
# TODO: testing #destroy really needed?
it 'destroys' do
# just setup
news = create(:news)
comment = build(:comment)
news.comments << comment
assert comment.persisted?
# #reload is needed to refresh the count
assert_equal 1, news.reload.comments_count
comment.destroy
assert_equal 0, news.reload.comments_count
end
end
Write Preview
Loading…
Cancel
Save