From 72072809934368cc85fc8dd4a6dd49280dd36b7b Mon Sep 17 00:00:00 2001
From: Gregor Schmidt <ruby@schmidtwisser.de>
Date: Mon, 28 Mar 2011 13:58:50 +0200
Subject: [PATCH] using jQuery.noConflict() in a more idiomatic way

also putting everything into html head
---
 app/views/shared/_settings.html.erb | 53 ++++++++++++++++-------------
 1 file changed, 29 insertions(+), 24 deletions(-)

diff --git a/app/views/shared/_settings.html.erb b/app/views/shared/_settings.html.erb
index 60901edb1e..f74ef1cd8a 100644
--- a/app/views/shared/_settings.html.erb
+++ b/app/views/shared/_settings.html.erb
@@ -1,33 +1,38 @@
-<%= javascript_include_tag 'jquery-1.4.2.min.js', :plugin => 'redmine_backlogs' %>
+<% content_for :header_tags do %>
+  <%= javascript_include_tag 'jquery-1.4.2.min.js', :plugin => 'redmine_backlogs' %>
+  <script type="text/javascript">
+    jQuery.noConflict();
 
-<script type="text/javascript">
-  var $j = jQuery.noConflict();
+    jQuery(function($) {
+      var enable_apply = function () {
+        var tasktracker,
+            submit,
+            disable;
 
-  function enable_apply()
-  {
-    tasktracker = $j("#settings_task_tracker").val();
-    submit = $j('input[type=submit]')
+        tasktracker = $("#settings_task_tracker").val();
+        submit = $('input[type=submit]');
 
+        disable = false;
 
-    disable = false;
-    log = tasktracker + '::'
-    $j("#settings_story_trackers :selected").each(function(i, selected){
-      disable = disable || ($j(selected).attr('value') == tasktracker);
-    });
-    if (disable) {
-      submit.attr('disabled', 'disabled');
-    } else {
-      submit.removeAttr('disabled');
-    }
-  }
+        $("#settings_story_trackers :selected").each(function(i, selected) {
+          disable = disable || ($(selected).attr('value') === tasktracker);
+        });
+
+        if (disable) {
+          submit.attr('disabled', 'disabled');
+        }
+        else {
+          submit.removeAttr('disabled');
+        }
+      };
 
-  $j(document).ready(function() {
-    $j("#settings_task_tracker").change(function() { enable_apply(); });
-    $j("#settings_story_trackers").change(function() { enable_apply(); });
+      $("#settings_task_tracker").change(enable_apply);
+      $("#settings_story_trackers").change(enable_apply);
 
-    enable_apply();
-  });
-</script>
+      enable_apply();
+    });
+  </script>
+<% end %>
 
 <p>
   <%= label_tag("settings[story_trackers]", l(:backlogs_story_tracker)) %>