Also fixes https://community.openproject.com/projects/openproject/work_packages/27844pull/6827/head
Oliver Günther
6 years ago
parent
f792df2235
commit
7ed1392518
@ -1,5 +0,0 @@ |
||||
(function($) { |
||||
<% if current_user.allowed_to? :view_hourly_rates, @project %> |
||||
$('#<%= "#{@element_id}_costs" %>').html("<%= number_to_currency(@costs) %>"); |
||||
<% end %> |
||||
})(jQuery); |
||||
@ -1,7 +0,0 @@ |
||||
(function($) { |
||||
<% if current_user.allowed_to? :view_cost_rates, @project %> |
||||
$('#<%= "#{@element_id}_costs" %>').html("<%= number_to_currency(@costs) %>"); |
||||
<% end %> |
||||
|
||||
$('#<%= "#{@element_id}_unit_name" %>').html("<%= h(@unit) %>"); |
||||
})(jQuery); |
||||
@ -0,0 +1,98 @@ |
||||
#-- copyright |
||||
# OpenProject Costs Plugin |
||||
# |
||||
# Copyright (C) 2009 - 2014 the OpenProject Foundation (OPF) |
||||
# |
||||
# This program is free software; you can redistribute it and/or |
||||
# modify it under the terms of the GNU General Public License |
||||
# version 3. |
||||
# |
||||
# This program is distributed in the hope that it will be useful, |
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
||||
# GNU General Public License for more details. |
||||
# |
||||
# You should have received a copy of the GNU General Public License |
||||
# along with this program; if not, write to the Free Software |
||||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
||||
#++ |
||||
|
||||
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') |
||||
|
||||
describe 'Work Package cost fields', type: :feature, js: true do |
||||
let(:type_task) { FactoryBot.create(:type_task) } |
||||
let!(:status) { FactoryBot.create(:status, is_default: true) } |
||||
let!(:priority) { FactoryBot.create(:priority, is_default: true) } |
||||
let!(:project) { |
||||
FactoryBot.create(:project, types: [type_task]) |
||||
} |
||||
let(:user) { FactoryBot.create :user, |
||||
member_in_project: project, |
||||
member_through_role: role } |
||||
let(:role) { FactoryBot.create :role, permissions: [:view_work_packages, |
||||
:delete_work_packages, |
||||
:log_costs, |
||||
:view_cost_rates, |
||||
:edit_cost_entries, |
||||
:view_cost_entries] } |
||||
let!(:cost_type1) { |
||||
type = FactoryBot.create :cost_type, name: 'A', unit: 'A single', unit_plural: 'A plural' |
||||
FactoryBot.create :cost_rate, cost_type: type, rate: 1.00 |
||||
type |
||||
} |
||||
|
||||
let!(:cost_type2) { |
||||
type = FactoryBot.create :cost_type, name: 'B', unit: 'B single', unit_plural: 'B plural' |
||||
FactoryBot.create :cost_rate, cost_type: type, rate: 2.00 |
||||
type |
||||
} |
||||
|
||||
let!(:work_package) { FactoryBot.create :work_package, project: project, status: status, type: type_task } |
||||
let(:full_view) { ::Pages::FullWorkPackage.new(work_package, project) } |
||||
|
||||
before do |
||||
login_as(user) |
||||
full_view.visit! |
||||
end |
||||
|
||||
it 'does not show read-only fields' do |
||||
|
||||
# Go to add cost entry page |
||||
find('#action-show-more-dropdown-menu .button').click |
||||
find('.menu-item', text: 'Log unit costs').click |
||||
|
||||
# Set single value, should update suffix |
||||
select 'A', from: 'cost_entry_cost_type_id' |
||||
fill_in 'cost_entry_units', with: '1' |
||||
sleep 1 |
||||
expect(page).to have_selector('#cost_entry_unit_name', text: 'A single') |
||||
expect(page).to have_selector('#cost_entry_costs', text: '1.00 EUR') |
||||
|
||||
fill_in 'cost_entry_units', with: '2' |
||||
sleep 1 |
||||
expect(page).to have_selector('#cost_entry_unit_name', text: 'A plural') |
||||
expect(page).to have_selector('#cost_entry_costs', text: '2.00 EUR') |
||||
|
||||
# Switch cost type |
||||
select 'B', from: 'cost_entry_cost_type_id' |
||||
expect(page).to have_selector('#cost_entry_unit_name', text: 'B plural') |
||||
expect(page).to have_selector('#cost_entry_costs', text: '4.00 EUR') |
||||
|
||||
# Override costs |
||||
find('#cost_entry_costs').click |
||||
fill_in 'cost_entry_costs_edit', with: '15' |
||||
|
||||
click_on 'Save' |
||||
|
||||
# Expect correct costs |
||||
expect(page).to have_selector('.flash.notice', text: I18n.t(:notice_cost_logged_successfully)) |
||||
entry = CostEntry.last |
||||
expect(entry.cost_type_id).to eq(cost_type2.id) |
||||
expect(entry.units).to eq(2.0) |
||||
expect(entry.costs).to eq(4.0) |
||||
expect(entry.real_costs).to eq(15.0) |
||||
|
||||
visit edit_cost_entry_path(entry) |
||||
expect(page).to have_selector('#cost_entry_costs', text: '15.00 EUR') |
||||
end |
||||
end |
||||
Loading…
Reference in new issue