Merge pull request #8622 from opf/fix/add-missing-status-explanation

[34000] Ensure user custom fields can be copied

app/models/custom_field.rb

@@ -277,7 +277,7 @@ class CustomField < ApplicationRecord
 
   def possible_user_values_options(obj)
     mapped_with_deduced_project(obj) do |project|
-      if project
+      if project&.persisted?
         project.users
       else
         Principal

app/services/copy/dependency.rb

@@ -80,7 +80,7 @@ module Copy
       rescue StandardError => e
         Rails.logger.error { "Failed to copy dependency #{self.class.identifier}: #{e.message}" }
         result.success = false
-        result.errors.add(:base, :could_not_be_copied, dependency: self.class.name)
+        result.errors.add(:base, :could_not_be_copied, dependency: self.class.human_name)
       end
 
       result

app/services/projects/copy_service.rb

@@ -73,11 +73,8 @@ module Projects
       # Copy status object
       target.status = source.status&.dup
 
-      # Copy enabled custom fields and their values
+      # Take over the CF values for attributes
       target.custom_field_values = source.custom_value_attributes
-      target.custom_values = source.custom_values.map(&:dup)
-
-      target.status = source.status.dup
 
       # Additional input target params
       target_project_params = params[:target_project_params].with_indifferent_access

spec/services/projects/copy_service_integration_spec.rb

@@ -553,7 +553,7 @@ describe Projects::CopyService, 'integration', type: :model do
         end
       end
 
-      describe 'user custom field' do
+      describe 'work package user custom field' do
         let(:custom_field) do
           FactoryBot.create(:user_wp_custom_field).tap do |cf|
             source.work_package_custom_fields << cf
@@ -591,5 +591,31 @@ describe Projects::CopyService, 'integration', type: :model do
         end
       end
     end
+
+    describe 'project custom fields' do
+      context 'with user project CF' do
+        let(:user_custom_field) { FactoryBot.create(:user_project_custom_field) }
+        let(:user_value) do
+          FactoryBot.create(:user,
+                            member_in_project: source,
+                            member_through_role: role)
+        end
+
+        before do
+          source.custom_values << CustomValue.new(custom_field: user_custom_field, value: user_value.id.to_s)
+        end
+
+        let(:only_args) { %w[wiki] }
+
+        it 'copies the custom_field' do
+          expect(subject).to be_success
+
+          cv = project_copy.custom_values.reload.find_by(custom_field: user_custom_field)
+          expect(cv).to be_present
+          expect(cv.value).to eq user_value.id.to_s
+          expect(cv.typed_value).to eq user_value
+        end
+      end
+    end
   end
 end