diff --git a/app/assets/fonts/openproject_icon/openproject-icon-font.eot b/app/assets/fonts/openproject_icon/openproject-icon-font.eot index e6dc640516..e3d4af192e 100644 Binary files a/app/assets/fonts/openproject_icon/openproject-icon-font.eot and b/app/assets/fonts/openproject_icon/openproject-icon-font.eot differ diff --git a/app/assets/fonts/openproject_icon/openproject-icon-font.svg b/app/assets/fonts/openproject_icon/openproject-icon-font.svg index 9ff6503ea9..1ebde47595 100644 --- a/app/assets/fonts/openproject_icon/openproject-icon-font.svg +++ b/app/assets/fonts/openproject_icon/openproject-icon-font.svg @@ -275,4 +275,5 @@ + diff --git a/app/assets/fonts/openproject_icon/openproject-icon-font.ttf b/app/assets/fonts/openproject_icon/openproject-icon-font.ttf index d7f80131fb..8f64f72512 100644 Binary files a/app/assets/fonts/openproject_icon/openproject-icon-font.ttf and b/app/assets/fonts/openproject_icon/openproject-icon-font.ttf differ diff --git a/app/assets/fonts/openproject_icon/openproject-icon-font.woff b/app/assets/fonts/openproject_icon/openproject-icon-font.woff index 4bc07c3e8e..56bf5dc7bb 100644 Binary files a/app/assets/fonts/openproject_icon/openproject-icon-font.woff and b/app/assets/fonts/openproject_icon/openproject-icon-font.woff differ diff --git a/app/assets/stylesheets/content/_in_place_editing.lsg b/app/assets/stylesheets/content/_in_place_editing.lsg index 74dc2078de..4997b536c4 100644 --- a/app/assets/stylesheets/content/_in_place_editing.lsg +++ b/app/assets/stylesheets/content/_in_place_editing.lsg @@ -158,7 +158,7 @@ - + Description: Cancel @@ -287,7 +287,7 @@ - + Description: Cancel diff --git a/app/assets/stylesheets/content/_in_place_editing.sass b/app/assets/stylesheets/content/_in_place_editing.sass index 4da409079a..9b944df03c 100644 --- a/app/assets/stylesheets/content/_in_place_editing.sass +++ b/app/assets/stylesheets/content/_in_place_editing.sass @@ -179,8 +179,9 @@ visibility: hidden font-size: rem-calc(14px) - .icon-edit::before, - .icon-delete::before + .icon-edit:before, + .icon-delete:before, + .icon-remove:before // HACK: overriding default padding here padding-right: 0 diff --git a/app/assets/stylesheets/content/_notifications.lsg b/app/assets/stylesheets/content/_notifications.lsg index 8b919c17b9..b211eb9b03 100644 --- a/app/assets/stylesheets/content/_notifications.lsg +++ b/app/assets/stylesheets/content/_notifications.lsg @@ -22,7 +22,7 @@ ```
- +

An error occured, here are the facts:

    @@ -39,7 +39,7 @@ ```
    - +

    This is a warning. You may ignore it, but bad things might happen.

    @@ -50,7 +50,7 @@ ```
    - +

    Successful update. A link to the past

    diff --git a/app/assets/stylesheets/fonts/_openproject_icon_font.lsg b/app/assets/stylesheets/fonts/_openproject_icon_font.lsg index 3cdeb74d32..7b48847440 100644 --- a/app/assets/stylesheets/fonts/_openproject_icon_font.lsg +++ b/app/assets/stylesheets/fonts/_openproject_icon_font.lsg @@ -57,8 +57,7 @@
  • changeset3
  • clock-reminder
  • close
  • -
  • close2
  • -
  • close2
  • +
  • cross
  • code-tag
  • color-text
  • color-underline
  • @@ -191,6 +190,7 @@
  • redo
  • reload1
  • reload2
  • +
  • remove
  • rename
  • rss
  • rss2
  • @@ -247,7 +247,6 @@
  • undo
  • unit
  • unit2
  • -
  • unit2
  • unlocked
  • user-guide-admin
  • user-guide-user
  • diff --git a/app/assets/stylesheets/fonts/_openproject_icon_font.sass b/app/assets/stylesheets/fonts/_openproject_icon_font.sass index c33dffc29e..185027af9a 100644 --- a/app/assets/stylesheets/fonts/_openproject_icon_font.sass +++ b/app/assets/stylesheets/fonts/_openproject_icon_font.sass @@ -216,12 +216,9 @@ dt > .icon-changeset:before, .icon-changeset:before content: "\e006" -.icon-close:before +.icon-cross:before content: "\e007" -.icon-close2:before - content: "\e0f6" - .icon-copy:before content: "\e008" @@ -950,7 +947,7 @@ dt > .icon-wiki-page:before, .icon-glossar:before content: "\e0f5" -.icon-close2:before +.icon-close:before content: "\e0f6" .icon-hosting:before @@ -1007,6 +1004,14 @@ dt > .icon-wiki-page:before, .icon-compare:before content: "\e108" +.icon-remove:before + content: "\e109" + // HACK to align this icon and it's text + // This occurs because the icon is not aligned at its border. + // This should be removed when the icon font is updated. + position: relative + top: 0.15em + /* remove once all menu items have an icon */ .no-icon margin-left: 15px diff --git a/app/views/groups/_memberships.html.erb b/app/views/groups/_memberships.html.erb index faef47bfa1..d628b79938 100644 --- a/app/views/groups/_memberships.html.erb +++ b/app/views/groups/_memberships.html.erb @@ -85,10 +85,10 @@ See doc/COPYRIGHT.rdoc for more details. <%= link_to_function l(:button_edit), "$('member-#{membership.id}-roles').hide(); $('member-#{membership.id}-roles-form').show(); return false;", :class => 'icon icon-edit' %> - <%= link_to l(:button_delete), membership_of_group_path(@group, membership), + <%= link_to l(:button_remove), membership_of_group_path(@group, membership), :method => :delete, :remote => true, - :class => 'icon icon-delete' %> + :class => 'icon icon-remove' %> diff --git a/app/views/groups/_users.html.erb b/app/views/groups/_users.html.erb index 465ffbc564..2214a5a2ad 100644 --- a/app/views/groups/_users.html.erb +++ b/app/views/groups/_users.html.erb @@ -55,10 +55,10 @@ See doc/COPYRIGHT.rdoc for more details. <%= link_to_user user %> - <%= link_to l(:button_delete), member_of_group_path(@group, user), + <%= link_to l(:button_remove), member_of_group_path(@group, user), :method => :delete, :remote => :true, - :class => 'icon icon-delete' %> + :class => 'icon icon-remove' %> <% end %> diff --git a/app/views/members/index.html.erb b/app/views/members/index.html.erb index fd31160f26..fdaa9daddd 100644 --- a/app/views/members/index.html.erb +++ b/app/views/members/index.html.erb @@ -124,7 +124,7 @@ See doc/COPYRIGHT.rdoc for more details. delete_class, delete_title = if member.disposable? ['icon icon-delete', I18n.t(:title_remove_and_delete_user)] else - ['icon icon-close', I18n.t(:button_remove)] + ['icon icon-remove', I18n.t(:button_remove)] end %> <%= link_to_function '', "$('member-#{member.id}-roles').hide(); $('member-#{member.id}-roles-form').show(); return false;", :class => 'icon icon-edit', :title => l(:button_edit) %> diff --git a/app/views/repositories/_checkout_instructions.html.erb b/app/views/repositories/_checkout_instructions.html.erb index 6b2e3b3268..b67516d338 100644 --- a/app/views/repositories/_checkout_instructions.html.erb +++ b/app/views/repositories/_checkout_instructions.html.erb @@ -27,7 +27,7 @@ See doc/COPYRIGHT.rdoc for more details. ++#%>
    - +

    <%= simple_format instructions.instructions %> diff --git a/app/views/types/index.html.erb b/app/views/types/index.html.erb index 34cb65f06d..1b0a3a969f 100644 --- a/app/views/types/index.html.erb +++ b/app/views/types/index.html.erb @@ -123,7 +123,7 @@ See doc/COPYRIGHT.rdoc for more details. <%= reorder_links('type', {:action => 'move', :id => type}) %> <% if !type.is_standard? %> - <%= link_to type, :method => :delete, data: { confirm: t(:text_are_you_sure) }, :class => 'icon-context icon-delete' do %> + <%= link_to type, :method => :delete, data: { confirm: t(:text_are_you_sure) }, :class => 'icon icon-delete' do %> <%= t(:button_delete) %> <%=h type.name %> <% end %> diff --git a/app/views/users/_memberships.html.erb b/app/views/users/_memberships.html.erb index b305effaab..f98601aec0 100644 --- a/app/views/users/_memberships.html.erb +++ b/app/views/users/_memberships.html.erb @@ -95,13 +95,13 @@ See doc/COPYRIGHT.rdoc for more details. <%= call_hook(:view_users_memberships_table_row, :user => @user, :membership => membership, :roles => roles, :projects => projects )%> <%= link_to_function l(:button_edit), "$('member-#{membership.id}-roles').hide(); $('member-#{membership.id}-roles-form').show(); return false;", :class => 'icon icon-edit' %> - <%= link_to(l(:button_delete), { :controller => 'users', + <%= link_to(l(:button_remove), { :controller => 'users', :action => 'destroy_membership', :id => @user, :membership_id => membership }, :remote => true, :method => :post, - :class => 'icon icon-delete') if membership.deletable? %> + :class => 'icon icon-remove') if membership.deletable? %> <% end %> diff --git a/config/locales/js-en.yml b/config/locales/js-en.yml index 697ee6005b..c44613b4fe 100644 --- a/config/locales/js-en.yml +++ b/config/locales/js-en.yml @@ -165,7 +165,7 @@ en: label_drop_files: Drop files here label_drop_files_hint: or click to add files label_remove_file: "Delete %{fileName}" - label_remove_watcher: "Delete watcher %{name}" + label_remove_watcher: "Remove watcher %{name}" label_remove_all_files: Delete all files label_add_description: "Add a description for %{file}" label_upload_notification: "Uploading files for Work package #%{id}: %{subject}" @@ -436,7 +436,7 @@ en: notice_bad_request: "Bad Request." relations: empty: No relation exists - delete: Delete relation + remove: Remove relation inplace: button_edit: "%{attribute}: Edit" button_save: "%{attribute}: Save" diff --git a/features/step_definitions/admin_steps.rb b/features/step_definitions/admin_steps.rb index 41e31bfab9..6f0a95a5e1 100644 --- a/features/step_definitions/admin_steps.rb +++ b/features/step_definitions/admin_steps.rb @@ -53,7 +53,7 @@ end When /^I delete membership to project "(.*?)"$/ do |project| project = Project.like(project).first - page.find(:css, '#tab-content-memberships .memberships').find(:xpath, "//tr[contains(.,'#{project.name}')]").find(:css, '.icon-delete').click + page.find(:css, '#tab-content-memberships .memberships').find(:xpath, "//tr[contains(.,'#{project.name}')]").find(:css, '.icon-remove').click end When /^I edit membership to project "(.*?)" to contain the roles:$/ do |project, roles_table| diff --git a/frontend/app/templates/components/notification-box.html b/frontend/app/templates/components/notification-box.html index 114b261016..2fade7aee4 100644 --- a/frontend/app/templates/components/notification-box.html +++ b/frontend/app/templates/components/notification-box.html @@ -31,5 +31,5 @@

    - +
    diff --git a/frontend/app/templates/work_packages/tabs/_work_package_relations.html b/frontend/app/templates/work_packages/tabs/_work_package_relations.html index 58eefe8e81..75d11c754e 100644 --- a/frontend/app/templates/work_packages/tabs/_work_package_relations.html +++ b/frontend/app/templates/work_packages/tabs/_work_package_relations.html @@ -44,8 +44,8 @@ - + diff --git a/frontend/app/templates/work_packages/watchers/watcher.html b/frontend/app/templates/work_packages/watchers/watcher.html index bf0468adba..e24fe07dc0 100644 --- a/frontend/app/templates/work_packages/watchers/watcher.html +++ b/frontend/app/templates/work_packages/watchers/watcher.html @@ -19,7 +19,7 @@ data-ng-click="remove()" data-ng-focus="focus()" data-ng-blur="blur()"> - diff --git a/frontend/tests/unit/tests/work_packages/directives/work-package-relations-directive-test.js b/frontend/tests/unit/tests/work_packages/directives/work-package-relations-directive-test.js index 51bd2d3817..2971961b3c 100644 --- a/frontend/tests/unit/tests/work_packages/directives/work-package-relations-directive-test.js +++ b/frontend/tests/unit/tests/work_packages/directives/work-package-relations-directive-test.js @@ -76,7 +76,7 @@ describe('Work Package Relations Directive', function() { stub.withArgs('js.work_packages.properties.subject').returns('Column0'); stub.withArgs('js.work_packages.properties.status').returns('Column1'); stub.withArgs('js.work_packages.properties.assignee').returns('Column2'); - stub.withArgs('js.relations.delete').returns('Delete relation'); + stub.withArgs('js.relations.remove').returns('Remove relation'); })); afterEach(function() { @@ -294,9 +294,9 @@ describe('Work Package Relations Directive', function() { if(removable) { var column4 = angular.element(element.find('.workpackages table tbody tr:nth-of-type(' + x + ') td:nth-child(4)')); - var deleteIcon = angular.element(column4.find('span.icon-delete')); - expect(deleteIcon.length).not.to.eq(0); - expect(deleteIcon.attr('title')).to.include('Delete relation'); + var removeIcon = angular.element(column4.find('span.icon-remove')); + expect(removeIcon.length).not.to.eq(0); + expect(removeIcon.attr('title')).to.include('Remove relation'); } } });