diff --git a/app/helpers/costlog_helper.rb b/app/helpers/costlog_helper.rb index 6ae9e20dec..da40b1fd6b 100644 --- a/app/helpers/costlog_helper.rb +++ b/app/helpers/costlog_helper.rb @@ -35,17 +35,12 @@ module CostlogHelper cost_types << selected_type cost_types.sort end - collection = [] - collection << ["--- #{t(:actionview_instancetag_blank_option)} ---", ''] unless cost_types.detect(&:is_default?) - cost_types.each do |t| collection << [t.name, t.id] end - collection + cost_types.map { |t| [t.name, t.id] } end def user_collection_for_select_options(_options = {}) users = @project.possible_assignees - collection = [] - users.each do |u| collection << [u.name, u.id] end - collection + users.map { |t| [t.name, t.id] } end def extended_progress_bar(pcts, options = {}) diff --git a/app/views/costlog/edit.html.erb b/app/views/costlog/edit.html.erb index f748cd54df..475903ba52 100644 --- a/app/views/costlog/edit.html.erb +++ b/app/views/costlog/edit.html.erb @@ -46,17 +46,20 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
<%= f.text_field :spent_on, size: 10, required: true %> + <%= calendar_for('cost_entry_spent_on') %>
<% if User.current.allowed_to? :log_costs, @project %>
- <%= f.select :user_id, user_collection_for_select_options, required: true %> + <%# Without knowing why `prompt` is in this case responsible for no blank line in the selection options %> + <%= f.select :user_id, user_collection_for_select_options, required: true, prompt: true, prompt: true %>
<% else %> <%= f.hidden_field :user_id, value: User.current.id %> <% end %>
- <%= f.select :cost_type_id, cost_types_collection_for_select_options, required: true %>

+ <%# see above %> + <%= f.select :cost_type_id, cost_types_collection_for_select_options, required: true, prompt: true %>

<% if @cost_entry.cost_type.nil? %>