From 95567e2e1d5c0340bf65f8d75e1b0e43f1f6749c Mon Sep 17 00:00:00 2001 From: Till Breuer Date: Tue, 18 Mar 2014 10:39:41 +0100 Subject: [PATCH] Fix non-assignable expression issue --- .../directives/work_packages/work-package-column-directive.js | 2 +- .../angular/helpers/components/custom-field-helper.js | 1 + public/templates/work_packages/work_packages_table.html | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/angular/directives/work_packages/work-package-column-directive.js b/app/assets/javascripts/angular/directives/work_packages/work-package-column-directive.js index a635624a5d..d3692aacc7 100644 --- a/app/assets/javascripts/angular/directives/work_packages/work-package-column-directive.js +++ b/app/assets/javascripts/angular/directives/work_packages/work-package-column-directive.js @@ -8,7 +8,7 @@ angular.module('openproject.workPackages.directives') scope: { workPackage: '=', column: '=', - displayType: '=' + displayType: '@' }, templateUrl: '/templates/work_packages/work_package_column.html', link: function(scope, element, attributes) { diff --git a/app/assets/javascripts/angular/helpers/components/custom-field-helper.js b/app/assets/javascripts/angular/helpers/components/custom-field-helper.js index ed4c6fbb45..bff12a84f4 100644 --- a/app/assets/javascripts/angular/helpers/components/custom-field-helper.js +++ b/app/assets/javascripts/angular/helpers/components/custom-field-helper.js @@ -25,6 +25,7 @@ angular.module('openproject.helpers') return CustomFieldHelper.booleanCustomFieldValue(value); case 'user': if (users && users[value]) { + // try to look up users return users[value].name; } else { // return user id diff --git a/public/templates/work_packages/work_packages_table.html b/public/templates/work_packages/work_packages_table.html index 0956fa3581..0447037e84 100644 --- a/public/templates/work_packages/work_packages_table.html +++ b/public/templates/work_packages/work_packages_table.html @@ -112,7 +112,7 @@ + display-type="{{column.meta_data.data_type}}"/>