From 9b64c6076d4150efb9ee6648d893d5e9316b5134 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Oliver=20G=C3=BCnther?= <mail@oliverguenther.de>
Date: Tue, 12 Oct 2021 13:53:12 +0200
Subject: [PATCH] Output http constraint errors in the notification box

---
 .../features/hal/resources/error-resource.ts  | 20 +++++++++++++++
 .../notifications/notifications.service.ts    | 25 ++++++++++++++++---
 2 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/frontend/src/app/features/hal/resources/error-resource.ts b/frontend/src/app/features/hal/resources/error-resource.ts
index fba5b37fb4..d7f9f475c1 100644
--- a/frontend/src/app/features/hal/resources/error-resource.ts
+++ b/frontend/src/app/features/hal/resources/error-resource.ts
@@ -32,6 +32,26 @@ import { HttpErrorResponse } from '@angular/common/http';
 export const v3ErrorIdentifierQueryInvalid = 'urn:openproject-org:api:v3:errors:InvalidQuery';
 export const v3ErrorIdentifierMultipleErrors = 'urn:openproject-org:api:v3:errors:MultipleErrors';
 
+export interface IHalErrorBase {
+  _type:string;
+  message:string;
+  errorIdentifier:string;
+}
+
+export interface IHalSingleError extends IHalErrorBase {
+  _embedded:{
+    details:{
+      attribute:string;
+    }
+  }
+}
+
+export interface IHalMultipleError extends IHalErrorBase {
+  _embedded:{
+    errors:IHalSingleError[];
+  }
+}
+
 export class ErrorResource extends HalResource {
   public errors:any[];
 
diff --git a/frontend/src/app/shared/components/notifications/notifications.service.ts b/frontend/src/app/shared/components/notifications/notifications.service.ts
index 861efe8b47..bcb5fddaa1 100644
--- a/frontend/src/app/shared/components/notifications/notifications.service.ts
+++ b/frontend/src/app/shared/components/notifications/notifications.service.ts
@@ -27,9 +27,17 @@
 //++
 
 import { ConfigurationService } from 'core-app/core/config/configuration.service';
-import { input, State } from 'reactivestates';
+import {
+  input,
+  State,
+} from 'reactivestates';
 import { Injectable } from '@angular/core';
 import { UploadInProgress } from 'core-app/core/file-upload/op-file-upload.service';
+import {
+  IHalErrorBase,
+  IHalMultipleError,
+} from 'core-app/features/hal/resources/error-resource';
+import { HttpErrorResponse } from '@angular/common/http';
 
 export function removeSuccessFlashMessages() {
   jQuery('.flash.notice').remove();
@@ -83,9 +91,18 @@ export class NotificationsService {
     return notification;
   }
 
-  public addError(message:INotification|string, errors:any[]|string = []) {
-    if (!Array.isArray(errors)) {
-      errors = [errors];
+  public addError(obj:HttpErrorResponse|INotification|string, additionalErrors:unknown[]|string = []) {
+    let message:INotification|string;
+    let errors = [...additionalErrors];
+
+    if (obj instanceof HttpErrorResponse && (obj.error as IHalMultipleError)?._embedded.errors) {
+      errors = [
+        ...additionalErrors,
+        ...(obj.error as IHalMultipleError)._embedded.errors.map((el:IHalErrorBase) => el.message),
+      ];
+      message = obj.message;
+    } else {
+      message = obj as INotification|string;
     }
 
     const notification:INotification = this.createNotification(message, 'error');