add project condition

pull/6140/head
Jens Ulferts 7 years ago
parent 7a8600b275
commit ab22a7fa97
No known key found for this signature in database
GPG Key ID: 3CAA4B1182CF5308
  1. 2
      app/models/custom_action.rb
  2. 67
      app/models/custom_actions/conditions/project.rb
  3. 5
      db/migrate/20180123092002_add_custom_actions.rb
  4. 76
      spec/models/custom_actions/conditions/project_spec.rb

@ -34,6 +34,7 @@ class CustomAction < ActiveRecord::Base
has_and_belongs_to_many :statuses
has_and_belongs_to_many :roles
has_and_belongs_to_many :types
has_and_belongs_to_many :projects
after_save :persist_conditions
@ -129,3 +130,4 @@ CustomActions::Register.action(CustomActions::Actions::CustomField)
CustomActions::Register.condition(CustomActions::Conditions::Status)
CustomActions::Register.condition(CustomActions::Conditions::Role)
CustomActions::Register.condition(CustomActions::Conditions::Type)
CustomActions::Register.condition(CustomActions::Conditions::Project)

@ -0,0 +1,67 @@
#-- encoding: UTF-8
#-- copyright
# OpenProject is a project management system.
# Copyright (C) 2012-2017 the OpenProject Foundation (OPF)
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy othe hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See doc/COPYRIGHT.rdoc for more details.
#++
class CustomActions::Conditions::Project < CustomActions::Conditions::Base
def self.key
:project
end
def self.custom_action_scope(work_packages, _user)
has_current_project = CustomAction
.includes(:projects)
.where(custom_actions_projects: { project_id: Array(work_packages).map(&:project_id).uniq })
has_no_project = CustomAction
.includes(:projects)
.where(custom_actions_projects: { project_id: nil })
has_current_project
.or(has_no_project)
end
def self.getter(custom_action)
ids = custom_action.project_ids
new(ids) if ids.any?
end
private
def associated
::Project
.select(:id, :name)
.order('LOWER(name)')
.map { |u| [u.id, u.name] }
end
end

@ -19,5 +19,10 @@ class AddCustomActions < ActiveRecord::Migration[5.0]
t.belongs_to :type
t.belongs_to :custom_action
end
create_table :custom_actions_projects do |t|
t.belongs_to :project
t.belongs_to :custom_action
end
end
end

@ -0,0 +1,76 @@
#-- copyright
# OpenProject is a project management system.
# Copyright (C) 2012-2017 the OpenProject Foundation (OPF)
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See doc/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
require_relative '../shared_expectations'
describe CustomActions::Conditions::Project, type: :model do
it_behaves_like 'associated custom condition' do
let(:key) { :project }
describe '#allowed_values' do
it 'is the list of all projects' do
projects = [FactoryGirl.build_stubbed(:project),
FactoryGirl.build_stubbed(:project)]
allow(Project)
.to receive_message_chain(:select, :order)
.and_return(projects)
expect(instance.allowed_values)
.to eql([{ value: nil, label: '-' },
{ value: projects.first.id, label: projects.first.name },
{ value: projects.last.id, label: projects.last.name }])
end
end
describe '#fulfilled_by?' do
let(:work_package) { double('work_package', project_id: 1) }
let(:user) { double('not relevant') }
it 'is true if values are empty' do
instance.values = []
expect(instance.fulfilled_by?(work_package, user))
.to be_truthy
end
it "is true if values include work package's project_id" do
instance.values = [1]
expect(instance.fulfilled_by?(work_package, user))
.to be_truthy
end
it "is false if values do not include work package's project_id" do
instance.values = [5]
expect(instance.fulfilled_by?(work_package, user))
.to be_falsey
end
end
end
end
Loading…
Cancel
Save