Merge pull request #2436 from 0xF013/fix/18277-cleanup-overview-code

cleanup details tab and fix a line in helper

frontend/app/helpers/custom-field-helper.js

@@ -86,4 +86,4 @@ module.exports = function(CUSTOM_FIELD_PREFIX, I18n) {
   };
 
   return CustomFieldHelper;
-};
+};

frontend/app/work_packages/controllers/details-tab-overview-controller.js

@@ -60,18 +60,6 @@ module.exports = function($scope,
     switch(format) {
     case STATUS_TYPE:
       return $scope.workPackage.embedded.status.props.name;
-    // case VERSION_TYPE:
-    //   if (!$scope.workPackage.props.versionId) {
-    //     return;
-    //   }
-    //   var versionLinkPresent = !!$scope.workPackage.links.version;
-    //   var versionTitle = versionLinkPresent ?
-    //                         $scope.workPackage.links.version.props.title :
-    //                         $scope.workPackage.props.versionName,
-    //       versionHref  = versionLinkPresent ?
-    //                         $scope.workPackage.links.version.href :
-    //                         null;
-    //   return {href: versionHref, title: versionTitle, viewable: versionLinkPresent};
     case USER_TYPE:
       return $scope.workPackage.embedded[property];
     case CATEGORY_TYPE: