From c8d109169ee995be9f4e16bd3667cce0a7d5111b Mon Sep 17 00:00:00 2001
From: Philipp Tessenow <philipp@tessenow.org>
Date: Fri, 3 Jan 2014 13:18:21 +0100
Subject: [PATCH] do not use deprecated methods Query#values_for and
 Query#operator_for

---
 app/models/query.rb                 |  7 ++++---
 app/views/queries/_filters.html.erb | 15 ++++++++-------
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/models/query.rb b/app/models/query.rb
index d2daf2c451..1a1959dd7a 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -281,11 +281,12 @@ class Query < ActiveRecord::Base
     project_clauses = []
     if project && !project.descendants.active.empty?
       ids = [project.id]
-      if has_filter?("subproject_id")
-        case operator_for("subproject_id")
+      subproject_filter = filter_for 'subproject_id'
+      if subproject_filter
+        case subproject_filter.operator
         when '='
           # include the selected subprojects
-          ids += values_for("subproject_id").each(&:to_i)
+          ids += subproject_filter.values.each(&:to_i)
         when '!*'
           # main project only
         else
diff --git a/app/views/queries/_filters.html.erb b/app/views/queries/_filters.html.erb
index db387178e8..246b0ca2a3 100644
--- a/app/views/queries/_filters.html.erb
+++ b/app/views/queries/_filters.html.erb
@@ -117,25 +117,26 @@ Event.observe(document,"dom:loaded", apply_filters_observer);
     </td>
     <td style="width:150px;">
         <%= label_tag "op_#{field}", l(:description_filter), :class => "hidden-for-sighted" %>
-        <%= select_tag "op[#{field}]", options_for_select(operators_for_select(options[:type]), query.operator_for(field)), :id => "operators_#{field}", :onchange => "toggle_operator('#{field}');", :class => "select-small", :style => "vertical-align: top;" %>
+        <%= select_tag "op[#{field}]", options_for_select(operators_for_select(options[:type]), query.filter_for(field).try(:operator)), :id => "operators_#{field}", :onchange => "toggle_operator('#{field}');", :class => "select-small", :style => "vertical-align: top;" %>
     </td>
     <td>
     <div id="div_values_<%= field %>" style="display:none;">
-    <% case options[:type]
+    <% field_values = query.filter_for(field).try(:values) || []
+    case options[:type]
     when :list, :list_optional, :list_status, :list_subprojects %>
-        <select <%= "multiple=true" if query.values_for(field) and query.values_for(field).length > 1 %> name="v[<%= field %>][]" id="values_<%= field %>" class="select-small" style="vertical-align: top;">
-        <%= options_for_select options[:values], query.values_for(field) %>
+        <select <%= "multiple=true" if field_values and field_values.length > 1 %> name="v[<%= field %>][]" id="values_<%= field %>" class="select-small" style="vertical-align: top;">
+        <%= options_for_select options[:values], field_values %>
         </select>
         <%= link_to_function image_tag('bullet_toggle_plus.png'), "toggle_multi_select('#{field}');", :style => "vertical-align: bottom;",
             :title => l(:label_enable_multi_select), :alt => l(:label_enable_multi_select) %>
     <% when :date, :date_past %>
-      <%= text_field_tag "v[#{field}][]", query.values_for(field), :id => "values_#{field}", :size => 3, :class => "select-small" %>
+      <%= text_field_tag "v[#{field}][]", field_values, :id => "values_#{field}", :size => 3, :class => "select-small" %>
       <label for='<%= "values_#{field}" %>'><%= l(:label_day_plural) %></label>
     <% when :string, :text %>
-      <%= text_field_tag "v[#{field}][]", query.values_for(field), :id => "values_#{field}", :size => 30, :class => "select-small" %>
+      <%= text_field_tag "v[#{field}][]", field_values, :id => "values_#{field}", :size => 30, :class => "select-small" %>
       <label for='<%= "values_#{field}" %>' class='hidden-for-sighted' ><%= l(:description_enter_text) %></label>
     <% when :integer %>
-      <%= text_field_tag "v[#{field}][]", query.values_for(field), :id => "values_#{field}", :size => 3, :class => "select-small" %>
+      <%= text_field_tag "v[#{field}][]", field_values, :id => "values_#{field}", :size => 3, :class => "select-small" %>
       <label for='<%= "values_#{field}" %>' class='hidden-for-sighted' ><%= l(:description_enter_number) %></label>
     <% end %>
     </div>