Icon accessibility [belongs to #5423]

app/views/cost_objects/index.html.erb

@@ -24,7 +24,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 <%= toolbar title: t(:label_cost_object_plural) do %>
   <% if authorize_for(:cost_objects, :new) %>
     <a href="<%= new_projects_cost_object_path(@project) %>" aria-label="<%= I18n.t(:button_add_cost_object) %>" id="add-budget-button" title="<%= I18n.t(:button_add_cost_object) %>" class="button -alt-highlight">
-      <i class="button--icon icon-add"></i>
+      <%= op_icon('button--icon icon-add') %>
       <span class="button--text"><%= t(:label_cost_object) %></span>
     </a>
   <% end %>

app/views/cost_objects/items/_labor_budget_item.html.erb

@@ -67,7 +67,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
     </td>
     <td class="delete budget-table--fields buttons">
       <a class="delete-budget-item no-decoration-on-hover" title="<%= t(:button_delete) %>" href="javascript:">
-        <span class="icon-context icon-delete"></span>
+        <%= op_icon('icon-context icon-delete') %>
         <span class="hidden-for-sighted"><%= t(:button_delete) %></span>
       </a>
     </td>

app/views/cost_objects/items/_material_budget_item.html.erb

@@ -73,7 +73,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
   </td>
   <td class="delete budget-table--fields buttons">
     <a class="delete-budget-item no-decoration-on-hover" title="<%= t(:button_delete) %>">
-      <span class="icon-context icon-delete"></span>
+      <%= op_icon('icon-context icon-delete') %>
       <span class="hidden-for-sighted"><%= t(:button_delete) %></span>
     </a>
   </td>

app/views/cost_objects/show.html.erb

@@ -25,21 +25,21 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
   <% if authorize_for(:cost_objects, :edit) %>
     <li class="toolbar-item">
       <%= link_to({ controller: 'cost_objects', action: 'edit',  id: @cost_object }, class: 'button', accesskey: accesskey(:edit)) do %>
-        <i class="button--icon icon-edit"></i> <%= t(:button_update) %>
+        <%= op_icon('button--icon icon-edit') %> <%= t(:button_update) %>
       <% end %>
     </li>
   <% end %>
   <% if authorize_for(:cost_objects, :copy) %>
     <li class="toolbar-item">
       <%= link_to({ controller: 'cost_objects', action: 'copy', id: @cost_object }, class: 'button') do %>
-        <i class="button--icon icon-copy"></i> <%= t(:button_copy) %>
+        <%= op_icon('button--icon icon-copy') %> <%= t(:button_copy) %>
       <% end %>
     </li>
   <% end %>
   <% if authorize_for(:cost_objects, :copy) %>
     <li class="toolbar-item">
       <%= link_to({ controller: 'cost_objects', action: 'destroy', id: @cost_object }, class: 'button', method: :delete, data: { confirm: t(:text_are_you_sure)}) do %>
-        <i class="button--icon icon-delete"></i> <%= t(:button_delete) %>
+        <%= op_icon('button--icon icon-delete') %> <%= t(:button_delete) %>
       <% end %>
     </li>
   <% end %>

app/views/cost_objects/subform/_labor_budget_subform.html.erb

@@ -94,7 +94,7 @@ end -%>
     </div>
     <div class="wp-inline-create-button">
       <a href="javascript:" class="budget-add-row wp-inline-create--add-link" role="link" title="<%= t(:button_add_budget_item) %>">
-        <i class="icon icon-add"></i>
+        <%= op_icon('icon icon-add') %>
       </a>
     </div>
   </fieldset>

app/views/cost_objects/subform/_material_budget_subform.html.erb

@@ -101,7 +101,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
     </div>
     <div class="wp-inline-create-button">
       <a href="javascript:" class="budget-add-row wp-inline-create--add-link" role="link" title="<%= t(:button_add_budget_item) %>">
-        <i class="icon icon-add"></i>
+        <%= op_icon('icon icon-add') %>
       </a>
     </div>
   </fieldset>

app/views/cost_types/edit.html.erb

@@ -105,7 +105,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
   <div class="wp-inline-create-button">
     <label class="hidden-for-sighted" for="add_rate_date" %>"><%= t(:description_date_for_new_rate) %></label>
     <a id="add_rate_date" href="javascript:" class="add-row-button wp-inline-create--add-link" title="<%= t(:button_add_rate) %>">
-      <i class="icon icon-add"></i>
+      <%= op_icon('icon icon-add') %>
     </a>
     <%= styled_button_tag t(:button_save), class: '-with-icon icon-checkmark' %>
   </div>

app/views/cost_types/index.html.erb

@@ -24,7 +24,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 <%= toolbar title: CostType.model_name.human(count: 2) do %>
   <li class="toolbar-item">
     <a href="<%= new_cost_type_path %>" aria-label="<%= t(:button_add_cost_type) %>" title="<%= t(:button_add_cost_type) %>" class="button -alt-highlight">
-      <i class="button--icon icon-add"></i>
+      <%= op_icon('button--icon icon-add') %>
       <span class="button--text"><%= CostType.model_name.human %></span>
     </a>
   </li>

app/views/costlog/index.html.erb

@@ -26,7 +26,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 <%= toolbar title: WorkPackage.human_attribute_name(:spent_costs) do %>
   <% if authorize_for(:costlog, :new) %>
     <%= link_to({:controller => '/costlog', :action => 'new', :work_package_id => @work_package }, class: 'button') do %>
-      <i class="button--icon icon-projects"></i> <%= t(:button_log_costs) %>
+      <%= op_icon('button--icon icon-projects') %> <%= t(:button_log_costs) %>
     <% end %>
   <% end %>
 <% end %>

app/views/hourly_rates/edit.html.erb

@@ -80,7 +80,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
   </div>
   <div class="wp-inline-create-button">
     <a href="javascript:" class="add-row-button wp-inline-create--add-link">
-      <i class="icon icon-add"></i>
+      <%= op_icon('icon icon-add') %>
         <%= t(:button_add_rate) %>
     </a>
   </div>

lib/open_project/costs/engine.rb

@@ -72,7 +72,7 @@ module OpenProject::Costs
       menu :admin_menu,
            :cost_types,
            { controller: '/cost_types', action: 'index' },
-           html: { class: 'icon2 icon-cost-types' },
+           icon: 'icon2 icon-cost-types',
            caption: :label_cost_type_plural
 
       menu :project_menu,
@@ -81,7 +81,7 @@ module OpenProject::Costs
            param: :project_id,
            before: :settings,
            caption: :cost_objects_title,
-           html: { class: 'icon2 icon-budget' }
+           icon: 'icon2 icon-budget'
 
       Redmine::Activity.map do |activity|
         activity.register :cost_objects, class_name: 'Activity::CostObjectActivityProvider', default: false