Remove obsolete legacy code

pull/5956/head
Henriette Dinger 7 years ago
parent 1df21cb3a1
commit e1294b972b
  1. 6
      app/assets/stylesheets/content/work_packages/fullscreen/_fullscreen.sass
  2. 47
      app/assets/stylesheets/layout/_accessibility.sass
  3. 1
      app/assets/stylesheets/layout/_index.sass
  4. 42
      app/assets/stylesheets/layout/_print.sass
  5. 28
      app/assets/stylesheets/layout/_work_package_table.sass
  6. 3
      app/assets/stylesheets/layout/_work_packages_details_view.sass
  7. 3
      app/assets/stylesheets/layout/_work_packages_full_view.sass
  8. 97
      app/assets/stylesheets/openproject/_accessibility.sass
  9. 2
      features/step_definitions/diff_steps.rb
  10. 2
      frontend/app/components/wp-inline-create/wp-inline-create.directive.html

@ -3,11 +3,5 @@
padding-top: 20px
.work-packages--edit-actions
.work-packages--left-panel &
position: absolute
width: calc(60% + 7px)
left: -20px
padding: 0 20px .5rem
.in_modal &
width: 100%

@ -1,47 +0,0 @@
//-- copyright
// OpenProject is a project management system.
// Copyright (C) 2012-2017 the OpenProject Foundation (OPF)
//
// This program is free software; you can redistribute it and/or
// modify it under the terms of the GNU General Public License version 3.
//
// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
// Copyright (C) 2006-2017 Jean-Philippe Lang
// Copyright (C) 2010-2013 the ChiliProject Team
//
// This program is free software; you can redistribute it and/or
// modify it under the terms of the GNU General Public License
// as published by the Free Software Foundation; either version 2
// of the License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
//
// See doc/COPYRIGHT.rdoc for more details.
//++
.hidden-for-sighted
position: absolute
left: -10000px
top: auto
width: 1px
height: 1px
overflow: hidden
body.accessibility-mode
.hidden-for-accessibility
display: none !important
&.controller-work_packages
#content
height: calc(100% - #{$breadcrumb-height})
padding-bottom: 0
[hidden]
display: none

@ -26,7 +26,6 @@
// See doc/COPYRIGHT.rdoc for more details.
//++
@import layout/accessibility
@import layout/base
@import layout/base_mobile
@import layout/grid

@ -1,5 +1,7 @@
/***** Media print specific styles *****/
// -------------------- Media print specific styles --------------------
@media print
// -------------------- ALL pages --------------------
.hide-when-print,
#top-menu,
#header,
#main-menu,
@ -7,7 +9,8 @@
#footer,
#breadcrumb,
.contextual,
.other-formats
.other-formats,
#wiki_add_attachment
display: none
.notification-box
@ -24,15 +27,10 @@
background: #fff
overflow: visible !important
&.hidden-navigation
width: 99%
margin-left: 0
#wiki_add_attachment
display: none
.hide-when-print
display: none
#content-wrapper.hidden-navigation,
#content.hidden-navigation
width: 99% !important
margin-left: 0 !important
.autoscroll
overflow-x: visible
@ -51,15 +49,11 @@
h3
font-size: 1.17em
//
// WORK PACKAGE table
//
// -------------------- Work Package views --------------------
body
&.controller-work_packages.action-index,
&.controller-work_packages.action-show,
&.controller-work_packages.full-create
.wp-timeline--slider-wrapper
display: none !important
#wrapper
overflow: visible !important
@ -78,10 +72,6 @@
overflow: visible !important
position: relative
&.hidden-navigation
width: 99%
margin-left: 0
.work-packages-list-view--container
padding-left: 0
.work-packages-split-view
@ -89,7 +79,6 @@
.work-packages-split-view--tabletimeline-side
.work-packages-split-view--tabletimeline-content
.wp-table--hierarchy-aditional-row,
tr.-checked,
.row-hovered
@ -110,24 +99,15 @@
// Do not show table on timelines print outs.
display: none
.wp-table--context-menu-column
display: none // remove column for info icon.
.wp-inline-create-button-row
display: none // remove row with plus icon
.work-packages-tabletimeline--timeline-side
contain: initial // For printing in Chrome
border-left: none
.work-packages--list-table-area
height: 100%
.work-package-table--container,
.generic-table--results-container
overflow: hidden
.wp-timeline--scroll-wrapper
border-left-width: 3px
// -------------------- Sepcial Rules for FF --------------------
html.-browser-firefox
body
&.controller-work_packages.action-index,

@ -150,9 +150,6 @@
// Hinter browser that the content of the flex is contained
contain: strict
.edit-all-mode .work-packages--left-panel
padding-bottom: 50px
.work-package--attachments--files
margin-bottom: 1rem
@ -205,35 +202,10 @@
margin: 0 0 0 10px
text-align: left
.work-package--attachments--hint
font-size: 85%
.controller-work_packages
#work-packages-query-selection
.select2-container
margin-left: 5px
.icon-button, .sort-header, .action-icon
cursor: pointer
select, input
&.to-validate.ng-dirty.ng-valid
border: 1px solid Green
&.to-validate.ng-dirty.ng-valid ~ span.ok
color: green
display: inline
&.to-validate.ng-dirty.ng-invalid
border: 1px solid Red
&.to-validate.ng-dirty.ng-invalid ~ span.ok
color: red
display: inline
.work_package
tr
line-height: $user-avatar-mini-width
.avatar-mini
float: left
#attributes
.form--field-container
max-width: 400px

@ -66,9 +66,6 @@ body.action-create
.tabrow
padding-left: 20px
.work-packages--create--title
margin-bottom: 1em
.work-packages--details-toolbar-container
position: absolute
bottom: 0

@ -122,9 +122,6 @@ body.controller-work_packages.full-create
h3.attributes-group--header-text
line-height: $work-package-details--tab-height - 10px
&.edit-all-mode
.work-packages--left-panel
height: calc(100% - 55px)
.work-packages-full-view--split-right
min-width: 420px

@ -26,7 +26,21 @@
// See doc/COPYRIGHT.rdoc for more details.
//++
// -------------------- General hidden classes --------------------
.hidden-for-sighted
position: absolute
left: -10000px
top: auto
width: 1px
height: 1px
overflow: hidden
[hidden]
display: none
// -------------------- Rules for accessibility mode --------------------
body.accessibility-mode
// -------------------- General --------------------
a:focus,
input:focus,
select:focus,
@ -35,6 +49,10 @@ body.accessibility-mode
*:focus
outline: 3px solid darkblue
.hidden-for-accessibility
display: none !important
// Highlight invalid input fields
.form--field-container,
.wp-edit-field
input:out-of-range,
@ -46,11 +64,34 @@ body.accessibility-mode
h3:hover a.wiki-anchor
display: none
.ng-modal-window.columns-modal .ng-modal-inner
overflow: auto
margin-top: 5vh
// Show skip links for motorically handicapped users
.skip-navigation-link:focus
top: auto
left: auto
// Necessary for correct contrast ratio
button:disabled,
a.button:disabled
color: $body-font-color
opacity: 0.80
button.-active,
a.button.-active
color: $body-font-color
&:hover,
&:focus
color: $body-font-color
// Show breadcrumb for better navigation
&:not(.controller-homescreen) #breadcrumb
display: block
// Allow a greater sensible area to click input checkboxes
// On the WP table this is not neccessary because the whole cell is clickable
table:not(.work-package-table) input[type='checkbox']
width: 100%
// -------------------- Top menu --------------------
// Mark currently selected top menu items
#top-menu
li a,
@ -64,28 +105,22 @@ body.accessibility-mode
&:hover
border-color: $main-menu-border-color
// Neccessary to have enough space for the border in IE
.work-packages--page-container
.inplace-edit .inplace-edit--read-value,
.inplace-edit .inplace-edit--read,
.inplace-edit form,
.id a
margin: 3px
max-width: calc(100% - 6px)
.inplace-edit form
display: block
.inplace-edit .inplace-edit--read-value
display: inline-block
// Allow a greater sensible area to click input checkboxes
// On the WP table this is not neccessary because the whole cell is clickable
table:not(.work-package-table) input[type='checkbox']
width: 100%
// -------------------- WP view & table --------------------
// Special columns modal for accessibility mode
.ng-modal-window.columns-modal .ng-modal-inner
overflow: auto
margin-top: 5vh
// Show WP skip links for motorically handicapped users
.skip-navigation-link:focus
top: auto
left: auto
&.controller-work_packages
// Cancel out breadcrumb
#content
height: calc(100% - #{$breadcrumb-height})
// Neccessary to have enough space for the border in IE
.wp-edit-field--container .wp-inline-edit--field
margin: 3px
max-width: calc(100% - 6px)
// Show inplace-editing icons so that they can be accessed directly
.inplace-editing--trigger-link
@ -94,22 +129,8 @@ body.accessibility-mode
.inplace-edit--icon-wrapper
visibility: visible
// Give space to show the border
.wp-relations-create-button .relation-create
width: calc(100% - 6px)
padding: 0
margin: 3px
// Necessary for correct contrast ratio
button:disabled,
a.button:disabled
color: $body-font-color
opacity: 0.80
button.-active,
a.button.-active
color: $body-font-color
&:hover,
&:focus
color: $body-font-color
&:not(.controller-homescreen) #breadcrumb
display: block

@ -28,7 +28,7 @@
#++
When(/^I follow the link to see the diff in the last journal$/) do
within('.work-packages--right-panel') do
within('.work-packages-full-view--split-right') do
# I assume activity sorting oldest to newest; In that case the last journal is
# the one where we need to click on the "Details" link
all('.work-package-details-activities-activity-contents .description-details').last.click

@ -1,4 +1,4 @@
<tr ng-if="!$ctrl.isHidden" class="wp-inline-create-button-row">
<tr ng-if="!$ctrl.isHidden" class="wp-inline-create-button-row hide-when-print">
<td colspan="{{ $ctrl.colspan }}" class="-no-highlighting">
<div
class="wp-inline-create-button"

Loading…
Cancel
Save