correctly type button

10 years ago · ff7a9cd659
parent 2d5d629550
commit ff7a9cd659
2 changed files with 2 additions and 0 deletions
--- a/frontend/app/ui_components/wiki-toolbar-directive.js
+++ b/frontend/app/ui_components/wiki-toolbar-directive.js
@ -32,6 +32,7 @@ module.exports = function() {
                          'menubar=no, status=no, scrollbars=yes&quot;); return false;',
      HELP_LINK_HTML = jQuery('<button title="' + I18n.t('js.inplace.link_formatting_help') + '"' +
                              ' class="jstb_help icon icon-help" ' +
+                              ' type="button" ' +
                              'onclick="' + HELP_LINK_ONCLICK + '">' +
                              '<span class="hidden-for-sighted">' +
                              I18n.t('js.inplace.link_formatting_help') +
--- a/lib/redmine/wiki_formatting/textile/helper.rb
+++ b/lib/redmine/wiki_formatting/textile/helper.rb
@ -38,6 +38,7 @@ module Redmine
                      "height=640, menubar=no, status=no, scrollbars=yes\"); return false;"
          help_button = content_tag :button,
                                    '',
+                                    type: 'button',
                                    class: 'jstb_help icon icon-help',
                                    onclick: open_help,
                                    title: l(:setting_text_formatting) do