324 Commits (dev)

Author	SHA1	Message	Date
Pavel Balashou	70de637295	[#43692] Part 2. Modify API to be able to handle file_links without a container. (#11992) ... * [#43692] Modify API to be able to handle file_links without a container. https://community.openproject.org/work_packages/43692 * Set work_packages--file_links association to be polymorphic. - Replace the usages of Storages::FileLinks.visible, because eager_loading of polymorphic associations is not easy. - Remove WorkPackages::CreateService#replace_attachments method. It does actual saving of a work_package. Replaced the call with actual code.	2 years ago
Christophe Bliard	10085736da	refactor: Rename and generalize #accessor_name as #attribute_name ... Also extract #attribute_getter and #attribute_setter when using #attribute_name in the context of calling the getter/setter methods.	2 years ago
Dombi Attila	685b8226de	[#45339] Modify the backend to support saving the non working days ... https://community.openproject.org/work_packages/45339	2 years ago
Christophe Bliard	3167f462fe	Refactor: simplify code	2 years ago
Christophe Bliard	9de8b17e26	Check archive_project permission when archiving through API ... - If only project.active is changed, only archive_project permission is needed, on the project and its descendants; - If anything else than project.active is changed, only edit_project permission is needed; - If both project.active and another field are changed, both archive_project and edit_project are needed.	2 years ago
Christophe Bliard	164daa48f8	Fix archive project through API ... The `Projects::UpdateService` used by the API endpoint was duplicating the checks done in `ArchiveContract` and `UnarchiveContract`. Now the relevant contract is called and used instead. As the duplication has been removed, the class `Projects::Archiver` is not needed anymore and its methods have been inlined. Also, as project is not active when being archived, all permission checks would fail because no action is allowed on archived projects. So the condition was relaxed a little to also allow permission check on projects being archived.	2 years ago
Christophe Bliard	5cf125a6f9	[#3897] Add specific permission archive_project ... See https://community.openproject.org/work_packages/3897 This permission is automatically added to project admin role. A project can be archived by a user if this user has the archive_project permission on the project and all its descendants.	2 years ago
Christophe Bliard	fd352c31ac	Refactor	2 years ago
Christophe Bliard	21a696ef9b	Update copyright information for 2023	2 years ago
Eric Schubert	33fadd2da3	[#44841] added requests specs ... - amended API specifications - delete old oauth client credentials when reposting	2 years ago
Dombi Attila	1691077d44	[Fix] Create rake task to fix missing notification settings (#11362) ... * Create rake task to fix missing notification settings * fixup! Create rake task to fix missing notification settings * Test whether users being created without settings	2 years ago
ulferts	2321701f7f	move property name conversion for writability check ... This way, the conversion occurs where the name is determined and representation logic does not mix with business logic.	2 years ago
Dombi Attila	f02c07a57f	[#45032] Custom fields editing looks like it's possible in read-only status (although changes are not saved and there is no error message) ... https://community.openproject.org/work_packages/45032	2 years ago
Dombi Attila	b28c088a54	[#44673] Editing custom fields on work packages in readonly status possible via bulk edit ... https://community.openproject.org/work_packages/44673	2 years ago
Dombi Attila	d349c30d7e	[#44414] Add the Enterprise Edition guard on date alerts settings ... https://community.openproject.org/work_packages/44414	2 years ago
Dmitrii	57eb0a930e	make everyday for overdue as P1D	2 years ago
Dmitrii	ce8a4e973b	fix failing specs and do not allow 1 day for overdue	2 years ago
ulferts	ae2bebb6e2	mimick id on non existent model ... That way change detection can pick up setting an association with such a value	2 years ago
Christophe Bliard	75f272504a	Change NotificationSettings duration units to days ... Days are easier to work with than hours when building SQL requests. Also change "everyday" value for overdue from 0 to 1, for consistency with the other values.	2 years ago
Dombi Attila	bbcfcf26be	[#43673] Include date alert into NotificationSetting api specs ... https://community.openproject.org/work_packages/43673	2 years ago
Dmitrii	00a0d42ed1	[#43673] fixes after comments	2 years ago
Dmitrii	ac1d98ea03	[#43673] move validation to contract	2 years ago
ulferts	81d52906d7	bail on altering working days before last change is processed	2 years ago
Dombi Attila	bb107a7223	[#43819] Basic administration for non working days (excluding danger zone) ... https://community.openproject.org/work_packages/43819 WorkingDays as Setting	2 years ago
ulferts	7be7ede6b5	restrict writability of ignore_non_working_days if parent	2 years ago
Oliver Günther	a6b7bee822	Cleanup code for duration / non working days (#11222) ... * Remove work_packages_duration_field_active feature flag Duration is now globally active for 12.3.0. * Remove `ignore_non_working_days: false` in tests Not needed anymore as it is now the default value. Keep it where the test explicitly refers to it, for clarity. Co-authored-by: Christophe Bliard <c.bliard@openproject.com>	2 years ago
ulferts	17d9388bb8	robustness upon an invalid wp parent_id	2 years ago
Christophe Bliard	0cf2ffedb9	Forbid having only 2 duration/dates fields set ... As per OP#31992, for start date, finish date, and duration, it is possible to have no attributes, only one attribute, or all three. It is not possible to have just two (since the third will be derived from the other two).	2 years ago
Christophe Bliard	1f69dd3a9e	Correctly compute duration in work package contract	2 years ago
bsatarnejad	3c4a40fa69	set the format of error messages for assignee attribute	2 years ago
bsatarnejad	7044ddb842	remove the attribute name and colon to make it consistant with other error texts	2 years ago
bsatarnejad	6d6174b3da	align arguments	2 years ago
bsatarnejad	e4e25fb815	add a colon after attribute name	2 years ago
Christophe Bliard	38e65b8cc0	[#43223] Forbid to set due date before soonest_start ... https://community.openproject.org/work_packages/43223 Before, only start_date was checked to be after soonest_start. Now both are checked in case start_date is unset.	2 years ago
Oliver Günther	8fa841c9c2	Prevent uncontainered attachments being added due to public permissions ... If there is an anonymous role to view_project, there are two attachable instances (Grids::MyPage, Projects::Export) that allow anonymous attaching of uncontainered attachments. This has the consequence that anon users can upload uncontainered attachments when this role is set. This PR fixes this by preventing these classes from getting uncontainered attachments, as they are only necessary for resources created through the frontend (projects, work packages).	2 years ago
Wieland Lindenthal	38ef24a9cf	Automatically add OAuth application with storages	2 years ago
Dombi Attila	8124a3705a	Move duration for milestone validations to the base contract	2 years ago
Dombi Attila	92a7f1ffda	Rename :writeable to :writable	2 years ago
ulferts	122b56332e	let writability of duration and ignore_non_working_days be govered by feature flag	3 years ago
ulferts	a82fa93a70	add ignore flag to work package contracts but hide from form configuration	3 years ago
ulferts	8868186415	skip validating automatically calculated values	3 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	3 years ago
Christophe Bliard	90a8329c3a	fix i18n keys for duration	3 years ago
ulferts	f5fc2b9c59	ensure duration to be integer	3 years ago
Frank Bergmann	c84980b257	Improve flow and guidance for setting up a file storage	3 years ago
ulferts	a4659970b9	disable duration validation on nil	3 years ago
ulferts	b1d83fb119	linting hash value and complexity	3 years ago
ulferts	89eae6714c	include duration in contract	3 years ago
Christophe Bliard	dd427e68cb	remove useless Authorization::UserAllowedService instantiations	3 years ago
Christophe Bliard	8da459140e	refactor: expand options argument of allowed_to calls ... Clean Authorization::UserAllowedService methods to remove global and options parameters when they are not used use allowed_to_globally? where possible	3 years ago