50 Commits (dev)

Author	SHA1	Message	Date
Christophe Bliard	10085736da	refactor: Rename and generalize #accessor_name as #attribute_name ... Also extract #attribute_getter and #attribute_setter when using #attribute_name in the context of calling the getter/setter methods.	2 years ago
Oliver Günther	39c7e8e51f	Don't use implicitly build custom_values for change detection	2 years ago
Oliver Günther	10a13e326b	Add appsignal tags to application job	2 years ago
Oliver Günther	884fa65c1e	Remove log_delegator namespace ... We instead should retain the namespace currently set	2 years ago
Christophe Bliard	21a696ef9b	Update copyright information for 2023	2 years ago
Andreas Pfohl	125935d3d0	[#44856] removed temporary information for CSP	2 years ago
Eric Schubert	7c10cc07e7	[#44856] enabled file upload ... - with hardcoded upload information - no file link creation attached	2 years ago
Oliver Günther	7499923302	Don't pluralize, but localize day count ... https://community.openproject.org/wp/45391	2 years ago
Christophe Bliard	d5a3b0019f	Remove usage of journals.activity_type ... In https://github.com/opf/openproject/pull/11741#discussion_r1039350659 Jens suggested to remove `activity_type` and rely on `journalized_type` instead as there is a 1:1 relationship between them. `activity_type` was introduced to differentiate between different types of activity for the same journalized model (e.g. creation vs editing), but this field is not used in practice.	2 years ago
Dombi Attila	93b7923f28	Update the acts_as_customizable plugin custom field value caching mechanism to use cache keys	2 years ago
Dombi Attila	b28c088a54	[#44673] Editing custom fields on work packages in readonly status possible via bulk edit ... https://community.openproject.org/work_packages/44673	2 years ago
Christophe Bliard	05721200cd	Remove dead code ... [skip ci]	2 years ago
Christophe Bliard	2f87928f01	Add cop to detect do..end block with Capybara matcher	2 years ago
Christophe Bliard	9f55d89aa3	Reduce loaded locales in tests to boot faster ... Loading all translation files for all locales can take up to 2 or 3 seconds. This is most noticeable when running a small set of tests where the loading lag makes the output halt during 2 seconds. Only :en is loaded at first, which greatly reduces the boot up time. Then additional locales are loaded each time `I18n.locale=` is called (or also some `Redmine::I18n` methods). It is possible to disable this lazy loading of locales by setting the environment variable TEST_NO_I18N_LAZY_LOADING.	2 years ago
ulferts	b6364201a5	again use the rails env to determine the default value of feature flags	2 years ago
Eric Schubert	722a964164	[chore] added feature flag for linking files	2 years ago
luz paz	c757e6f60e	Fix various typos ... Found via `codespell -q 3 -S ./.git,./config/locales,./modules/xls_export/config/locales,./modules/job_status/config/locales,./modules/two_factor_authentication/config/locales,./modules/backlogs/config/locales/crowdin,./**/config/locales,./frontend/src/vendor -L ba,inflight,nd,parms,pullrequest,pullrequests,sur,varius`	2 years ago
ulferts	410522947e	increase feature flag robustness	2 years ago
ulferts	2d5efb9533	simplify setting up feature flags ... Defined feature flags are both set up to be picked up from ENV and configuration.yml as well as being listed in /api/v3/configuration	2 years ago
ulferts	0a63b01039	reuse superclasses for copy service	2 years ago
Oliver Günther	a6b7bee822	Cleanup code for duration / non working days (#11222) ... * Remove work_packages_duration_field_active feature flag Duration is now globally active for 12.3.0. * Remove `ignore_non_working_days: false` in tests Not needed anymore as it is now the default value. Keep it where the test explicitly refers to it, for clarity. Co-authored-by: Christophe Bliard <c.bliard@openproject.com>	2 years ago
Oliver Günther	2b05d50b98	Allow settings defaults to be lambdas even if format present	2 years ago
Oliver Günther	4d097daceb	Replace separate https and force_ssl flags with https + hsts ... By default, https will be enabled in production in OpenProject 12.2. Right now, a separate flag exists called rails_force_ssl that needs to be controlled separately, but the two settings are intermingled. This PR fixes this so that: HTTPS setting controls the secure cookies and generating links with https throughout the application HSTS setting is only active by default when HTTPS is enabled and controls the HSTS headers as well as the HTTP->HTTPS request upgrade for transport-security.	2 years ago
Dombi Attila	d32be7fc0a	Improvement #1	2 years ago
Oliver Günther	8fa841c9c2	Prevent uncontainered attachments being added due to public permissions ... If there is an anonymous role to view_project, there are two attachable instances (Grids::MyPage, Projects::Export) that allow anonymous attaching of uncontainered attachments. This has the consequence that anon users can upload uncontainered attachments when this role is set. This PR fixes this by preventing these classes from getting uncontainered attachments, as they are only necessary for resources created through the frontend (projects, work packages).	2 years ago
Dombi Attila	8e8a6989be	Hide duration form journal when the flag is disabled	2 years ago
Dombi Attila	9ee0dfdcf5	Add journal messages for work package duration changes	2 years ago
Oliver Günther	99ce4f9ad2	Set up cache store early in application.rb	2 years ago
Christophe Bliard	5596871a09	Add cop to enforce usage of ServiceResult factory methods ... The cop is named `OpenProject/UseServiceResultFactoryMethods`. It will check for ServiceResult.new call and check if it can be replaced by `ServiceResult.success` or `ServiceResult.failure`. These factory methods make the code easier to understand by being shorter and more explicit. This is the first cop I write, so there is probably room for improvement.	3 years ago
ulferts	1e6a96ba7a	only save, and for that load, custom field values if changes have been made	3 years ago
Oliver Günther	87cfded5e5	Add AppSignal to LogDelegator for exception handling	3 years ago
Oliver Günther	7a5efe1e05	Add request tagging to rails and grape	3 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	3 years ago
Oliver Günther	9e3c51299a	Remove Setting.protocol in favor of static config	3 years ago
Oliver Günther	22b7849520	Remove legacy mailer configuration and move into settings ... Split from "Remove Setting.protocol in favor of static config" Restore cache store setup	3 years ago
Oliver Günther	553b0b4b19	Move configuration to static lib	3 years ago
ulferts	13bae7fa57	turn op/database static	3 years ago
ulferts	49471bbd66	static op/authentication	3 years ago
ulferts	3492d08fdd	turn OpenProject::Notifications static	3 years ago
ulferts	b5c76e3027	introduce lib_static	3 years ago