20 Commits (dev)

Author	SHA1	Message	Date
Christophe Bliard	10085736da	refactor: Rename and generalize #accessor_name as #attribute_name ... Also extract #attribute_getter and #attribute_setter when using #attribute_name in the context of calling the getter/setter methods.	2 years ago
Oliver Günther	39c7e8e51f	Don't use implicitly build custom_values for change detection	2 years ago
Christophe Bliard	21a696ef9b	Update copyright information for 2023	2 years ago
Oliver Günther	7499923302	Don't pluralize, but localize day count ... https://community.openproject.org/wp/45391	2 years ago
Christophe Bliard	d5a3b0019f	Remove usage of journals.activity_type ... In https://github.com/opf/openproject/pull/11741#discussion_r1039350659 Jens suggested to remove `activity_type` and rely on `journalized_type` instead as there is a 1:1 relationship between them. `activity_type` was introduced to differentiate between different types of activity for the same journalized model (e.g. creation vs editing), but this field is not used in practice.	2 years ago
Dombi Attila	93b7923f28	Update the acts_as_customizable plugin custom field value caching mechanism to use cache keys	2 years ago
Dombi Attila	b28c088a54	[#44673] Editing custom fields on work packages in readonly status possible via bulk edit ... https://community.openproject.org/work_packages/44673	2 years ago
luz paz	c757e6f60e	Fix various typos ... Found via `codespell -q 3 -S ./.git,./config/locales,./modules/xls_export/config/locales,./modules/job_status/config/locales,./modules/two_factor_authentication/config/locales,./modules/backlogs/config/locales/crowdin,./**/config/locales,./frontend/src/vendor -L ba,inflight,nd,parms,pullrequest,pullrequests,sur,varius`	2 years ago
ulferts	0a63b01039	reuse superclasses for copy service	2 years ago
Oliver Günther	a6b7bee822	Cleanup code for duration / non working days (#11222) ... * Remove work_packages_duration_field_active feature flag Duration is now globally active for 12.3.0. * Remove `ignore_non_working_days: false` in tests Not needed anymore as it is now the default value. Keep it where the test explicitly refers to it, for clarity. Co-authored-by: Christophe Bliard <c.bliard@openproject.com>	2 years ago
Oliver Günther	8fa841c9c2	Prevent uncontainered attachments being added due to public permissions ... If there is an anonymous role to view_project, there are two attachable instances (Grids::MyPage, Projects::Export) that allow anonymous attaching of uncontainered attachments. This has the consequence that anon users can upload uncontainered attachments when this role is set. This PR fixes this by preventing these classes from getting uncontainered attachments, as they are only necessary for resources created through the frontend (projects, work packages).	2 years ago
Dombi Attila	8e8a6989be	Hide duration form journal when the flag is disabled	2 years ago
Dombi Attila	9ee0dfdcf5	Add journal messages for work package duration changes	2 years ago
ulferts	1e6a96ba7a	only save, and for that load, custom field values if changes have been made	3 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	3 years ago
ulferts	b5c76e3027	introduce lib_static	3 years ago