8879 Commits (dev)

Author	SHA1	Message	Date
Pavel Balashou	70de637295	[#43692] Part 2. Modify API to be able to handle file_links without a container. (#11992) ... * [#43692] Modify API to be able to handle file_links without a container. https://community.openproject.org/work_packages/43692 * Set work_packages--file_links association to be polymorphic. - Replace the usages of Storages::FileLinks.visible, because eager_loading of polymorphic associations is not easy. - Remove WorkPackages::CreateService#replace_attachments method. It does actual saving of a work_package. Replaced the call with actual code.	2 years ago
Oliver Günther	a452c05f61	Ensure we're navigating to the date we're testing ... Today, the start of the week monday is not shown in calendar	2 years ago
bsatarnejad	20756c93ac	update timeline tetst to set dates with an instance-wide holiday	2 years ago
bsatarnejad	f6695495e4	add a test to check if NWDs are correctly highlighted on gantt chart	2 years ago
Oliver Günther	bd4c160d6f	Fix manual scheduling toggle on parent	2 years ago
Andreas Pfohl	200e170196	[#45875] Change API response of storage files endpoint ... https://community.openproject.org/work_packages/45875	2 years ago
Oliver Günther	efd3bc200f	Add non-working days to datepicker ... check if datepicker instance is defined then call its methods	2 years ago
Christophe Bliard	d76609dd6a	Fix rubocop warning	2 years ago
Dombi Attila	b3f3ed8f43	refactor: Extract customField1 json format into the CustomField#attribute_name method	2 years ago
Christophe Bliard	f88889489f	Remove deprecated Setting::CallbackHelper (#11965)	2 years ago
Oliver Günther	f15debf637	Set immediate notification mail to true by default	2 years ago
Christophe Bliard	e5cebf0e47	Make test faster by doing more in one go	2 years ago
Christophe Bliard	36a2e1de9d	[#45084] Check permission instead of module activation	2 years ago
Christophe Bliard	6d5f9e36fc	Add 'Project details activity' menu entry ... Added to the Project details widget on project overview page. Displaying the menu entry conditionally depending on the activity module being activated is done through a public permission. Capabilities endpoint has been extended to include actions from public permissions.	2 years ago
Christophe Bliard	3cd78260c0	refactor: Make spec example names more descriptive	2 years ago
Christophe Bliard	f9fb280045	refactor: Make test faster ... 5.3 secs => 2.1 secs	2 years ago
Christophe Bliard	8785caa17b	Add failing acceptance test for Project details activity	2 years ago
Mir Bhatia	6d7413fc13	Add link to project activity page when clicking on menu item	2 years ago
Christophe Bliard	d51d775588	Add 'Project activity' menu item in projects list	2 years ago
Christophe Bliard	ab39e8e928	Add acceptance tests	2 years ago
Christophe Bliard	745dafc424	Fix rubocop linting errors	2 years ago
Christophe Bliard	ac27dba493	refactor: Extract CustomField#column_name for "cf_#{id}"	2 years ago
Christophe Bliard	10085736da	refactor: Rename and generalize #accessor_name as #attribute_name ... Also extract #attribute_getter and #attribute_setter when using #attribute_name in the context of calling the getter/setter methods.	2 years ago
Christophe Bliard	c2b9ccea0b	Prevent retry error when example metadata is missing	2 years ago
Christophe Bliard	85b3258a29	Autocorrect with some rubocop cops ... RSpec/Rails/InferredSpecType and Style/RedundantConstantBase rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec	2 years ago
Dombi Attila	f4d44f9248	Remove job argument as it has a default value	2 years ago
Dombi Attila	b0c02dced7	Update the Settings::WorkingDaysUpdateService to schedule the WorkPackages::ApplyWorkingDaysChangeJob on a successful settings change	2 years ago
Dombi Attila	15ad45b17a	Remove the Settings::Definition on_change callback as it is not neccessary anymore	2 years ago
Dombi Attila	11a31cf7ed	Update WorkPackages::ApplyWorkingDaysChangeJob adding specs mixed with non-working days and non-working weekday settings	2 years ago
Dombi Attila	c8da1e3328	Update WorkPackages::ApplyWorkingDaysChangeJob adding the previous_non_working_days and specs	2 years ago
Dombi Attila	210da2a807	Update WorkingDaysUpdateService spec to verify the delete/recreate scenario works correctly	2 years ago
Dombi Attila	2e12903bdc	[#45473] Update the WorkPackages::ApplyWorkingDaysChangeJob to take NonWorkingDays into account. ... https://community.openproject.org/work_packages/45473	2 years ago
Oliver Günther	3dd27d2e48	Get the correct field container type for attribute macros ... The display field macro defaulted to the table style displaying, which truncates some things such as multi value custom fields. By moving that logic to the fields service, not the manual display field renderer, we can reuse the distinctions and ensure the custom values are not truncated. https://community.openproject.org/wp/45538	2 years ago
Dombi Attila	29bebde81f	[#45057] Week calculations on the gannt chart are incorrect in tests ... https://community.openproject.org/work_packages/45057	2 years ago
Oliver Günther	39c7e8e51f	Don't use implicitly build custom_values for change detection	2 years ago
Oliver Günther	8d2bd8fdaf	Remove footer_content setting ... It is used in a helper, but that is no longer employed anywhere	2 years ago
Oliver Günther	f1d590fc6e	[45742] Fix missing injection in project time entries ... https://community.openproject.com/wp/45742	2 years ago
Dombi Attila	ccc1cb8700	[#45057] Week calculations on the gannt chart are incorrect in tests ... https://community.openproject.org/work_packages/45057	2 years ago
ulferts	fb78d2861a	limiting users eligible for date alerts	2 years ago
ulferts	85bdcaf9c3	separate date alert creation for individual users	2 years ago
Eric Schubert	2eb54e073f	[#43577] Fix drag and drop by counting drag over and leave (#11896) ... * [#43577] Fix drag and drop by counting drag over and leave - https://community.openproject.org/work_packages/43577 - replace action button text for attaching files - refactored drag and drop behaviour - on any global dragenter increase a counter - on any global dragleave decrease counter - if counter is 0 -> no global dragging is happening (mouse was moved out of window) - this way, we are independent from the order in which the DragEvents are fired by the browser (bigger differences between Firefox and Chrome) Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	2 years ago
Oliver Günther	4062356e45	Remove not only nil, but also blank values ... Otherwise, we will overwrite possibly existing values	2 years ago
Christophe Bliard	0084d99851	Faster spec	2 years ago
Oliver Günther	62d9959251	Allow registered users to become activated	2 years ago
Oliver Günther	d573706de1	Bypass self registration for omniauth users ... https://community.openproject.org/wp/42390	2 years ago
Dombi Attila	685b8226de	[#45339] Modify the backend to support saving the non working days ... https://community.openproject.org/work_packages/45339	2 years ago
Christophe Bliard	9de8b17e26	Check archive_project permission when archiving through API ... - If only project.active is changed, only archive_project permission is needed, on the project and its descendants; - If anything else than project.active is changed, only edit_project permission is needed; - If both project.active and another field are changed, both archive_project and edit_project are needed.	2 years ago
Christophe Bliard	164daa48f8	Fix archive project through API ... The `Projects::UpdateService` used by the API endpoint was duplicating the checks done in `ArchiveContract` and `UnarchiveContract`. Now the relevant contract is called and used instead. As the duplication has been removed, the class `Projects::Archiver` is not needed anymore and its methods have been inlined. Also, as project is not active when being archived, all permission checks would fail because no action is allowed on archived projects. So the condition was relaxed a little to also allow permission check on projects being archived.	2 years ago
Christophe Bliard	5cf125a6f9	[#3897] Add specific permission archive_project ... See https://community.openproject.org/work_packages/3897 This permission is automatically added to project admin role. A project can be archived by a user if this user has the archive_project permission on the project and all its descendants.	2 years ago
Christophe Bliard	fd352c31ac	Refactor	2 years ago