314 Commits (dev)

Author	SHA1	Message	Date
Christophe Bliard	85b3258a29	Autocorrect with some rubocop cops ... RSpec/Rails/InferredSpecType and Style/RedundantConstantBase rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec	2 years ago
Christophe Bliard	21a696ef9b	Update copyright information for 2023	2 years ago
Christophe Bliard	e3f4a6b582	Include Capybara::RSpecMatchers where DSL is included ... This is needed to make these two statements equivalent: expect(page).not_to have_xpath('a') expect(page).to have_no_xpath('a') So that the both matchers return early on element absence, instead of timing out. This is the continuation of e85b47979a.	2 years ago
Henriette Darge	13f8712a98	Fix feature tests for new global project selection	2 years ago
ulferts	5dbb3de9d8	rubocop autofix for cops added in 2.15	3 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	3 years ago
Oliver Günther	819f3d83ba	Remove erb suffix	3 years ago
Christophe Bliard	73a8421c42	make nested hash env names work with env_alias for Setting	3 years ago
ulferts	0b5575aa64	harmonize settings & configuration ... They are for now still available as separate entities but that is more due to existing references to them both. Under the hood, they now depend on the same structure `Settings::Definition` which just as well could have been named `Configuration::Definition`, that defines: * the name * the default value * the type (which might be deferred from the default value) * the array of allowed values Both Setting and Configuration can now be overwritten using the same mechanisms: * Default value * Database value * configuration.yml (settings.yml is removed) * ENV vars	3 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Christophe Bliard	47a297daae	Fix argument alignment since f08bea3467 (#10129) ... * Fix argument alignment since f08bea3467 The FactoryBot.* prefix has been removed in f08bea3467. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it. * do not fix alignments for modules/*/spec yet hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago
ulferts	a4f7dd4a11	move general to nested settings	3 years ago
ulferts	48006b7bb3	rename generic to general settings	3 years ago
ulferts	2d6eec0874	Merge remote-tracking branch 'origin/release/11.4' into dev	3 years ago
Markus Kahl	e562d612b7	ee token reprieve support	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	2896afe6c4	Assign project identifier in backend (#9196) ... * Introduce localizable slug url Stringex currently works only with english strings for wiki. But that default is actually confusing. Instead, add an explicit localizable helper that receives the locale and sets the stringex backend locale temporarily * Generate a default identifier in the backend * Remove JS based identifier updating * Remove identifier attribute * Add button to change identifier * Adapt tests to changed identifier * Linting * Fix invalid selector	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012) ... * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973) ... * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987) ... AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	26295af6bd	Chore/replace activemodel mocks (#8892) ... * replace stub_model calls * replace mock_model * remove rspec-activemodel-mocks dependency	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798) ... * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	154afc3c7f	Restore custom style rendering with css variables ... Uses the css variables to set the default values instead of using the previously ruby-defined variables	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	399e8c3ed9	rename according to zeitwerk	5 years ago
Henriette Dinger	3ebe7f4d52	Add missing breadcrumbs and remove unnecessary ones	5 years ago
Henriette Dinger	1e3b5adc61	Open colors field per default when a custom theme is selected	5 years ago
Henriette Dinger	f067c4702e	Show placeholder "(Custom)" in the theme selection field when colors have been changed manually	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	cbc530ca9d	Move project_settings_path to ApplicationHelper to be globally available and start adapting tests to new structure	5 years ago
Markus Kahl	0a3eb86bd8	show correct number of active users ... Builtin users must be not counted. Use method from Enterprise module so we only have this logic in one place.	5 years ago
ulferts	5869966f12	relay available_custom_fields call to cacheable class method ... That way, we avoid n+1 queries for the available custom field especially in scenarios like schemas and api collections where a set of models is queried for their custom fields	5 years ago
Markus Kahl	c635392865	render consent info in correct locale	5 years ago
Oliver Günther	f5db1e39bd	[30591] Use username for login form ... https://community.openproject.com/wp/30591	5 years ago
ulferts	71ffcc65de	allow domain in touch icon spec	5 years ago
ulferts	04daaee177	allow domain in touch icon spec	5 years ago
ulferts	9cadd34be7	remove/replace instances of rspec stub	5 years ago
Markus Kahl	3a1ee72b05	do not serve dynamic content assets (e.g. highlighting) through asset host	5 years ago
Henriette Dinger	8a620b8852	Move admin_controller spec from legacy to spec && rename admin index page to "index" && adapt view spec	5 years ago
ulferts	13e0707f6a	replace rabl template	6 years ago
Oliver Günther	0d5f50395e	[29253] Render error message in production on pending migrations ... Creates a new warning bar (previously top-shelf item) that renders a warning when migrations are pending. These did raise exceptions before in production and would result in users running in internal errors due to pending migration on some actions on the instance. https://community.openproject.com/wp/29253	6 years ago
Jens Ulferts	fdaa449236	avoid initial search on work package tab	6 years ago
Wieland Lindenthal	ec5aa78b6e	resolve conflict	6 years ago
Henriette Dinger	99f468fe33	Make search with subprojects default	6 years ago
Jens Ulferts	1b0a79c911	spec set_attributes_service	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago