openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	0a84a0b671	[36296] Add PlaceholderUsers API (#9033 ) * Add PlaceholderUsers API * Fix remarks in apib * Add deduce_element_decorator to collection * Remove unnecessary path	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867 )	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	4dd8e433b4	Fix/bump gems (#8770 ) * bump aws-sdk-core * bump danger * bump parser * bump grape - stream related header setting bug has been fixed * reapply cache headers on stream as grape insists on niling them * bump aws-partitions * bump regexp_parser * bump rubocop * bump webmock	4 years ago
Oliver Günther	76823ca581	[34446] Fix direct upload with backend-generated resources https://community.openproject.com/wp/34446	4 years ago
Markus Kahl	a456537fe2	added missing prepare attachment endpoint for attribute help texts	4 years ago
Markus Kahl	b85380f068	handle pending attachment validation errors	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275 ) * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
Oliver Günther	1255aff56a	[32825] Cache external URLs for at max 604799 seconds (#8268 ) Caching the redirect causes AWS links for more than that causes the links to expire if they are still cached by the browser https://community.openproject.com/wp/32825	5 years ago
ulferts	0b6d82c632	cache non avatar attachments for a year	5 years ago
ulferts	ffc131695a	use services/contracts for forum messages	5 years ago
ulferts	a895767619	have a delete service for attachments	5 years ago
ulferts	34ac8c9621	employ advisory lock for journal creation on attachment uploading	5 years ago
ulferts	056b6f45af	attachment create service more in line with general layout	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	3adce4d7c8	[31580] Stringify file name https://community.openproject.com/wp/31580	5 years ago
ulferts	c3c197bc24	attachments for custom_text widgets on dashboard	5 years ago
ulferts	3be6e61b85	turn descriptions cacheable	5 years ago
Oliver Günther	c775dc8031	[29942] Better error messages for permission failures [ci skip] https://community.openproject.com/wp/29942	6 years ago
Oliver Günther	1a16c039a2	Add an avatar endpoint to avoid loading user API [ci skip]	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299 ) Feature/versions api update [ci skip]	6 years ago
Oliver Günther	a290203bdd	Fix attachment error message [ci skip]	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	352099089c	Prepare for core integration	6 years ago
Jens Ulferts	824aca3146	do not cause new error on error handling If container is nil, ruby should not fail because of it when logging the error	6 years ago
Oliver Günther	3d936d99dd	[28431] Don't render attachment with downloadLocation The downloadLocation may contain a temporary URL as it is with the case of AWS. https://community.openproject.com/wp/28431	6 years ago
Oliver Günther	223284c401	[28171] Output claimed attachments on wiki representer https://community.openproject.com/wp/28171	6 years ago
Jens Ulferts	0d22112e0e	replace rails based attachment forms and lists completely	6 years ago
Jens Ulferts	7f740a8178	extend to posts and plugins	6 years ago
Jens Ulferts	146e358b50	enable uploading attachments for budgets	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Jens Ulferts	312dbba5a1	fix wrong method name for external attachments	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	b3b1f7d9a3	add documents resource (with attachments) to api	7 years ago
Jens Ulferts	5dae0ef4d5	add endpoint for unattached attachments	7 years ago
Jens Ulferts	6a8a1eb495	add download endpoint to attachment resource	7 years ago
Jens Ulferts	441735fb4f	extend attachments api to board posts	7 years ago
Jens Ulferts	9b2458c23c	extend attachments api to wiki_pages	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	e7de9169f1	Add internal error with message to Fog uploading failures [ci skip]	7 years ago
Oliver Günther	ac389b869d	Fix other request specs by adding json header	7 years ago
Oliver Günther	4d0bad7efc	Allow endpoints to override content types (attachments!)	7 years ago
Oliver Günther	9937307c7c	[25968] Use OpenStruct instead non-required hashie (#5794 ) https://community.openproject.com/wp/25968 [ci skip]	7 years ago

1 2

99 Commits (00095af8621d5dd3b5aabd9ed1860bd24c7ebebe)