2 Commits (01b6d7bb677aa657e634b80de36560b792ad4775)

Author	SHA1	Message	Date
Oliver Günther	38ecb6b28c	[32486] Use error response for unauthenticated instead of warden ... Instead of warden responding with 401 "unauthorized", use our own error response that correctly sets the `WWWW-Authenticat` header. We tripped into the default 401 error that does not output any headers if we're not returning any users. This was caused by another issue: The `session` object may be present, even though no session id exists. Checking `session&.id` instead always yields the anonymous user. This will ensure consumers of APIV3 to always get a JSON / HAL response as well. https://community.openproject.com/wp/32486	5 years ago
ulferts	c88b0b85c4	return proper WWW Authenticate header on missing credentials (#6150) ... An anonymous_fallback is introduced and registered to be the last strategy for warden. That strategy will always apply and it will always return the anonymous user. The better way would be to only apply the strategy if login is not required. That way we would still be able to return a 403 when credentials are missing but would no longer need to have 401 handlers outside of warden. That duplicity caused the missing header in the first place. It would however require us to handle the realm in the strategy and by that increase the coupling between the strategy and the application. [ci skip]	7 years ago