openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	bbd10c8dfe	Review remarks	8 years ago
Oliver Günther	6bb684a531	[25534] Fix needless escaping with jquery-ui (#5649 ) The `_.escape` was used for the typehead that was since replaced by ui-autocompleter, which uses a text node to insert the label: https://github.com/jquery/jquery-ui/blob/master/ui/widgets/autocomplete.js#L568 Thus the escape is no longer necessary. https://community.openproject.com/projects/openproject/work_packages/25534/activity?query_id=930 [ci skip]	8 years ago
Oliver Günther	569369092d	Avoid setting the workPackageId to ignore clicks	8 years ago
Oliver Günther	8d14236fa9	Add better labels	8 years ago
Oliver Günther	f82f1ab915	Remove the loadingIndicator only after rendered was pushed	8 years ago
Oliver Günther	6a5a7af466	Add some happy debug outputs	8 years ago
Oliver Günther	831436191a	Only set scope to initialize table/timeline on initial loading	8 years ago
ulferts	16f0cace89	Fix/wp copy with cf (#5638 ) * fix copying cf values on wp copy * use angular copy form if only one wp copied [ci skip]	8 years ago
Oliver Günther	9bf3f4d22d	Simplify initialization of query state	8 years ago
Oliver Günther	fb2160093d	Fix timeline builder in inline-create row	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637 ) * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
ulferts	6a1302a5c3	reset hierarchy mode compare value on query change (#5641 ) [ci skip]	8 years ago
ulferts	df99cf15c3	fix wp subject display in ff (#5640 ) * fix wp subject display in ff The subject used to be hidden because the width calculation was off. Instead of tempering with the width calculcation, I decided to use float instead so that we end up with fewer objects having their width calculated in js * fix being able to double click on hierarchy area * add comments on pointer-events [ci skip]	8 years ago
Oliver Günther	04822ba680	Render rows in timeline pass regardless of WP association	8 years ago
Oliver Günther	568518d6a3	Move QueryColumn interface into its own class	8 years ago
Oliver Günther	7d62d846a2	Implement relation columns as secondary render pass	8 years ago
Oliver Günther	b7f8a74937	Introduce derived state for when table query states are ready	8 years ago
ulferts	0ab4c9aaec	set float values to null if empty string is passed (#5633 ) Used to be set to undefined which caused float cfs not being able to be set to blank [ci skip]	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614 ) * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
Wieland Lindenthal	84c3426934	Fix Nato positioning for Win Chrome	8 years ago
ulferts	08e49612e6	Fix/forums pagination (#5623 ) * restructure table pagination to use a controller * split up pagination directive There now is the table-pagination directive which is generic, taking input to communicate with its caller. This is used by the forum. The wp-table-directive is specific for the wp table and relies observers. [ci skip]	8 years ago
Oliver Günther	58c4facd82	[25433] Let the dropdown controller reposition the dropdown on changes (#5620 ) [ci skip]	8 years ago
Wieland Lindenthal	94a95bfd0c	Align and style back button like other toolbar buttons	8 years ago
Wieland Lindenthal	6f9991e35c	Remove boilerplate of back button and aligning it.	8 years ago
Wieland Lindenthal	0b91bab4ec	Fix bug #25461 . On iOS safari is not enabled. (#5621 ) [ci skip]	8 years ago
ulferts	3e6fdc8639	Fix/loading indicator on query change (#5617 ) * show loading indicator on query switch * prevent duplicate loading on query change We might want to look into moving the query checksum mgmt to the service layer to avoid scattering around calls to the checksum service but I refrain from doing that in a patch release * code prettification [ci skip]	8 years ago
Jens Ulferts	ff1a855ec7	handle non existing properties on inline create default values OP has filters defined for non work package properties. E.g. there is no subprojectId property on the work package resource. We need to ignore those filters when determining the default value on inline created work packages [ci skip]	8 years ago
ulferts	4221a1caf6	handle non existing properties on inline create default values (#5615 ) OP has filters defined for non work package properties. E.g. there is no subprojectId property on the work package resource. We need to ignore those filters when determining the default value on inline created work packages [ci skip]	8 years ago
Oliver Günther	ac46271c59	[25430] Set the width of the remaining space next to hierarchy indicator (#5613 ) This allows inline edit fields to retain the whole remaining size next to the hierarchy indicator. https://community.openproject.com/projects/openproject/work_packages/25430/activity?query_id=916 [ci skip]	8 years ago
Oliver Günther	bbda2c572d	Set the current hierarchy mode correctly in HierarchyTransformer (#5612 ) [ci skip]	8 years ago
Oliver Günther	c2d050e5ba	Fix comparison in table query services	8 years ago
Oliver Günther	f472da1753	Refactor URLParamsHelper into TS service	8 years ago
Oliver Günther	d179e754f2	Extend feature spec for zoom saving	8 years ago
Oliver Günther	d6b8b92037	Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query.	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
Oliver Günther	5b5326db4c	[25438] Fix only saving changed column positions (#5608 ) When changing only the positions of the default query columns, the query incorrectly checked only for the permutation of the default columns, not the actual order. Thus the columns were not actually saved in the query. Additionally, the `observeUntilChanged` incorrectly reflects previous values which causes the movement of a column twice to only result in a move by one position. As this was already suggested to remove in https://github.com/opf/openproject/pull/5597, let's resolve this together in this PR. [ci skip]	8 years ago
Wieland Lindenthal	2dd1f4fc6c	Fix/icon font and alignments (#5605 ) * Center icon font glyphs to harmonize with normal text. * Fix Nato positioning for Win Chrome * Not 100% happy but best X-browser fit approach positioning toolbar button icons and text * Position of project menu toggle icon. * Remove files I added accidentally [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603 ) The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
ulferts	483934e91b	refresh wp list after saving in full screen (#5600 ) [ci skip]	8 years ago
Oliver Günther	3c283ea512	Render table sums row in separate directive (#5595 ) * Render table sums row in separate directive * Fix JS error on setSelection It is not supported for [type=number] input fields. [ci skip]	8 years ago
Henriette Dinger	cb9ad7ba17	[25356] Icons in toolbar not aligned correctly (#5568 ) * Icon alignment in toolbar * Styling: newline after comma in CCS selector. No functional change. Just my personal preference. * Extra class for toolbar buttons that are icons only to make them a square. * Improve documentation for generating icon font [ci skip]	8 years ago
ulferts	96b20eae2a	fix old timeline legend width calculation (#5594 ) The calculation of an element's width was assigned to the wrong variable in #e04cc7e5794273103306a19ebbece0feb9cc192d [ci skip]	8 years ago
Oliver Günther	e877713b0a	[25404] Show timeline context items only when visible (#5590 ) Fixes a check for the timelineVisible state. [ci skip]	8 years ago
ulferts	1afcc57bd1	Fix/autocomplete multiple times (#5588 ) * $compile after changing dom via ajax response This enables the autocompleter implemented via an angular directive to work after a user has been added/removed from the group * reduce debounce on autocompleter [ci skip]	8 years ago
Oliver Günther	ebdad784cd	[25415] Add ancestor groups always when inserting extra rows (#5587 ) The hierarchy render pass uses ancestor groups to identify which rows belong to a certain hierarchy group for simple selector-based hiding/expanding of nested groups. For extra added rows, these groups were only added when the ancestor was not yet added to the list, causing them to not respond to collapsing the ancestor group. [ci skip]	8 years ago
Oliver Günther	bf9373120b	[25416] Refresh query on removed query_props with ID set When you're navigating to a query and override a filter, then move back to the query, the URL is changed, however the query is not being refreshed. This is due to the checksum being required to be non-null, even though it can possibly become null in the above case.	8 years ago
Oliver Günther	e20ef8fc71	[25411] Never render extra parents in timeline (#5584 ) Currently, hierarchy mode does NOT load extra parents that are not part of the results table (marked grey). As they are not loaded, the timeline doesn't have any information to draw them with. However, IF the workPackages state _had_ the value of the work package (e.g., because it's open in split view or it is part of a relation), it would still be rendered. This PR avoids rendering these rows at all times. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579 ) * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
Roman Roelofsen	d3606545f1	Improve drawing/positioning of milestones and relation lines (#5583 ) * Improve drawing/positioning of milestones and relation lines * Rebase on op/dev [ci skip]	8 years ago

... 3 4 5 6 7 ...

3798 Commits (05736115c00870b860ba3301105e4af67a32bc35)