52 Commits (05a037e9442a328fb5e2a2e339fea6b48a278d36)

Author	SHA1	Message	Date
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	cc45136701	refactor 404 auth error ... no separate method needed, let authorize_by_policy behave like well known auth methods (accepting a block)	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	0a73e6bac4	convert attribute names in queries API ... This should make the API more consistent again, accepting and producing the same attribute names on all endpoints	9 years ago
Jan Sandbrink	77f2b2a1cc	align the query representer with APIv3 ... - correctly use datatypes - link to linkable resources (instead of embedding their properties) - add specs	9 years ago
Jan Sandbrink	bc36704611	allow to get queries via APIv3 ... - one of those missing endpoints - adapted resource spec to be closer to other resource specs - specified error behaviour (missing permissions) -> change: not being allowed to see a query results in 404	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 ... Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	a9e9881c4f	style	10 years ago
Jan Sandbrink	b1ba33c75b	specify classes explicitly rather than implicitly ... This is a new try for the APIv3 classes, we either: - FULLY qualify a class and let the autoloader do the rest - don't qualify at all, but require the class explicitly Thus we do not (yet) completely give up on the rails autoloader, but we circumvent a fair amount of its magic (and problems). The hope is to eliminate the following problems in development mode: - NameErrors because the autoloader infers the wrong prefix - "object is not missing constant" errors occuring more rarely Let's see how that turns out to work...	10 years ago
Jan Sandbrink	f0863f9d53	allow to patch existing API endpoints	10 years ago
Jan Sandbrink	a72ea0d5af	more consequently use route_param ... this seems to be the GRAPE-iest way possible	10 years ago
Alexander Bach	d895b82db6	Some minor style fixes	10 years ago
Alexander Bach	bd1ffaee10	Fix authorize usage	10 years ago
Jens Ulferts	da588b812c	harmonize api decorators	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	746f7cce74	Use API V3's path helper	10 years ago
Hagen Schink	05ac818885	Remove superfluous API V3 models	10 years ago
Hagen Schink	6ec63bc9af	Update reform and its dependencies	10 years ago
Hagen Schink	154d2b0058	Improved starred status retrieval	10 years ago
Hagen Schink	db8bfba3af	Remove usage of reform from API V3	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	3c9d4df9de	Fix TODO syntax	10 years ago
Michael Frister	a6ebb6c4c4	API v3: Query: Fix empty name on starring ... When a query only has special characters as a name (which is not user- visible), normalization previously would remove all of them so the name could be empty. Using a random name fixes this.	10 years ago
Hagen Schink	e1418b5b29	Add TODO for replacing authorization in API v3 query endpoint	10 years ago
Jens Ulferts	f86b894e11	protects agains query manipulation via API	10 years ago
Alex Coles	1adc886ab6	Remove unnecessary Composition in QueryModel ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	47b57c576c	Use paths instead of URLs in Resource links ... See specification commit: 7f40188581 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	92e8384266	Add missing Copyright headers in lib (API) code ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0bf314f149	Specify a custom Formatter for hal+json ... This avoids having to explicitly call #to_json: https://github.com/intridea/grape#api-formats Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Marek Takac	3771625fd0	Updated API authorization method & activity resource spec	10 years ago
Jens Ulferts	a66ee51930	fixes links in representers (duplicate /)	10 years ago
Alex Coles	4a05c2debd	Hotfix for UrlHelpers with Grape in production ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Marek Takac	4043f265ee	Fixed paths to modules	10 years ago
Alex Coles	348420a03f	Revert "Feature/api work package embedded activities"	10 years ago
Alex Coles	d8697b0439	Fix noisy Reform accessor deprecation warnings ... [Reform] Deprecation WARNING: When using Composition, you may not call Form#query anymore to access the contained model. Please use Form#model[:query] and have a lovely day! See https://github.com/apotonick/reform/blob/master/CHANGES.md#101 Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Marek Takac	a240d79256	Fixed paths to modules	11 years ago
Marek Takac	33382223a7	Named params for API authorize method	11 years ago
Marek Takac	6eb061c01e	Simplified #star endpoint	11 years ago
Marek Takac	88b1c64b26	Allowed for admin to star / unstar any query	11 years ago
Marek Takac	940655312a	Refactor API authorize method	11 years ago
Marek Takac	83974f9556	Quick & dirty fix for queries starring and unstarring permissions	11 years ago
Marek Takac	97bfff11d0	Added some tests and handled permissions for #star and #unstar methods	11 years ago
Marek Takac	e7a3afb08f	Added 'is_starred' property to the query	11 years ago
Marek Takac	698d4dc7cc	Template for tests	11 years ago
Marek Takac	ecce489a9e	Created unstar action for queries	11 years ago
Marek Takac	a87b90ad81	Created queries representer	11 years ago
Marek Takac	49fa88258c	Created API query model	11 years ago
Marek Takac	6a9d565689	Created basic queries API endpoint & disabled experimental queries API endpoints	11 years ago