20 Commits (067ea409b2800590f6788716cfa89d65bbe8ad3e)

Author	SHA1	Message	Date
Mohamed Wael Khobalatte	c885551329	Pass id to AR's `exists?` and `find` instead of an instance	9 years ago
Henriette Dinger	066a7e9bc5	Fix broken spec (give correct parameters)	9 years ago
Henriette Dinger	45ca65e3be	Inlude review feedback	9 years ago
Henriette Dinger	bce314a970	Fix broken specs	9 years ago
Oliver Günther	dc90d71942	Replace severer warnings with danger zone ... This commit removes the `.-severe` warning notification type in favor of the danger zone.	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ... ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Jens Ulferts	571b7b3ba6	hoping for spec stablility	9 years ago
Jens Ulferts	31ec2ab0c2	using stable expectation	9 years ago
Oliver Günther	0a3dcfac9e	Use find selector after JS redirect ... On occasions, the CI reports the same feature spec to be failing due to a StaleElementReferenceError, however the stacktrace suggests that this error stems from the extraction of node texts after the actual query within one retry of the synchronized selection. The stacktrace begins that error inside `synchronized` and deep within `result.failure_message`. 120daaa856/lib/capybara/node/matchers.rb (L97) Thus this commit suggests to use the simplest `find` selector to locate the element, which does not access its contents.	9 years ago
Oliver Günther	b2068dbed1	Try to select other element first after page redraw. ... By selecting an entirely different element on the settings page (e.g., the flash message), the button and radio elements are being available afterwards and do not return a capybara cache error.	9 years ago
Oliver Günther	a00c116eb8	Allow increased wait time for JS-induced redirect ... The same shared examples of `create_repository_spec` are repeatedly encountering timeouts after a repository is created and the user is redirected to the settings page. This allows these methods to have more wait time at their disposal.	9 years ago
Oliver Günther	ee3b1ee1ad	Change feature spec broken by openproject-checkout. ... The checkout plugin overrides behavior in the core which leads to the repository settings form submit button to be displayed even though the core feature expects it to be hidden. As the surrounding spec is relevant for the plugin, too, and should not be skipped / disabled, this commit instead reworks the test to check for a different aspect of the page to ensure the request was successful.	9 years ago
Oliver Günther	6763fe875d	Remove save button for managed repositories ... This commit removes the settings `save` button for managed repositories. Important: When adjustable settings for any vendor should be added, this button must be shown depending on some individual vendor logic.	9 years ago
Oliver Günther	ad0632a278	Fix invalid method used in :update	9 years ago
Oliver Günther	5cb81d6995	Fix typo in attributes-group.	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	c5b200d7a0	Review corrections ... - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	3377696563	Began frontend feature specs	9 years ago