openproject

Commit Graph

Author	SHA1	Message	Date
Behrokh Satarnejad	c92c750625	[30242] Extend work package autocompleter with more useful information (#8554 ) * WP auto completer changes in global search box * resolve the travis check errors	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	05638a1784	bump oj	4 years ago
ulferts	7e7b9132e3	Fix/child scheduling restrictions (#8584 ) * allow free scheduling children of manualy scheduled parents If a parent has a follows relations with another work package, that relationship also limites children of the work package. But if the work package is scheduled manually, this creates a scheduling barrier. Children of a manually scheduled work package are not hampered by the follows relationships of the parent or other ancestors. * simplify soonest_start query * eager load * extract to scope	4 years ago
Oliver Günther	86b8ffc326	[30007] Allow users to enable CORS on APIv3 resources Allows a setting and configuration option to allow access to APIV3. Setting allows us to selectively enable this for cloud instances too. https://community.openproject.com/wp/30007	4 years ago
Oliver Günther	8d2da3f6d8	[33648] Add value macros for referencing label and values of project and work packages (#8578 ) * Add macros for attribute values and labels of HAL resources * Implement label macro with help text For that, we need to move help texts out of the work package module. The fields module appears to be best suited for it. * Load the current project for project attributes * Don't render things that only matter in writable situations Such as the project dropdown indicator or the spent time modal * Throw if ID was not correctly provided * Bootstrap the inserted html of a custom text * Expand errors if user cannot see/load expected macro resource * Add text formatting spec * Add feature spec to test both loadable and failing macros * Reference only subjects in the current project if not referenced by id * Extend documentation * Refactor loading switch * Add macro for work package quickinfo (previously ## and ###) * Extend spec to double and triple hash macros * Ensure we allow numeric strings as IDs Was testing for isNumber, which only checks for actual number types * Fix showing the placeholder when not empty * Add error span to the quickinfo macro * Better styling and title help for macros	4 years ago
Oliver Günther	73a1d29e95	[24760] Enable ckeditor image resize plugin https://community.openproject.com/wp/24760	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Oliver Günther	c369a71f4d	Allow project help texts on the rails form Renders help texts on a project core attributes and custom fields	4 years ago
Aleix Suau	5ea357c750	Bump CKEditor5 to v21 (#8570 ) * Bump to v21 * Upgraded to v21, really * Todolist spec fixed * Update fixes for child pages macro * Fix code block conversion Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	81bd0e34cd	[34025] Allow insecure localhost redirect_uri for OAuth This makes it easier for developing and debugging local OAuth applications https://community.openproject.com/wp/34025	4 years ago
bsatarnejad	3676ead9aa	Change how watchers data is returned to front-end, blocked users are not returned	4 years ago
ulferts	8cb7ed632a	remove watchers embedded in wp representer A client should not rely on embedding and our front end does not appear to	4 years ago
Inga Mai	92eef3b2d0	Fix test for projects settings	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	655f021b92	add derived dates to the work package resource The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
bsatarnejad	1fbc75b96d	writing a test for estimated-hours filter with none and zero values	4 years ago
ulferts	8656c2664b	fix archiving projects via api When archiving, we need to assume the old `active` status to see if any modifications can be made. On top of that, whenever that status is changed the archive/unarchive service needs to be called as well so that e.g. the child projects are also archived	4 years ago
bsatarnejad	5f0b48617c	writing a test for estimated-hours filter with none and zero values	4 years ago
ulferts	829648e1ad	remove operators not applicable to only subprojects filter The none operator does not make sense as it means that no work package will be returned. And the all operator will be the same as not having the filter at all. There is a minor change in the UI in this change in that the order of the opertors of the subproject filter is altered. But this should not be a problem for the user and leads to a simpler implementation.	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
Oliver Günther	ebfd3ce009	[32817] Disable advanced settings in project template (#8537 ) https://community.openproject.com/wp/32817	4 years ago
Oliver Günther	e3471ec69b	Fix calendar initialization and expected class names	4 years ago
Oliver Günther	a3acfdc9fc	Fix changes in upgrade of fullcalendar	4 years ago
Oliver Günther	dfa6bdb456	Extract all access of APIv3 calls into APIv3Service (#8521 ) * Move apiv3 path helper into apiv3 service * Refactor application to use apiv3 service * Allow caching responses within apiv3 endpoints through state cache * Fix reference to root service * Continue refactoring of DM services * Refactor version DM service * Refactor order service into v3 paths * Replace time entry dm and cache service * Replace QueryFormDmService with nested form resource * Replace QueryDmService with api paths * Replace ProjectDM and ProjectCacheService * Move PayloadDmService into static helper class * Replace NewsDmService with api paths * Replace MembershipDmService with api paths * Replace HelpTextDmService with api paths * Replace ConfigurationDmService with apiv3 path * Replace GridDmService with paths * Remove DmListParameters This is now Apiv3ListParameters type * Replace virtual BoardDmService with a virtual path Boards are not actually their own API resource, but a shallow wrapper over a grid resource. To reuse the same API service pattern, we can allow other resources other than HalResource and make the boards path just reference the grids paths. This allows to nicely use the `apiV3Service.boards.id(..).cache` patterns. * Refactor cacheState into single method * Make HalEditingService a v3 cache without loading ability * Replace usages of WorkPackageCacheService with api-integrated cache * Fix accessing grid subpath * Correctly use schema ensureLoaded before inserting into caches * Fix query not having an ID when updating * Fix npm tests after removal of wp cache * Readd missing path helper for APIv3 used from ckeditor * Correctly save query in widget * Fix watcher tab * Fix search path * Use a promise for the updateImmediately link of time entry * Make apiv3 independent cache services depend on the base cache service We had two cache services now, one base service for the apiv3, and the previous one. Both shared a lot of code, so we can unify them * Don't use multiState getter in schemaCache * Correct loading of schema * Correctly fill state with relations * Don't render comment until workPackage ready * Merge the initial loading observable to get error handling If we only return state.values$(), we never get the initial http observable and thus no error handling * Ensure we reload the default query from the current project if any * Use get() instead of stream * Load types correctly * Fix paths in enterprise token urls * Ensure take(1) in requireAndStream toPromise usage * Avoid duplicate StateCacheService definition * Only use project based query when there is no query.id yet There is no endpoint for /api/v3/projects/:projectIdentifier/queries/:id * Add isAvailable to filter out filters incorrectly added The search component always adds a subproject filter when in project scope. This filter however is only valid/existent in schemas if there is a subproject. This ensures we only try to access filters that are available * Refactor embedded table to reuse the loadQueryFromExisting method We had a few duplicate methods on how to look for a query with params basing on an existing (saved or unsaved) query. * Ensure filter schemas are inserted and checked before use * Better matcher for search spec * Ensure correct initialization of query states * Load attribute help text correctly	4 years ago
Wieland Lindenthal	1e205f8da3	Fix bug spec introduced by resolving merge conflicts. Also correct spelling, rename "addin" to "add-in".	4 years ago
Oliver Günther	e80fcfbeac	[33901] Disable the button and disallow editing for scheduled parents https://community.openproject.com/wp/33901	4 years ago
Oliver Günther	3b78c25588	Fix spec expecting for start date to be moved back	4 years ago
Oliver Günther	02a8a92540	Allow overriding scheduling in the table by mapping attributes	4 years ago
ulferts	74fe191997	handle switching from manual to automatic	4 years ago
ulferts	4dc11b7240	handle switching from automatic to manual	4 years ago
ulferts	8805ea74c9	Use combined schema for combined date field Introduces a combined property schema for the combined date field of work packages. To that end, the way the schema is referenced is moved from calling the schema on the HalResource (i.e. work package) to fetching it from the SchemaCacheService. As the backend only provides generic Schema resources for all resources (e.g. TimeEntry, WorkPackage), the difference in behaviour (i.e. determining whether a property is editable is performed within a proxy handler. That handler is applied whenever a schema is fetched from the Service.	4 years ago
ulferts	fdcc89f810	allow freely setting the dates of manually scheduled child work packages	4 years ago
ulferts	c5ead62e0a	adjust contract to allow setting dates on manually scheduled parent wps	4 years ago
ulferts	7065c162fd	disregard manually scheduled nodes when scheduling work package graphs Instead of fetching all work packages from a subset of the whole graph constructed by hierarchy and follows relationships upon scheduling, only work packages eligible for automatic rescheduling are returned. In order to avoid quering the database multiple times, the whole subgraph is returned at once using a recursive CTE.	4 years ago
ulferts	a2a559e553	remove almost duplicate, but faulty, readonly check The writability of the status is already checked at the attribute level	4 years ago
Oliver Günther	a92575e3ec	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	c6b9c8ff02	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	2fed3ee301	Add filter to select only (non-) milestones	4 years ago
Oliver Günther	f225b95b69	Fix specs expecting the token [ci skip]	4 years ago
Oliver Günther	aba8996262	[33592] Add an empty group to ensure the user can remove all groups https://community.openproject.com/wp/33592	4 years ago
Oliver Günther	20f9f35991	Better waiting for wp tabs count	4 years ago
Oliver Günther	65fe7ce06f	Return the unmapped work package ID in case of wp not copied When a foreign work package is linked, it will not get copied during the project copy service. In this case, just use the original to retain it.	4 years ago
Aleix Suau	cba0f602a0	'shows Cards view by default' fixed + Removed deprecated test files	4 years ago
Wieland Lindenthal	760cdafe8c	Added Revit test configuration and some tests	4 years ago
Oliver Günther	8f33b196cc	Add attachments section and load them to show attached files	4 years ago
Oliver Günther	595a2a4b22	Add contract for attribute help text contract	4 years ago
Aleix Suau	c453ecab09	'shows Cards view by default' fixed + Removed deprecated test files	4 years ago
Oliver Günther	2feaec1101	[33678] Priority needs to be a require field Priority was marked non-required for it to turn up in the attribute form configuration. But priority _is actually required_. This results in the frontend adding an optional placeholder `-` value, which makes the resource unsavable. This commit adds priority to the form, but keeps it required as it should be. https://community.openproject.com/wp/33678	4 years ago

1 2 3 4 5 ...

6880 Commits (092f1054e15b1c616c68c2dd9d0e3870d6a8c829)