59301 Commits (0981c65582d734cc8cf2c37f192b42341a11cb0e)

 

All Branches   

Search

Author	SHA1	Message	Date
ulferts	247c8e913e	fix row rerendering with limited permissions ... If the user has limited permission, e.g. no right to reorder, the first row, used for sorting, has had a different class set. When rerendering that row, the class set is expected but not found. The patch * Adds the expected classes * Increases the robustness whenever the expectation is not met in case other places make the same mistake of not adding the necessary classes	4 years ago
Aleix Suau	0358f89abf	Download pdf on a new tab (#9004)	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043) ... Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1dabcbc566	fix templated check on boolean filters ... The check for templated failed for boolean filters as true was returned where a string was expected	4 years ago
Wieland Lindenthal	c4c2149d98	Fix: 36299 -- Allow to modify login when global permission :manage_users present (#9026) ... * Refactoring: Create shared examples for user contracts * Users::UpdateContract spec added * Add spec for updating the login of a user * Add spec for permitted params when global permission to :manage_user * Remove spec for :login updates for user UpdateContractSpec The writability of the login attribute is not part of the contract (yet). * Use user contract for checking writability of user attributes * Fixing user contract specs. * use persisted user in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	45b83c36d9	Merge branch 'release/11.2' into dev	4 years ago
Oliver Günther	935cd02d33	[36294] Show authentication header only when any partial matches (#9044) ... * [36294] Show authentication header only when any partial matches * use collection_select for collection Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	0fa8b4a77b	Forward CSP extensions to login controller (#9047) ... * Forward CSP extensions to login controller * Extend spec for double auth code * stabilize spec On my machine, since I have an s3 bucket configured, the spec failed Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	65575d44f1	[36415] Add public filter to projects list (#9057) ... https://community.openproject.com/wp/36415	4 years ago
Cyril Rohr	9fe8f7b28a	Fix instructions to setup Let's Encrypt with newer certbot client (#9056)	4 years ago
Cyril Rohr	6245eb39ba	Fix instructions to setup Let's Encrypt with newer certbot client (#9056)	4 years ago
Oliver Günther	ea29493ce7	[36353] Restrict possible select options in cost entries to users (#9053) ... https://community.openproject.com/wp/36353	4 years ago
RobinWagner	2f0666e068	Specify MS Edge version (Chromium-based) ... [ci skip]	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977) ... * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
Markus Kahl	47a752d889	make sure to use latest patch level of ruby base image (#9052) ... * make sure to use latest patch level of ruby base image * how to handle outdated images	4 years ago
Markus Kahl	487811aa86	fix custom field validation on unpersisted record (#9050) ... * fix custom field validation on unpersisted record For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail * adapt spec to have the members created in setup Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	eebf873eb1	disable direct uploads when use_iam_profile is true (#9049)	4 years ago
ulferts	bc238d62be	fix custom field validation on unpersisted record (#9048) ... For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail	4 years ago
ML-OpenP	d94241862b	words corrected to lowercase ... [ci skip]	4 years ago
ML-OpenP	08ff4ccace	removed section "attribute help texts" as it has been moved before ... [ci skip]	4 years ago
ML-OpenP	af89682516	Many words corrected to lower case ... [ci skip]	4 years ago
ulferts	c3256aba9b	Merge branch 'release/11.2' into dev	4 years ago
RBernsen	9c06fd91c3	Added section assignees and accountables ... see above [ci skip]	4 years ago
Oliver Günther	c7263412f1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	5efea5cf81	update locales from crowdin [ci skip]	4 years ago
ulferts	64cf18856b	Revert "update locales from crowdin [ci skip]" ... This reverts commit 3cb8fef5e6.	4 years ago
Travis CI User	3cb8fef5e6	update locales from crowdin [ci skip]	4 years ago
Piyotaro, Kiiroi (きいろい ぴよ太郎)	6385150c6a	Bump nodejs to v14.16.0 (#9046) ... * Bump nodejs to v14.16.0 Lastest LTS version of nodejs is 14.16.0 * Bump nodejs to v14.16.0 Lastest LTS version of nodejs is 14.16.0	4 years ago
ML-OpenP	e90deea88d	change necessary disk space ... [ci skip] Co-Authored-By: ulferts <617519+ulferts@users.noreply.github.com>	4 years ago
ML-OpenP	9205d3dbb1	Update COPYRIGHT.rdoc	4 years ago
Travis CI User	9187f43935	update locales from crowdin [ci skip]	4 years ago
ulferts	f938b23bd1	Merge branch 'release/11.2' into dev	4 years ago
ulferts	37d75fbaec	bump version to 11.3.0	4 years ago
Oliver Günther	8122d05a66	Add visible scope for placeholder users (#9042)	4 years ago
Travis CI User	31b0931892	update locales from crowdin [ci skip]	4 years ago
ulferts	7880af1494	include id filter into teaser block	4 years ago
ulferts	b51aebd397	update new feature box to 11.2 features (#9041)	4 years ago
ulferts	2fcb973c80	Merge branch 'release/11.2' into dev	4 years ago
ML-OpenP	4711a63644	small docs improvements ... [ci skip]	4 years ago
Oliver Günther	0a84a0b671	[36296] Add PlaceholderUsers API (#9033) ... * Add PlaceholderUsers API * Fix remarks in apib * Add deduce_element_decorator to collection * Remove unnecessary path	4 years ago
Travis CI User	6441ef5198	update locales from crowdin [ci skip]	4 years ago
ulferts	609d6e04a6	Fix/bump gems (#9039) ... * bump excon * bump faker * bump fastimage * bump pdf-reader * bump okcomputer * bump recaptcha * bump rspec-mocks * bump ruby-prof * bump webmock * bump rack-mini-profiler * bump mime-types-data * bump timecop * bump test-prof	4 years ago
ulferts	b8ca382d34	Group API (#9034) ... * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
ulferts	17b0d10e88	bump puma	4 years ago
ulferts	86eeccd329	bump rack-attack	4 years ago
ulferts	30cf6f870f	bump secure_headers	4 years ago
ulferts	7da4ef533e	bump rubocop	4 years ago
ulferts	f995e32694	database_cleaner	4 years ago
ulferts	1c663a74f4	bump commonmarker	4 years ago
ulferts	d2c529d1f3	bump capybara	4 years ago