openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ff8da4435c	[25172] Force activation of field when user requested it The wp edit form currently checks for an active field before accepting a request to activate it. However, it appears to exist an external effect (refresh possibly) that closes the field without resetting the form. We should allow activating the field regardless of it being active currently to avoid this error.	8 years ago
Oliver Günther	c800efc7b2	Remove template rendering in wp-display-fields This fixes a recurring compiling of a template in a new scope that is never cleared. The SimpleTemplateRenderer is still in use for the edit field functionality in the table, however there we have an explicit lifetime that can be controlled through the EditFieldHandler. Thus, it keeps a reference to the scope used to compile the field, and destroys it upon deactivation.	8 years ago
Oliver Günther	0b3ed9b113	[25026] Indicate fields of type WorkPackage to not be editable (#5357 ) [ci skip]	8 years ago
Roman Roelofsen	88f4b30ac9	Added ReactiveComponents (#5260 ) Replace reactive-fassade with reactivestates npm package.	8 years ago
Oliver Günther	49c6744f50	Place edit fields into separate container That allows us to refresh cells without caring about a potential hierarchy indicator within the cell.	8 years ago
Oliver Günther	2c92551a3a	[23658] Remember and set cursor position when opening input fields This adds a callback to the edit field rendering process to allow modifying the now-in-dom edit field. Using the Range/Selection API, we can now find out where the user clicked and forward that information to the field.	8 years ago
Oliver Günther	7e8dc321fa	Inline create work packages in new work package table	8 years ago
Oliver Günther	32472da1dd	Enforce strictNullChecks	8 years ago
Oliver Günther	e8595ac0a3	TypeScript: Enforce noImplictAny	8 years ago
Oliver Günther	ac15c6e6ea	Fixes after last dev rebase	8 years ago
Oliver Günther	18f6294914	Properly close fields when submitting without changes	8 years ago
Oliver Günther	9a3b0c1561	Review feedback	8 years ago
Oliver Günther	fb0025f9a6	Add debug logging and fix codeclimate issues	8 years ago
Oliver Günther	0ac5316fc2	Update more intelligently when a row is being edited Fixes the following bug: When grouping by type, and switching the type to another with a required CF, the column expansion of this CF redraws the table, which overrides the group since the type is switched.	8 years ago
Oliver Günther	850c0fc565	Fix global mousetrap exposer	8 years ago
Oliver Günther	8a5dbbb043	Remove workPackageId number\|string dualism States always expect strings, so we should treat the ids as such.	8 years ago
Oliver Günther	5f6c265706	Introduce separate click/keypress handlers	8 years ago
Oliver Günther	486097974f	Basic table edit field and error handling functionality	8 years ago
Oliver Günther	056412263b	Editing functionality WIP	8 years ago
Oliver Günther	e71d17fa0f	New table class with delegated builders and form handlers	8 years ago
Roman Roelofsen	beadcc8b38	Refactoring: angular-rx-utils: - observe() -> observeOnScope() - added observeUntil()	8 years ago
Oliver Günther	3b9b487406	Autoload the schemas from the schema states	8 years ago
Oliver Günther	cb044cb0fb	Deactivate edit fields after saving	8 years ago
Oliver Günther	611e42238c	[23896] Submit and close edit mode on enter for most edit fields When editing a single field (except select, checkbox), pressing enter triggers the `submit` handler of the surrounding form. This form submit is disabled when in edit mode, since the wp-edit-field uses that submit also for saving on blur, which we deliberately disable in this case. We can instead capture another event on those fields where it makes sense that submits the field after pressing enter, but only IN edit mode (since without it, submit handles it). https://community.openproject.com/work_packages/23896	8 years ago
Oliver Günther	089e0744d0	Fix TS warnings	8 years ago
Roman Roelofsen	82f47b0f63	fixed tests	8 years ago
Roman Roelofsen	a7e5858631	Use reactive fassade for wp cache service	8 years ago
Oliver Günther	36c3d7d894	[23879] Fix editing a subject in the table after creation The form controller was not subscribing the latest work package and thus failed to receive the `$pristine` values set by the field controller after initial creation. https://community.openproject.com/work_packages/23879/activity	8 years ago
Alex Dik	4c5eae5b2d	Fix error resource handling	8 years ago
Oliver Günther	37c3bfab21	Unload work package activity after save	8 years ago
Oliver Günther	ec1b97041b	Always save the WP when it is new Otherwise, copying work packages will break.	8 years ago
Oliver Günther	ea6b930582	Show 'Open in full screen' notification only when not in fullscreen https://community.openproject.com/work_packages/23574/activity	8 years ago
Oliver Günther	d07ec7a3eb	Rename wpNotificationsService	9 years ago
Alex Dik	f7a9f6e51f	Refactor wpEditForm controller	9 years ago
ulferts	d800fb25c8	don't submit an unchanged wp resource (#4575 ) Checks the wp's dirty flag before actually submitting the wp. Thereby, updateWorkPackage becomes a noop if a wp has no changes.	9 years ago
Alex Dik	7e8c9beea4	Add success state redirect after new WP is saved	9 years ago
Jens Ulferts	4b06a41ba3	provide api independent error message for date format errors	9 years ago
Jens Ulferts	4a1274d6a3	extract wp notifications into separate service	9 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556 ) * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529 ) * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
Oliver Günther	909bc08266	Fix cuke selector	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Oliver Günther	5da8c31f40	Fix switching types in Edit all mode	9 years ago
Oliver Günther	760fc47c7f	Fix focus on first element on create	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	426876a264	Fix enabling fields by default when switching	9 years ago
Oliver Günther	d34799a89a	Edit all on fullscreen view	9 years ago
Oliver Günther	805b754971	Add wpEditModeState service to register form	9 years ago
Oliver Günther	c7d9be477d	Expand fields correctly	9 years ago

20 Commits (09c0fa0cc9962ea3413eda5e438333e2338b54b6)