1256 Commits (0ca9f4d742c4be6f95d93a0e46ae7100f6facbeb)

Author	SHA1	Message	Date
Jens Ulferts	f833cd2753	add test for mysql flag	8 years ago
Oliver Günther	108fd4a019	Strengthen spec ... DB rounds to nearest milisecond	8 years ago
Jens Ulferts	c71a675ecd	introduce true/false db representation constants for cf	8 years ago
Jens Ulferts	d4e71fd67e	add user query and enabled it in the users api	8 years ago
Oliver Günther	e3e2749165	Fix Setting.user_format leaking	8 years ago
Jens Ulferts	1a597e180b	first step towards generalizing the query and its filters	8 years ago
Oliver Günther	367a18d452	Fix Setting.app_title order failure	8 years ago
Oliver Günther	688385428c	Avoid multiple requires of spec_helper ... https://github.com/rspec/rspec-core/issues/1076	8 years ago
Markus Kahl	104bde6ad7	execute wp notifications as recipient for permissions	8 years ago
Jens Ulferts	bcff977924	prevent circular dependency of 'from' relations ... The previous implementation to detect circular dependencies was limited to detecting those circles, that originated in the 'to' work package of a relation. It did not prevent circles where the 'from' work package is involved. Now, both branches are checked. While this removes the immediate issue, it also increases the time required for saving a relation. As long as our database does not provide us the capacity for recursive queries, this cannot be helped.	8 years ago
Jens Ulferts	c3013d6272	lazy load query filters and extract them into classes ... This allows us to only load the values we actually need instead of loading all the values regardless of whether we need them. This is especially usefull in the api where we currently never need those values. Note, that this is a glitch in my opinion as we do not check whether the filter value is valid.	8 years ago
Oliver Günther	88cfd2d80f	Extend and move relation spec	8 years ago
Jens Ulferts	9a3b88f011	replace find_by_[attribute]	8 years ago
Jens Ulferts	8f1c5d76b7	allow parent project to be set on copy	8 years ago
Jens Ulferts	967678ad65	replace observer	8 years ago
Jens Ulferts	26fd453ca4	handle spec permissions the new way	8 years ago
Jens Ulferts	77479ed4b2	add meetings to permitted search params	8 years ago
Jens Ulferts	425d02a4c7	remove custom permissions= method	8 years ago
Jens Ulferts	da7b63eeb7	discard empty and duplicate permissions	8 years ago
Markus Kahl	471733ab05	prevent renaming wiki pages if there will be menu item conflicts	8 years ago
Jens Ulferts	e8dec71010	fix specs	8 years ago
Jens Ulferts	a6d265eb79	force bool custom values to be stored uniformly	8 years ago
Jens Ulferts	181514742f	replace observers by moving functionality inside the observed object ... The observers should have been removed a long time ago and with rails 5 there is https://github.com/rails/rails-observers/issues/52 to consider as well.	8 years ago
Jens Ulferts	ea36f19be2	replace ineffective permission assignments	8 years ago
Jens Ulferts	6fcb2913d4	cast to array before slicing	8 years ago
Jens Ulferts	693090136d	normalize permissions ... With rails 5 it is no longer possible to create an sql like statement via arel which will check whether a serialized array contains a string. AR will only allow to create a match against an array if the column itself is marked to serialize an array. Because of this and in order to increase the normalization of the data, the permissions are no longer serialized and are moved into a separate table instead. While this is still not normalized, it satisfies the needs	8 years ago
Oliver Günther	59da2c6175	Actually rehash on the correct object instance ... `becomes!` does not change the current object (how would it?), so we need to call `hash_password!` on the object returned from it. This also extends the false positive test. The rehash actually happened, but it was hashing the plain as a legacy SHA-1 again.	8 years ago
Oliver Günther	fff21a1229	UserPasswords: Replace salted SHA-1 with bcrypt ... This adds a typed userpassword class for Bcrypt password hashes that replace the previous default of salted SHA1. It still provides a class for SHA1 passwords, however new passwords of that type may no longer be created directly, and passwords are checked whether to upgrade them on every login.	8 years ago
Oliver Günther	e6c7c2bab5	Fix and extend specs	8 years ago
Oliver Günther	726fa0abf2	Rewrite project layout page with directives	8 years ago
Oliver Günther	98fdadd02c	Add UserSession model to store user_id in sessions	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Jens Ulferts	44e4343f05	add integrational tests for Authorization.projects	8 years ago
Jens Ulferts	ff3ecc9e59	employ sql based user allowed scope for acts as watchable	8 years ago
Jens Ulferts	b5ecd43331	reimplement authorization adaptation after core change	8 years ago
Jens Ulferts	1ddc142fd3	add sql based query to fetch all users being allowed an action	8 years ago
Jens Ulferts	06c6defa51	replaces ruby based permission check for allowed_to? with sql based query	8 years ago
Oliver Günther	65c3ebaa2d	Fix specs	8 years ago
Oliver Günther	35fa92c2ff	Fix specs according to title <-> name swap	8 years ago
Oliver Günther	43fab7884a	Titles no longer need to be unique ... Since the slug is now the unique identifier for the page, we can avoid title conflicts by letting the slug determine unique records.	8 years ago
Oliver Günther	f13226eb7a	Scope unique slugs per wiki_id	8 years ago
Oliver Günther	9a34fe27c7	Migrate wiki titles to URL slugs ... Wiki titles in 6.0 can contain ANY character, which is causing issues for specific characters processed by textile and CGI-escaped before we can actually parse wiki links. To mitigate the issue of linking space/underscored wiki pages, introduce a permalink URL based on the title and create a migration to move old underscored titles (e.g., `base_de_donées` to spaced titles `base de donées`).	8 years ago
Oliver Günther	616ec628b5	Rewrite with_setting specs ... And fix tests that do not expect settings to be cached during the request with RequestStore.	8 years ago
Oliver Günther	4353953605	Improve stored settings as a whole ... Currently, settings are cached on a per-name basis, but that cache is expired everytime *any* attribute is written. Even when a week-old attribute is still valid, its cache is expired as soon another setting is updated due to the max settings cache key. Instead of caching a single attribute, I suggest to cache the entire settings (the total number with plugins is less than 120 and 4KiB in size) and retrieve and deserialize a single value from that hash. That saves us the time to: 1. Locating a single element from database 2. Instantiate a setting object just for deserializing 3. Requesting settings several times by using RequestStore	8 years ago
Oliver Günther	646d99b704	Prepare OpenProject 6.0.0 release	8 years ago
Jens Ulferts	8625c5d387	adapt spec to altered work_package_id filter	8 years ago
ulferts	f043409330	adhere to notification settings when notifying about added watcher (#4683) ... The PR will let the users added as watchers be notified according to their settings. Especially https://community.openproject.com/work_packages/22636/activity should be fixed by it. Unfortunately, the #notify_about method on User is not reusable here for all cases as it would have to be adjusted to fit the requirements. But that method is used for a couple of use cases and I did not want to alter it shortly before a release. The method looks weird, though as e.g. the watchers are not taken into account for 'only_my_events' which reads 'Only for things I watch or I am involved in'. Additionally, it does not care for the self_notified? setting.	8 years ago
Oliver Günther	550763ae46	Do not 'inherit' priority from children ... This removes updating of priority values from children to parent work packages.	8 years ago
Markus Kahl	8f0c9ae24d	fixed inherit_done_ratio_from_leaves bug (#4665) ... which could result in parent progress values greater than 100	8 years ago
ulferts	9a6d5585f4	preload permissions before collection rendering (#4646)	8 years ago