openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
ulferts	e9692f85a5	add filtering for assignee with placeholder users	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
Oliver Günther	e484804645	[35506] Avoid notifications for assigned/responsible placeholders Right now, placeholder users cannot be watchers nor authors nor meeting participants, so the only notifications that can happen are work package assignees or responsibles. https://community.openproject.com/wp/35506	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	4d17b19783	[36026] Ensure project filter only searches for active projects https://community.openproject.com/wp/36026	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948 ) * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	1c8aaf031f	Maintenance: ruby patch level update to 2.7.2 (#8951 ) * Update ruby to 2.7.2 * make sure to pull latest base image * minor comment update	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	4ad9ebc6ee	Fix/filename on direct upload (#8928 ) * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file	4 years ago
Oliver Günther	abe024ec7f	[35949] Allow to override priority in incoming mail (#8930 ) https://community.openproject.com/wp/35949	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	7e10047827	Fix removed LdapError error class	4 years ago
ulferts	c638b0d8dc	fix order_by_name	4 years ago
ulferts	af17724320	use slug for wiki activity (#8888 )	4 years ago
ulferts	bf9bc70bb1	fix grouping by cf while summing (#8881 )	4 years ago
ulferts	9f6ea0812c	use acts_as_url for new wiki page (#8878 )	4 years ago
ulferts	41590f17cf	handle special case of wiki page consisting of only a dot (#8876 )	4 years ago
ulferts	2ad215fed1	add milestone type filter for default project gantt query (#8869 )	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867 )	4 years ago
ulferts	6af7401704	fix ruby 2.7 deprecations (#8866 )	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
Wieland Lindenthal	fd2b2a3f2a	Feature: Optimize memory for pdf exports with attachments (#8861 ) * Change design of WP list PDF export to batches In order to keep memory consumption low when exporting WP as list in PDF, we split the work in batches of 100 work packages. In every batch we resize the attached photos and create a PDF. When all batches have been processed, we merge the PDF files via the command line tool `pdfunite` which fortunately comes with a package that we already require for text extraction. Only at the end, when the merged PDF is ready (and small) we load it into the ruby process to return the PDF's content with service's success. In every batch, we make sure that we remove all minimized images afterwards. And after merging the batch PDF files to the final PDF we also delete all batch PDFs. * Don't load the merged PDF file into the ruby process * Rename tempfile to final file name before storing. * Improve code structure.	4 years ago
Wieland Lindenthal	06cc0ec588	Optimize memory usage for pdf exports with attachments (#8854 ) https://community.openproject.com/wp/35327 - Installs Imagemagick package for image conversion. - converts all attachments to a smaller size before printing them to the PDF file. - Ads a installation check to the _Admin -> Information_ screen.	4 years ago
Wieland Lindenthal	5c65ae2e1e	Fix #35131 : Cleanup migration for BIM themes (#8834 ) * Fix #35131: Addin a cleanup migration for BIM themes Elder BIM instances got "OpenProject" theme instead of the "OpenProject BIM" theme after migration as that became the default for the theme column. BIM instances need to get the theme set in a new CustomStyle entry AND its colors need to get written to DB. When digging around on Saas there were also BIM instances that had a theme set in a CustomStyle but did not have the colors written out to DB. * Refacotring: improve clearity of migration	4 years ago
Wieland Lindenthal	c919da0550	Fix: #35132 Activity broken for wiki pages with slashes in title (#8823 )	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	5a7176e6e1	Fix/search for projects (#8815 ) * fix searching for projects * only provide search options active in the project	4 years ago
ulferts	6fe0d2752f	don`t bail if data is already gone	4 years ago
ulferts	14f8165c29	combine flag for self and descendants manually_scheduled	4 years ago
ulferts	9c7f3b8649	adapt scheduling scope documentation	4 years ago
ulferts	33081e1f97	increase performance of scheduling by avoiding paths aggregation It is no longer necessary as we are no using `UNION` and not `UNION ALL` so that even if a path is traversed back again, that will not lead to an infinite loop since the `UNION` will work as a DISTINCT canceling out paths that we have already traversed	4 years ago
ulferts	f4ce976588	condense to only one CTE	4 years ago
Oliver Günther	d8cdfa8196	[34535] Override project limiting filter if subproject filter present When the query has an explicit SubProject or OnlySubproject filter, the project limiting filter based on the global settting does not really make any sense. It will prevent seeing any results when trying to view work packages from a subproject unless it is enabled globally. This change suggests to skip this limiting filter whenever an explicit subproject filter is added to the query. This fixes subproject boards when the global setting is enabled, since that sets only the `onlySubprojectFilter`. https://community.openproject.com/wp/34535	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
ulferts	3b0f7367fd	move to proper module	4 years ago
ulferts	c54e895ad4	lookup existing user for mapping case insensitive	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681 ) * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	fee230122b	allow me id in principal filter The magic me value has been allowed the whole time but the equivalent id of the current user was not.	4 years ago
Oliver Günther	6d6d6aeb09	Ensure we set `just_registered` only for users that were just created	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Markus Kahl	9c1599a976	added handy session data lookup helper	4 years ago
Oliver Günther	ba2cd45fb8	[33677] Let boolean CF filters be kind of BooleanFilter We detect boolean filters based on that mixin class as there is no generic way to find out what is a boolean filter. The CF boolean filters duplicated the behavior of `::Queries::Filters::Strategies::BooleanList` but did not include it. https://community.openproject.com/wp/33677	4 years ago
Oliver Günther	af4010b003	[33496] Don't try to lookup custom value by value Only for list types, the value will be an integer to look up by id, but instead use `CustomValue.new(...).typed_value` to use the formatter classes to correctly look up the value. https://community.openproject.com/wp/33496 [ci skip]	4 years ago
Oliver Günther	a33521a1a8	[32131] Only show active projects in custom action condition https://community.openproject.com/wp/32131	4 years ago
Oliver Günther	4bb47cd935	[33750] Ensure default statuses can not be set read only https://community.openproject.com/wp/33750	4 years ago

... 3 4 5 6 7 ...

4326 Commits (102615df2dd64b8ccb0b16ff9cf20ce2d2c766d1)