openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	fb654d0afa	Correct for review - Switch to styled_form and remove highlight from button - Fix permanently typo	9 years ago
Oliver Günther	35c78a6acc	Remove superfluous JS remote select.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	c63b9c7a08	Frontend refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user.	9 years ago
Oliver Günther	2ce4646346	Reverted implied annotate bugfix which raised more questions Annotation syntax highlighting was broken and I fixed it, this commit reverts the changes, which will be properly re-addressed in the separated PR: https://github.com/opf/openproject/pull/3250	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Oliver Günther	1618c80924	Use severe notification for project destroy dialog The current project `destroy_info` style is inconsistent with the styleguide, as it uses a `notification` (used for one-line notifications only) instead of a warning notification box. This commit switches this dialog to the notification-box with warning parameter and suggests to additionaly use the new `-severe` switch for warnings due the potential ramifications this action has. Using `-severe` also makes it compatible with the upcoming repository destroy_info dialog, which also uses this dialog when local data is to be deleted outside OpenProject.	9 years ago
Oliver Günther	933c553ba9	Improve settings for mail, sys web services to improve comprehension. This commit provides: - Improved labels for mail_handler and sys api to spell out `WS`. - Added instruction below the both checkboxes with a brief introduction on what this setting actually does.	9 years ago
Solotchi Veaceslav	6c73856ede	Adjust the css selector name	9 years ago
Oliver Günther	0d17061df3	Fix code syntax highlighting output. When annotating a file in the repository for whose language CodeRay supports, the output is not properly rendered as HTML, but escaped. As CodeRay escapes any items for HTML before output, we can safely assign syntax lines to HTML when highlighted. If text is output from CodeRay (no language set), we want to escape it instead.	9 years ago
Solotchi Veaceslav	7fd856808e	Create custom tooltip that support html	9 years ago
Jens Ulferts	eacd8a4130	remove last login information from user page	9 years ago
Azure7111	f16f916bdd	Fix setting reference	9 years ago
Alexander Bach	18ebdc9a9e	Some settings cleanup	9 years ago
Alexander Bach	984f3dcc4a	Add setting for journal aggregation time	9 years ago
Jan Sandbrink	2c19f97345	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	9 years ago
Jens Ulferts	34928de9c9	no reload on timelog delete Please refer to https://docs.angularjs.org/api/ng/directive/ngHref for the different combinations of href, ng-href and ng-click within an a tag.	9 years ago
Alex Coles	6c84648c9d	Add explicit join references in views Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	81de05e5fe	Remove deprecated Relation#all in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	59b05568e9	Remove deprecated Relation#all in views Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	ffd81c4886	Add some polish	9 years ago
Alexander Bach	c687c63c71	Fix some project url building with identifiers This commit was powered by @ulferts	9 years ago
Alex Coles	2ac7f5d12f	Fix work package bulk edit form action URL Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2faeb3a34a	Migrate AR finder/query methods in views Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	0c3562ce49	fix whitespacing in '_issue_details.text.erb' empty lines and indentation used for code formatting is immediately visible in the resulting output. I tried to employ some special rules to at least allow for usage of indentation.	9 years ago
Jan Sandbrink	c775274707	include missing attributes in mails	9 years ago
Oliver Günther	4e666d563a	[ci skip] Fix flickering search by collapsing the search in CSS This tiny change should fix the flickering search form in high-load environments by appending `-collapsed` state to the angular element before loading.	9 years ago
Jens Ulferts	fa402cdd58	prevent check-boxes crashing into their label	9 years ago
Jan Sandbrink	b44b0cd2f9	remove details on spent time from project overview	9 years ago
Jan Sandbrink	cc844c1068	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	9 years ago
Oliver Günther	676cb6083e	Rewrite search box as angular directive	10 years ago
Oliver Günther	af181577f3	Allow overriding the html title for accessible help	10 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: Top Menu - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) My Menu - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	10 years ago
Oliver Günther	3b2027b42c	Fixing Accessibility issues - Allow s, alt+4 to focus search form - Collapse search on tab out - `::-ms-clear` size and position fix The search form now behaves as following Keyboard * Tab until collapsed search (icon) is focused, the search should expand and the input gains focus. * Tab out of the input, icon will gain focus, search should NOT collapse. * Press enter while icon is focused, search form should be submitted. * Tab out of icon to help, search should collapse._ * Pressing `s` or [modifier + 4](https://en.wikipedia.org/wiki/Access_key) should expand the search. Mouse * Click on collapsed magnifier, search should expand. * Click on any other element other than input / icon, search should collapse. Both * Icon is now flipped when expanded (to resemble the previous state). Should the collapsed search icon be flipped as well ?	10 years ago
Oliver Günther	60a2bd6a0f	Reduce space needed by search and help top menu item This commit changes two top menu items: 1. Search is by default collapsed to its magnifier icon - Upon clicking it, it is expanded and focus given to the search field - Clicking any hierarchy not in below the wrapper, the search is collapsed again 2. The help button remains as a '?' icon, and loses the caption. Relevant work package: https://community.openproject.org/work_packages/20540	10 years ago
Florian Kraft	e8fe39cf3e	add hidden for sighted label [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	e7e65b35ae	password only required for new users Because after that, passwords do not have to be set mandatorily for every user update. But for new users it of course is a requred field.	10 years ago
Florian Kraft	d799420e98	moves the `new subproject` to the project settings This will also remove the button from the default project show page and rename the copy button to `copy project` Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	2c16a738ad	remove 'small' dom element	10 years ago
Henriette Dinger	315efce872	fixed empty message content bug	10 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing * make routing less convoluted (as in `18835799`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	18835799dd	Make ProjectsController#types use PATCH * make routing less convoluted: switch to a regular member route. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	b82772dfae	use wide labels Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Alex Coles	f2045686ad	Replace deprecated #link_to :confirm option Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago

... 3 4 5 6 7 ...

4185 Commits (10673779a368740a305c142dbdf33ed3761471b1)