6821 Commits (10a4ec9d8444e2d0c98191072b9f49a0913a6402)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Linkhorst	aabcd38aea	make #render_custom_fields_rows html safe	12 years ago
Martin Linkhorst	d50f9ff287	this is a part of a commit in redmine if you want the whole commit (adds jsonp support + tests) then look at redmine commit 3c3bdb8	12 years ago
Martin Linkhorst	2e7cb60974	in order to get the default configuration values, we have to completely omit the keys in the config file. otherwise they will be overridden by empty values.	12 years ago
Martin Linkhorst	21fa39c25a	fix the user tests by storing user and his preferences in two steps	12 years ago
Martin Linkhorst	c921d916ad	and make them pass	12 years ago
Martin Linkhorst	01d60ebaa6	expect the shallow path for the topics as written in the routes file	12 years ago
Felix Schäfer	b0cfd3b952	Correctly deserialize current data in custom field translation migration	12 years ago
Martin Linkhorst	f57184ecda	fix copying of a wiki. self.wiki = Wiki.new immediately tries to save to the database. unfortunately, a Wiki.new is not valid? it misses the :start_page	12 years ago
Martin Linkhorst	47e7e7997d	REVIEW: find_object_and_scope fails because we don't have any scope set. does it come from anywhere else?	12 years ago
Martin Linkhorst	09e496f54b	REVIEW: get the changes by joining with the changesets in order to have access to the #committer of the changesets as required in the tests which group changes by the committer	12 years ago
Martin Linkhorst	b5e4430a54	since rails 3.1 we can condense the order parameters	12 years ago
Martin Linkhorst	1e89faedef	HOSSA, #xhr? returns false or an integer >= 0 which is considered true. but in comparison with true or false literals this will always evaluate to false. double negation fixes the problem.	12 years ago
Martin Linkhorst	273f2a3fea	use table_name instead of aliased_table_name	12 years ago
Martin Linkhorst	a89e22e2dc	remove attachments before destroying the issue to avoid getting a Activerecord::StaleObjectError	12 years ago
Martin Linkhorst	c17ffccfe2	REVIEW: update to the new AR api. hint: we need to update all :include => to fix all bugs since only a few of them are testiest	12 years ago
Martin Linkhorst	35955e4c8f	REVIEW: use prototype-rails. fixes some tests. especially remote_function is there again	12 years ago
Martin Linkhorst	934ab3fa1c	expect escaped urls to fix the tests	12 years ago
Martin Linkhorst	337239044c	REVIEW: make :category_id accessible in order to use it with forms	12 years ago
Martin Linkhorst	f1c3a5ef4e	REVIEW: updated to a recent version of rubytree. fixed a minor bug. let's hope it will work.	12 years ago
Martin Linkhorst	38f54383b2	fix some active record queries to work with the new version of rails	12 years ago
Martin Linkhorst	95c9595c71	rails 3 throws an exception when you try to do the following: ... class A has_many :b has_many :c, :through => :b end class B belongs_to :a has_many :c <<-- this has to be a #belongs_to end class C belongs_to :b end fix: define method #c by yourself	12 years ago
Martin Linkhorst	a2fe5839a0	REVIEW: we need to extend the current used version of awesome_nested-set. see commit for details	12 years ago
Martin Linkhorst	e1327b9b9c	add a note why this fails. this is the reason why deleting issues (and projects) sometimes doesn't work	12 years ago
Martin Linkhorst	fb42eb8813	remove a patch that is in the gem code now	12 years ago
Martin Linkhorst	5b3f5f3ba3	::Builder::XmlMarkup is a BasicObject in Ruby >1.9 - contants can only be accessed with the root-sytax (::)	12 years ago
Martin Linkhorst	b231930f69	why use an instance variable here? this makes more sense and fixes the tests	12 years ago
Martin Linkhorst	d563d3387f	fix active record queries by correctly using the new api	12 years ago
Martin Linkhorst	f3ea450c1e	expect two emails since we send one email per user instead of bcc'ing them. we could stub out the #notified_users to remove the magical number and make it more clear but the stubbing is somehow forgotten on the way	12 years ago
Martin Linkhorst	aa18d1fe22	REVIEW: since this started with "test_" it was executed each time one executes the tests. test/unit does not seem to require it anymore but it maybe causes errors in some different task?	12 years ago
Martin Linkhorst	c06e3fa94a	Just make sure we have a clean state before creating the project	12 years ago
Martin Linkhorst	621fe4a477	clone will return the same active record object (same id in the db) which will cause an issue relation to be invalid (same object in from and to). this creates two active record objects which you can then link to each other. probably active record changed the way they handle #clone	12 years ago
Martin Linkhorst	d9f422e6b0	use #joins instead of #includes since includes does seem to have a bug when combining with #maximum, #sum etc. ... this does an inner join instead of a left outer join so children without a priority at all won't be fetch. this should be fine since they wouldn't affect the maximum position value, which is requested here	12 years ago
Martin Linkhorst	74866ae596	omit default scope by using reorder	12 years ago
Martin Linkhorst	35bf0301f2	REVIEW: this gem adds the #auto_link method which is used several times in the code. it was removed in rails 3.1. we should get rid of this dependency at some point in time.	12 years ago
Martin Linkhorst	d9f2f17b5d	REVIEW: include ERB::Util module in order to use #h and co in the all helpers. ... also include that module wherever ActionView::Helpers::TagHelper is included, since it's very likely that they are used together we should probably remove #h completely if possible? is it? do we? don't know yet	12 years ago
Martin Linkhorst	7d2f6be3b0	remove the globalize3_patch.rb hack that allowed for uniqueness validation on translations. instead use the current git master since the fix is not yet released in version 0.2.0 of globalize3	12 years ago
Martin Linkhorst	2cf9a31f95	require fastercsv differently (taken form redmine)	12 years ago
Martin Linkhorst	61b9f5abfc	DEPRECATION FIX: remove require_library_or_gem, update the template hander api	12 years ago
Martin Linkhorst	01a502712d	small refactoring of the document tests. note the failing test that actually should pass.. investigate that later	12 years ago
Martin Linkhorst	e6e421297e	yay, and active record bug, woohoo :) TODO: fix me on rails 3.2	12 years ago
Martin Linkhorst	7de159fbca	refactor comment class and fixed the tests. give news a clearer api to create a comment for a news object. this couples news to the comment class atm but can easily be extracted into a module or so.	12 years ago
Martin Linkhorst	710c3cc2b3	add the database cleaner gem to easily purge data in the db	12 years ago
Martin Linkhorst	366b994407	match the new active record initializer signature when overwriting	12 years ago
Martin Linkhorst	f22075f7d7	use a notifier class to abstract the sending of notifications. atm this just checks whether the event should be notified. but in the future this class should abstract more to make the controllers/models and the mailer (i18n) simpler. let's see	12 years ago
Martin Linkhorst	8650015b41	let's not fail, when the subject doesn't have a project assigned. let's just return an empty array of recipients instead	12 years ago
Martin Linkhorst	a677322643	this is how it's done now. much better	12 years ago
Martin Linkhorst	46939eb4a6	REVIEW: remove unloaded calls, let's have a look wether that's still needed in rails 3	12 years ago
Martin Linkhorst	3566eb1849	fix deprecated stuff in the helper testcase	12 years ago
Martin Linkhorst	03b6fa88bc	remove deprecated constant	12 years ago
Martin Linkhorst	dc197a12e5	fix failing migration	12 years ago