openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	9ac377484f	replace legacy timelog_controller#destroy specs	6 years ago
Oliver Günther	de6d932b39	[26466] Don't set timelog timeframe condition to today if none exist When no date condition is set, it is set to the earliest date in the current project which in case of #26466 is empty. https://community.openproject.com/wp/26466	6 years ago
Jens Ulferts	f73b73ed6d	throw :abort in fake callback	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Mohamed Wael Khobalatte	71c1092e21	Fix various legacy specs	9 years ago
Mohamed Wael Khobalatte	626779d92d	Use assert_select instead of deprecated assert_tag	9 years ago
Stefan Botzenhart	9058b4ea90	Remove some assert_tag deprecation warnings	9 years ago
Stefan Botzenhart	e6972f5f9d	Move legacy spec to separate spec folder Legacy specs interfere with the normal ones so they need to be isolated.	9 years ago
Oliver Günther	6eeea9d1da	Avoid mutator sort on relations https://github.com/rails/rails/pull/13314 removed mutator methods (e.g., `Array#sort!`) from relations. This commit enforces either an ordering on the query itself where applicable, or uses a non-mutator sort.	9 years ago
Alex Coles	96fedeb976	Use Minitest assertions: assert_not_* => refute_ Test::Unit-compatible assertions are no longer available in Minitest 5, the version bundled with Rails 4.1. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	751f1f2801	rewrite legacy spec as feature spec Another option would have been to write it as unit tests for the controller. However, that would have required to restructure the controller as unit testing would otherwiese require to much mocking. Additionally, the feature specs are required anyway.	9 years ago
Alex Coles	654a77d944	Replace dynamic finder syntax in legacy specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6129e9f41f	Remove functional spec rescue_action boilerplate Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2efd6f4e45	Move legacy specs under spec/legacy Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	590481a01a	Prefer #map over #collect in legacy specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	b8567d13ed	Remove spec controller boilerplate; Replace ivars Prefer methods provided by rspec-rails. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1501012cf8	First spike porting Test::Unit tests to RSpec * Convert tests from Test::Unit to RSpec syntax, but keep Test::Unit- style assertions, configuring RSpec to support `:minitest` assertions * Update Helpers and backported Shoulda macros to work. Tests can be run with RSpec as follows: be rspec -Itest test/*/_test.rb Or by Suite: be rspec -Itest test/unit/*/_test.rb be rspec -Itest test/functional/*/_test.rb be rspec -Itest test/integration/*/_test.rb Tests should also be executable with the Rails Rake test tasks. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	da8a30bc8c	fix timelog controller test Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Alex Coles	b9b920e1d5	Fix formatting (w/ Rubocop) in test-unit tests Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	7f9822224b	Use 1.9+ Hash syntax in test-unit tests Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Stefan Frank	3064424762	fixed the watchers-permissions for workpackages	11 years ago
Martin Czuchra	ccef566070	Replaces the Issue constant in occurances outside of app. This also lets the old tests run again.	11 years ago
Hagen Schink	c25bbee177	Fixes functionals [skip ci]	11 years ago
Martin Czuchra	be6225984a	Changes Tracker to Type in tests.	11 years ago
Hagen Schink	a6f83f1d3c	Adapt references to work package	12 years ago
Hagen Schink	8baacde427	Fix tests	12 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice This was done using the rake task: rake copyright:update	12 years ago
Philipp Tessenow	f24dc2f4f1	attempt to fix a constant not defined error when executing mysql unit tests	12 years ago
Martin Linkhorst	d03301b60e	there are so many side effects by using only a subset of the fixtures and also it creates lots of annoying noise in the test code. this commit changes individual requires to :all which fixes some tests when test files are run individually or in a different order.	12 years ago
Jens Ulferts	b2e553daea	uses named_routes for paths inside time_entries	12 years ago
Martin Linkhorst	23ca8f6839	make timelogs readable (html_safe)	12 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Holger Just	07185fb169	[#436 ] Remove trailing whitespace	14 years ago
Eric Davis	99507a0391	[#197 ] Upgrade the copyright in the code files	14 years ago
Jean-Philippe Lang	789ccec246	Changed timelogs filters to use non-AJAX requests (#1965 ). git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5297 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Jean-Philippe Lang	335f8da5e8	Fixed: 404 when entering time with blank issue id (#7099 ). git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4511 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Jean-Baptiste Barth	17f86d964f	Use absolute paths in test/*/ requires for Ruby 1.9.2 compatibility. #4050 git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4509 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	718816c5d4	Refactor: convert timelogs to a REST resource (:time_entries) git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4250 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	435c90eb47	Refactor: extract TimelogController#edit to #update git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4248 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	4acd990ee2	Refactor: extract TimelogController#create from TimelogController#edit git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4244 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	068771ea07	Refactor: extract TimelogController#new from #edit git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4239 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	2ecca7e4df	Refactor: rename TimelogController#details to #index git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4235 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	e13790c62c	Refactor: extract TimelogController#report to a new controller class git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4232 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	cdfc57d544	Change the TimelogController's to/from dates based on the project time entries Instead of looking for the earliest and latest time entry system wide for the dates in the form, now TimelogController will only look at the time entries for the current project (and parent/sub projects). git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4087 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Eric Davis	c98f46d691	Handle unsuccessful destroys in TimelogController. #5700 Contributed by Jan git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3805 e93f8b46-1217-0410-a6f0-8f06a7374b81	15 years ago

10 Commits (150b52400c82c4b58b308696c6f4bdca6acab2cf)